From: Michal Simek <monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "Michal Simek"
<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Sören Brinkmann"
<soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] spi: xilinx: Use standard num-cs binding
Date: Thu, 12 Feb 2015 10:45:02 +0100 [thread overview]
Message-ID: <54DC761E.9040701@monstr.eu> (raw)
In-Reply-To: <67f3c196833c427a489ca2c530d08987a6b5ee2a.1421412912.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1497 bytes --]
Hi Mark,
On 01/16/2015 01:55 PM, Michal Simek wrote:
> Use standard num-cs binding property and setup
> "xlnx,num-ss-bits" as deprecated.
>
> Signed-off-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> ---
>
> drivers/spi/spi-xilinx.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 79bd84f43430..30e5180195bb 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -338,8 +338,15 @@ static int xilinx_spi_probe(struct platform_device *pdev)
> num_cs = pdata->num_chipselect;
> bits_per_word = pdata->bits_per_word;
> } else {
> - of_property_read_u32(pdev->dev.of_node, "xlnx,num-ss-bits",
> - &num_cs);
> + if (of_property_read_u32(pdev->dev.of_node, "num-cs",
> + &num_cs)) {
> + if (!of_property_read_u32(pdev->dev.of_node,
> + "xlnx,num-ss-bits",
> + &num_cs)) {
> + dev_err(&pdev->dev,
> + "property name 'xlnx,num-ss-bits' is deprecated.\n");
> + }
> + }
> }
>
> if (!num_cs) {
> --
> 1.8.2.3
>
Any update on this one?
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: monstr@monstr.eu (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: xilinx: Use standard num-cs binding
Date: Thu, 12 Feb 2015 10:45:02 +0100 [thread overview]
Message-ID: <54DC761E.9040701@monstr.eu> (raw)
In-Reply-To: <67f3c196833c427a489ca2c530d08987a6b5ee2a.1421412912.git.michal.simek@xilinx.com>
Hi Mark,
On 01/16/2015 01:55 PM, Michal Simek wrote:
> Use standard num-cs binding property and setup
> "xlnx,num-ss-bits" as deprecated.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/spi/spi-xilinx.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 79bd84f43430..30e5180195bb 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -338,8 +338,15 @@ static int xilinx_spi_probe(struct platform_device *pdev)
> num_cs = pdata->num_chipselect;
> bits_per_word = pdata->bits_per_word;
> } else {
> - of_property_read_u32(pdev->dev.of_node, "xlnx,num-ss-bits",
> - &num_cs);
> + if (of_property_read_u32(pdev->dev.of_node, "num-cs",
> + &num_cs)) {
> + if (!of_property_read_u32(pdev->dev.of_node,
> + "xlnx,num-ss-bits",
> + &num_cs)) {
> + dev_err(&pdev->dev,
> + "property name 'xlnx,num-ss-bits' is deprecated.\n");
> + }
> + }
> }
>
> if (!num_cs) {
> --
> 1.8.2.3
>
Any update on this one?
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150212/cb78f389/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <monstr@monstr.eu>
To: Mark Brown <broonie@kernel.org>
Cc: "Michal Simek" <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] spi: xilinx: Use standard num-cs binding
Date: Thu, 12 Feb 2015 10:45:02 +0100 [thread overview]
Message-ID: <54DC761E.9040701@monstr.eu> (raw)
In-Reply-To: <67f3c196833c427a489ca2c530d08987a6b5ee2a.1421412912.git.michal.simek@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
Hi Mark,
On 01/16/2015 01:55 PM, Michal Simek wrote:
> Use standard num-cs binding property and setup
> "xlnx,num-ss-bits" as deprecated.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/spi/spi-xilinx.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c
> index 79bd84f43430..30e5180195bb 100644
> --- a/drivers/spi/spi-xilinx.c
> +++ b/drivers/spi/spi-xilinx.c
> @@ -338,8 +338,15 @@ static int xilinx_spi_probe(struct platform_device *pdev)
> num_cs = pdata->num_chipselect;
> bits_per_word = pdata->bits_per_word;
> } else {
> - of_property_read_u32(pdev->dev.of_node, "xlnx,num-ss-bits",
> - &num_cs);
> + if (of_property_read_u32(pdev->dev.of_node, "num-cs",
> + &num_cs)) {
> + if (!of_property_read_u32(pdev->dev.of_node,
> + "xlnx,num-ss-bits",
> + &num_cs)) {
> + dev_err(&pdev->dev,
> + "property name 'xlnx,num-ss-bits' is deprecated.\n");
> + }
> + }
> }
>
> if (!num_cs) {
> --
> 1.8.2.3
>
Any update on this one?
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2015-02-12 9:45 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 12:55 [PATCH] spi: xilinx: Use standard num-cs binding Michal Simek
2015-01-16 12:55 ` Michal Simek
2015-01-16 12:55 ` Michal Simek
[not found] ` <67f3c196833c427a489ca2c530d08987a6b5ee2a.1421412912.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2015-02-12 9:45 ` Michal Simek [this message]
2015-02-12 9:45 ` Michal Simek
2015-02-12 9:45 ` Michal Simek
2015-03-08 19:00 ` Mark Brown
2015-03-08 19:00 ` Mark Brown
2015-03-08 19:00 ` Mark Brown
2015-03-27 10:55 ` Michal Simek
2015-03-27 10:55 ` Michal Simek
[not found] ` <2a81c738-f7e2-4387-b04c-05c9892ba8e4-reflc3kr++MPoeFrVf1fn+hlVc3/7hDbVaz/vdPVXQ4@public.gmane.org>
2015-03-27 17:53 ` Mark Brown
2015-03-27 17:53 ` Mark Brown
2015-03-27 17:53 ` Mark Brown
[not found] ` <20150327175318.GG1743-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-03-30 6:46 ` Michal Simek
2015-03-30 6:46 ` Michal Simek
2015-03-30 6:46 ` Michal Simek
[not found] ` <1bd88fda-314c-496a-ba8b-e9292f9c411b-neA4ZlFjCT3bHPOQ8RbMe2YJ4DzVTqeXkX/xN29GLwg@public.gmane.org>
2015-03-31 5:47 ` Mark Brown
2015-03-31 5:47 ` Mark Brown
2015-03-31 5:47 ` Mark Brown
2015-03-31 8:16 ` Michal Simek
2015-03-31 8:16 ` Michal Simek
[not found] ` <74214fc9-e5e4-42db-bd85-51ed02975388-reflc3kr++MPoeFrVf1fn+hlVc3/7hDbVaz/vdPVXQ4@public.gmane.org>
2015-03-31 11:16 ` Mark Brown
2015-03-31 11:16 ` Mark Brown
2015-03-31 11:16 ` Mark Brown
2015-03-31 11:25 ` Michal Simek
2015-03-31 11:25 ` Michal Simek
[not found] ` <98b110d7-f875-4bd5-98de-47641ac2134c-reflc3kr++MPoeFrVf1fn+hlVc3/7hDbVaz/vdPVXQ4@public.gmane.org>
2015-03-31 12:24 ` Mark Brown
2015-03-31 12:24 ` Mark Brown
2015-03-31 12:24 ` Mark Brown
[not found] ` <CAHTX3dJRGhwo7FW+VJxfEJmx-9FdjFN5EnxG0RRDfMOm3=VU4A@mail.gmail.com>
[not found] ` <CAHTX3dJRGhwo7FW+VJxfEJmx-9FdjFN5EnxG0RRDfMOm3=VU4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-14 5:35 ` Mark Brown
2015-02-14 5:35 ` Mark Brown
2015-02-23 10:22 ` Michal Simek
2015-02-23 10:22 ` Michal Simek
[not found] ` <54EAFF4A.1080605-pSz03upnqPeHXe+LvDLADg@public.gmane.org>
2015-02-24 14:52 ` Mark Brown
2015-02-24 14:52 ` Mark Brown
2015-02-24 14:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DC761E.9040701@monstr.eu \
--to=monstr-psz03upnqpehxe+lvdladg@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.