All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Jean Delvare <jdelvare@suse.de>
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 3/3] hwmon: (ibmpex) Allow format string checking
Date: Fri, 13 Feb 2015 05:09:01 +0000	[thread overview]
Message-ID: <54DD86ED.6010500@roeck-us.net> (raw)
In-Reply-To: <1423750517-26439-3-git-send-email-linux@rasmusvillemoes.dk>

On 02/12/2015 06:15 AM, Rasmus Villemoes wrote:
> The only difference between the three power_sensor_name_templates is
> whether there is a suffix of "", "_lowest" or "_highest". We might as
> well pull those into an array and use a literal format string,
> allowing gcc to do type checking of the arguments to
> sprintf. Incidentially, the same three suffixes are used in the
> temp_sensor_name_templates case, so we end up eliminating one static
> array.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Applied to -next after fixing 'line over 80 characters' checkpatch warning.

Thanks,
Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Jean Delvare <jdelvare@suse.de>
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] hwmon: (ibmpex) Allow format string checking
Date: Thu, 12 Feb 2015 21:09:01 -0800	[thread overview]
Message-ID: <54DD86ED.6010500@roeck-us.net> (raw)
In-Reply-To: <1423750517-26439-3-git-send-email-linux@rasmusvillemoes.dk>

On 02/12/2015 06:15 AM, Rasmus Villemoes wrote:
> The only difference between the three power_sensor_name_templates is
> whether there is a suffix of "", "_lowest" or "_highest". We might as
> well pull those into an array and use a literal format string,
> allowing gcc to do type checking of the arguments to
> sprintf. Incidentially, the same three suffixes are used in the
> temp_sensor_name_templates case, so we end up eliminating one static
> array.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Applied to -next after fixing 'line over 80 characters' checkpatch warning.

Thanks,
Guenter


  reply	other threads:[~2015-02-13  5:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12 14:15 [lm-sensors] [PATCH 1/3] hwmon: (applesmc) Allow format checking Rasmus Villemoes
2015-02-12 14:15 ` Rasmus Villemoes
2015-02-12 14:15 ` [lm-sensors] [PATCH 2/3] hwmon: (coretemp) " Rasmus Villemoes
2015-02-12 14:15   ` Rasmus Villemoes
2015-02-13  5:08   ` [lm-sensors] " Guenter Roeck
2015-02-13  5:08     ` Guenter Roeck
2015-02-12 14:15 ` [lm-sensors] [PATCH 3/3] hwmon: (ibmpex) Allow format string checking Rasmus Villemoes
2015-02-12 14:15   ` Rasmus Villemoes
2015-02-13  5:09   ` Guenter Roeck [this message]
2015-02-13  5:09     ` Guenter Roeck
2015-02-13  5:13 ` [lm-sensors] [PATCH 1/3] hwmon: (applesmc) Allow format checking Guenter Roeck
2015-02-13  5:13   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DD86ED.6010500@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.