All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang S <gang.chen@sunrus.com.cn>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "walt@tilera.com" <walt@tilera.com>,
	Chris Metcalf <cmetcalf@ezchip.com>,
	Riku Voipio <riku.voipio@iki.fi>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user.
Date: Fri, 13 Feb 2015 14:34:53 +0800	[thread overview]
Message-ID: <54DD9B0D.8020102@sunrus.com.cn> (raw)
In-Reply-To: <CAFEAcA_wRfuH9sp-fKHQNdQrnLtwA7T47KUVbNKq5C_AbRkJpQ@mail.gmail.com>

On 2/13/15 13:43, Peter Maydell wrote:
> On 13 February 2015 at 05:44, Chen Gang S <gang.chen@sunrus.com.cn> wrote:
>> Which issue of correctness will occur? I can not enum it.
> 
> If the Linux kernel does not implement these syscalls then
> QEMU must not either. Attempting them should fail, same as
> if you attempted them with the real kernel.
> 
>>  - linux-user already bypasses target linux kernel, and libc for tilegx
>>    can not generate these calls (not defined for libc, either).
> 
> Just because libc doesn't try to do these things doesn't mean
> QEMU should do the wrong thing for them.
> 
>>  - For any informal using, linux-user can still operate NR_open and
>>    others, it is harmless.
> 
> But it is still wrong.
> 

OK, I shall send patch v3 for it, after all related patches are reviewed.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

  reply	other threads:[~2015-02-13  6:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-12  0:00 [Qemu-devel] [PATCH] tile: Can load elf64 tilegx binary successfully for linux-user Chen Gang S
2015-02-12  0:12 ` Chen Gang S
2015-02-12  0:24   ` Chris Metcalf
2015-02-12  3:32     ` Chen Gang S
2015-02-12  3:48       ` Chen Gang S
2015-02-12 22:32         ` Chris Metcalf
2015-02-13  4:03           ` Chen Gang S
2015-02-12 22:31       ` Chris Metcalf
2015-02-13  4:43         ` Chen Gang S
2015-02-13  4:56           ` Peter Maydell
2015-02-13  5:44             ` Chen Gang S
2015-02-13  5:43               ` Peter Maydell
2015-02-13  6:34                 ` Chen Gang S [this message]
2015-02-12  0:49 ` Peter Maydell
2015-02-12  2:53   ` Chen Gang S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DD9B0D.8020102@sunrus.com.cn \
    --to=gang.chen@sunrus.com.cn \
    --cc=cmetcalf@ezchip.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=walt@tilera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.