From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH v2 3/3] unit: dbus: Add test for disconnect watch API
Date: Fri, 13 Feb 2015 09:09:29 -0600 [thread overview]
Message-ID: <54DE13A9.80003@gmail.com> (raw)
In-Reply-To: <1423837764.4196.37.camel@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
Hi Jukka,
>>
>> Then test this functionality in the unit test. If you're relying on
>> semi-manual tests for this stuff, your test coverage will be pretty small.
>>
>
> But don't we want to test this against dbus-daemon? Testing this watch
> API without dbus-daemon interaction seems pointless to me.
Why? In this case, what's the difference between getting a signal from
DBus Daemon vs simply making one up yourself? Isolating the code and
unit testing the hell out of it is much simpler without dbus-daemon
involved. Much faster and more compact too.
Regards,
-Denis
next prev parent reply other threads:[~2015-02-13 15:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 11:48 [PATCH v2 0/3] Add DBus disconnect watch support Jukka Rissanen
2015-02-12 11:48 ` [PATCH v2 1/3] dbus: Add AddMatch and RemoveMatch support Jukka Rissanen
2015-02-13 3:00 ` Denis Kenzior
2015-02-12 11:48 ` [PATCH v2 2/3] dbus: Add disconnect watch support Jukka Rissanen
2015-02-13 3:25 ` Denis Kenzior
2015-02-13 8:26 ` Jukka Rissanen
2015-02-13 14:01 ` Denis Kenzior
2015-02-13 14:23 ` Jukka Rissanen
2015-02-13 15:05 ` Denis Kenzior
2015-02-16 10:22 ` Jukka Rissanen
2015-02-12 11:48 ` [PATCH v2 3/3] unit: dbus: Add test for disconnect watch API Jukka Rissanen
2015-02-13 3:36 ` Denis Kenzior
2015-02-13 8:40 ` Jukka Rissanen
2015-02-13 14:10 ` Denis Kenzior
2015-02-13 14:29 ` Jukka Rissanen
2015-02-13 15:09 ` Denis Kenzior [this message]
2015-02-16 10:53 ` Jukka Rissanen
2015-02-16 15:58 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DE13A9.80003@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.