From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH v2 3/3] unit: dbus: Add test for disconnect watch API
Date: Thu, 12 Feb 2015 21:36:43 -0600 [thread overview]
Message-ID: <54DD714B.7080502@gmail.com> (raw)
In-Reply-To: <1423741733-26743-4-git-send-email-jukka.rissanen@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
On 02/12/2015 05:48 AM, Jukka Rissanen wrote:
> Test the dbus disconnect watch support.
> ---
> Makefile.am | 3 +
> unit/test-dbus-watch.c | 388 +++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 391 insertions(+)
> create mode 100644 unit/test-dbus-watch.c
>
That seems like an awful lot of copy-paste. Can we isolate the actual
signal dispatcher and unit test it properly? For example, you can
always make the message_filter function private (e.g. without
LIB_EXPORT) instead of static and feed it signals created using e.g.
l_dbus_message_new_signal or dbus_message_from_blob
Alternatively, fold this into test-dbus.c if possible.
Regards,
-Denis
next prev parent reply other threads:[~2015-02-13 3:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 11:48 [PATCH v2 0/3] Add DBus disconnect watch support Jukka Rissanen
2015-02-12 11:48 ` [PATCH v2 1/3] dbus: Add AddMatch and RemoveMatch support Jukka Rissanen
2015-02-13 3:00 ` Denis Kenzior
2015-02-12 11:48 ` [PATCH v2 2/3] dbus: Add disconnect watch support Jukka Rissanen
2015-02-13 3:25 ` Denis Kenzior
2015-02-13 8:26 ` Jukka Rissanen
2015-02-13 14:01 ` Denis Kenzior
2015-02-13 14:23 ` Jukka Rissanen
2015-02-13 15:05 ` Denis Kenzior
2015-02-16 10:22 ` Jukka Rissanen
2015-02-12 11:48 ` [PATCH v2 3/3] unit: dbus: Add test for disconnect watch API Jukka Rissanen
2015-02-13 3:36 ` Denis Kenzior [this message]
2015-02-13 8:40 ` Jukka Rissanen
2015-02-13 14:10 ` Denis Kenzior
2015-02-13 14:29 ` Jukka Rissanen
2015-02-13 15:09 ` Denis Kenzior
2015-02-16 10:53 ` Jukka Rissanen
2015-02-16 15:58 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DD714B.7080502@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.