All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: "Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Paul Walmsley" <paul@pwsan.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Felipe Balbi <balbi@ti.com>, Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH 0/9] ARM: DRA7: add display support
Date: Fri, 13 Feb 2015 10:01:29 -0600	[thread overview]
Message-ID: <54DE1FD9.6030801@ti.com> (raw)
In-Reply-To: <1423840286-18377-1-git-send-email-tomi.valkeinen@ti.com>

On 02/13/2015 09:11 AM, Tomi Valkeinen wrote:
> Hi,
> 
> This series adds the arch/arm/ side of the display support for DRA7 (DRA72x,
> DRA74x, AM54xx) SoCs. Also support for HDMI output on x15 and DRA72 EVM boards
> is added.
> 
> The series is based on OMAPDSS driver patches in fbdev changes for 3.20, which
> have been merged to Linus' tree.
> 
> The changes are very similar to OMAP5 DSS. All the other patches look fine to
> me except the "RFC: ARM: DRA7: enable DSS_DESHDCP_CLKEN". That's been discussed
> earlier with Paul and Tero, but I don't think we have any good solution for it
> yet.

Is there some specific tag I can test this on (some next perhaps?), I
get the following error:
build fail, Error:
arch/arm/mach-omap2/display.c: In function ‘omap_display_get_version’:
arch/arm/mach-omap2/display.c:285:10: error: ‘OMAPDSS_VER_DRA7xx’
undeclared (first use in this function)
arch/arm/mach-omap2/display.c:285:10: note: each undeclared identifier
is reported only once for each function it appears in
arch/arm/mach-omap2/display.c:288:1: warning: control reaches end of
non-void function [-Wreturn-type]
make[1]: *** [arch/arm/mach-omap2/display.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2
make: *** Waiting for unfinished jobs....


Further are you proposing this for 3.20 or 3.21 window? 3.20, we seem
to have already missed.


> 
>  Tomi
> 
> Tomi Valkeinen (9):
>   arm/dts: dra7xx: add 'ti,set-rate-parent' for dss_dss_clk
^^
>   ARM: DRA7: hwmod: add DMM hwmod description
>   ARM: DRA7: hwmod: set DSS submodule parent hwmods
>   ARM: OMAP: display: change compat names to array
>   ARM: OMAP2+: display: detect DRA7 DSS
>   arm/dts: dra7.dtsi: add DSS support
^^
>   arm/dts: dra72-evm.dts: add HDMI
^^
>   arm/dts: am57xx-beagle-x15.dts: add HDMI

ARM: dts: am57xx-beagle-x15: Add HDMI

Would be good to follow above convention for all dts patches $subject.


>   RFC: ARM: DRA7: enable DSS_DESHDCP_CLKEN
> 
>  arch/arm/boot/dts/am57xx-beagle-x15.dts   |  80 +++++++++++++++++++++
>  arch/arm/boot/dts/dra7.dtsi               |  38 ++++++++++
>  arch/arm/boot/dts/dra72-evm.dts           | 111 ++++++++++++++++++++++++++++++
>  arch/arm/boot/dts/dra72x.dtsi             |  11 +++
>  arch/arm/boot/dts/dra74x.dtsi             |  15 ++++
>  arch/arm/boot/dts/dra7xx-clocks.dtsi      |   1 +
>  arch/arm/mach-omap2/display.c             |  32 +++++----
>  arch/arm/mach-omap2/io.c                  |  11 +++
>  arch/arm/mach-omap2/omap_hwmod_7xx_data.c |  32 +++++++++
>  9 files changed, 316 insertions(+), 15 deletions(-)
> 


-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/9] ARM: DRA7: add display support
Date: Fri, 13 Feb 2015 10:01:29 -0600	[thread overview]
Message-ID: <54DE1FD9.6030801@ti.com> (raw)
In-Reply-To: <1423840286-18377-1-git-send-email-tomi.valkeinen@ti.com>

On 02/13/2015 09:11 AM, Tomi Valkeinen wrote:
> Hi,
> 
> This series adds the arch/arm/ side of the display support for DRA7 (DRA72x,
> DRA74x, AM54xx) SoCs. Also support for HDMI output on x15 and DRA72 EVM boards
> is added.
> 
> The series is based on OMAPDSS driver patches in fbdev changes for 3.20, which
> have been merged to Linus' tree.
> 
> The changes are very similar to OMAP5 DSS. All the other patches look fine to
> me except the "RFC: ARM: DRA7: enable DSS_DESHDCP_CLKEN". That's been discussed
> earlier with Paul and Tero, but I don't think we have any good solution for it
> yet.

Is there some specific tag I can test this on (some next perhaps?), I
get the following error:
build fail, Error:
arch/arm/mach-omap2/display.c: In function ?omap_display_get_version?:
arch/arm/mach-omap2/display.c:285:10: error: ?OMAPDSS_VER_DRA7xx?
undeclared (first use in this function)
arch/arm/mach-omap2/display.c:285:10: note: each undeclared identifier
is reported only once for each function it appears in
arch/arm/mach-omap2/display.c:288:1: warning: control reaches end of
non-void function [-Wreturn-type]
make[1]: *** [arch/arm/mach-omap2/display.o] Error 1
make: *** [arch/arm/mach-omap2] Error 2
make: *** Waiting for unfinished jobs....


Further are you proposing this for 3.20 or 3.21 window? 3.20, we seem
to have already missed.


> 
>  Tomi
> 
> Tomi Valkeinen (9):
>   arm/dts: dra7xx: add 'ti,set-rate-parent' for dss_dss_clk
^^
>   ARM: DRA7: hwmod: add DMM hwmod description
>   ARM: DRA7: hwmod: set DSS submodule parent hwmods
>   ARM: OMAP: display: change compat names to array
>   ARM: OMAP2+: display: detect DRA7 DSS
>   arm/dts: dra7.dtsi: add DSS support
^^
>   arm/dts: dra72-evm.dts: add HDMI
^^
>   arm/dts: am57xx-beagle-x15.dts: add HDMI

ARM: dts: am57xx-beagle-x15: Add HDMI

Would be good to follow above convention for all dts patches $subject.


>   RFC: ARM: DRA7: enable DSS_DESHDCP_CLKEN
> 
>  arch/arm/boot/dts/am57xx-beagle-x15.dts   |  80 +++++++++++++++++++++
>  arch/arm/boot/dts/dra7.dtsi               |  38 ++++++++++
>  arch/arm/boot/dts/dra72-evm.dts           | 111 ++++++++++++++++++++++++++++++
>  arch/arm/boot/dts/dra72x.dtsi             |  11 +++
>  arch/arm/boot/dts/dra74x.dtsi             |  15 ++++
>  arch/arm/boot/dts/dra7xx-clocks.dtsi      |   1 +
>  arch/arm/mach-omap2/display.c             |  32 +++++----
>  arch/arm/mach-omap2/io.c                  |  11 +++
>  arch/arm/mach-omap2/omap_hwmod_7xx_data.c |  32 +++++++++
>  9 files changed, 316 insertions(+), 15 deletions(-)
> 


-- 
Regards,
Nishanth Menon

  parent reply	other threads:[~2015-02-13 16:01 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 15:11 [PATCH 0/9] ARM: DRA7: add display support Tomi Valkeinen
2015-02-13 15:11 ` Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 1/9] arm/dts: dra7xx: add 'ti,set-rate-parent' for dss_dss_clk Tomi Valkeinen
2015-02-13 15:11   ` [PATCH 1/9] arm/dts: dra7xx: add 'ti, set-rate-parent' " Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 2/9] ARM: DRA7: hwmod: add DMM hwmod description Tomi Valkeinen
2015-02-13 15:11   ` Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 3/9] ARM: DRA7: hwmod: set DSS submodule parent hwmods Tomi Valkeinen
2015-02-13 15:11   ` Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 4/9] ARM: OMAP: display: change compat names to array Tomi Valkeinen
2015-02-13 15:11   ` Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 5/9] ARM: OMAP2+: display: detect DRA7 DSS Tomi Valkeinen
2015-02-13 15:11   ` Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 6/9] arm/dts: dra7.dtsi: add DSS support Tomi Valkeinen
2015-02-13 15:11   ` Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 7/9] arm/dts: dra72-evm.dts: add HDMI Tomi Valkeinen
2015-02-13 15:11   ` Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 8/9] arm/dts: am57xx-beagle-x15.dts: " Tomi Valkeinen
2015-02-13 15:11   ` Tomi Valkeinen
2015-02-13 15:11 ` [PATCH 9/9] RFC: ARM: DRA7: enable DSS_DESHDCP_CLKEN Tomi Valkeinen
2015-02-13 15:11   ` Tomi Valkeinen
2015-02-13 15:25   ` Nishanth Menon
2015-02-13 15:25     ` Nishanth Menon
2015-02-13 15:42     ` Tero Kristo
2015-02-13 15:42       ` Tero Kristo
2015-02-20 11:46       ` Tomi Valkeinen
2015-02-20 11:46         ` Tomi Valkeinen
2015-02-20 12:59         ` Tero Kristo
2015-02-20 12:59           ` Tero Kristo
2015-02-20 13:48           ` Tomi Valkeinen
2015-02-20 13:48             ` Tomi Valkeinen
2015-02-20 16:59             ` Tero Kristo
2015-02-20 16:59               ` Tero Kristo
2015-02-16  8:28     ` Tomi Valkeinen
2015-02-16  8:28       ` Tomi Valkeinen
2015-02-13 16:01 ` Nishanth Menon [this message]
2015-02-13 16:01   ` [PATCH 0/9] ARM: DRA7: add display support Nishanth Menon
2015-02-16  8:30   ` Tomi Valkeinen
2015-02-16  8:30     ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DE1FD9.6030801@ti.com \
    --to=nm@ti.com \
    --cc=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=t-kristo@ti.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.