From: Linhaifeng <haifeng.lin@huawei.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/3] vhost-user: update the protocol.
Date: Sun, 15 Feb 2015 09:28:58 +0800 [thread overview]
Message-ID: <54DFF65A.3060305@huawei.com> (raw)
In-Reply-To: <20150214210336.GA1281@redhat.com>
On 2015/2/15 5:03, Michael S. Tsirkin wrote:
> On Fri, Feb 13, 2015 at 09:45:37PM +0800, linhaifeng wrote:
>> @@ -35,7 +39,7 @@ consists of 3 header fields and a payload:
>>
>> * Request: 32-bit type of the request
>> * Flags: 32-bit bit field:
>> - - Lower 2 bits are the version (currently 0x01)
>> + - Lower 2 bits are the version (currently 0x06)
>> - Bit 2 is the reply flag - needs to be sent on each reply from the slave
>> * Size - 32-bit size of the payload
>>
>
> How do you encode 0x6 in a 2 bit field?
>
I think the reply flag is unnecessary,so i remove it and let all the field as version.
The existing version is 0x5 now.
Sorry, i need to update the vhost-user.txt to describe it.
--
Regards,
Haifeng
next prev parent reply other threads:[~2015-02-15 1:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 13:45 [Qemu-devel] [PATCH v2 0/3] vhost-user: support safe protocol linhaifeng
2015-02-13 13:45 ` [Qemu-devel] [PATCH v2 1/3] vhost-user: update the protocol linhaifeng
2015-02-14 21:03 ` Michael S. Tsirkin
2015-02-15 1:28 ` Linhaifeng [this message]
2015-02-13 13:45 ` [Qemu-devel] [PATCH v2 2/3] vhost-user:update the version to 0x6 linhaifeng
2015-02-13 13:45 ` [Qemu-devel] [PATCH v2 3/3] vhost-user:add reply for other messages linhaifeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DFF65A.3060305@huawei.com \
--to=haifeng.lin@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.