All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.huangpeng@huawei.com
Subject: Re: [Qemu-trivial] [PATCH 03/11] pl330.c: remove superfluous '\n' around error_setg
Date: Mon, 16 Feb 2015 12:45:21 +0300	[thread overview]
Message-ID: <54E1BC31.4000301@msgid.tls.msk.ru> (raw)
In-Reply-To: <1423627934-11676-4-git-send-email-arei.gonglei@huawei.com>

11.02.2015 07:12, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  hw/dma/pl330.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c
> index 16cf77e..0f72b59 100644
> --- a/hw/dma/pl330.c
> +++ b/hw/dma/pl330.c
> @@ -1566,7 +1566,7 @@ static void pl330_realize(DeviceState *dev, Error **errp)
>          s->cfg[1] |= 5;
>          break;
>      default:
> -        error_setg(errp, "Bad value for i-cache_len property: %" PRIx8 "\n",
> +        error_setg(errp, "Bad value for i-cache_len property: %" PRIx8 "",

Not hugely important but there's no need in the trailing "" here and below.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [PATCH 03/11] pl330.c: remove superfluous '\n' around error_setg
Date: Mon, 16 Feb 2015 12:45:21 +0300	[thread overview]
Message-ID: <54E1BC31.4000301@msgid.tls.msk.ru> (raw)
In-Reply-To: <1423627934-11676-4-git-send-email-arei.gonglei@huawei.com>

11.02.2015 07:12, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  hw/dma/pl330.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c
> index 16cf77e..0f72b59 100644
> --- a/hw/dma/pl330.c
> +++ b/hw/dma/pl330.c
> @@ -1566,7 +1566,7 @@ static void pl330_realize(DeviceState *dev, Error **errp)
>          s->cfg[1] |= 5;
>          break;
>      default:
> -        error_setg(errp, "Bad value for i-cache_len property: %" PRIx8 "\n",
> +        error_setg(errp, "Bad value for i-cache_len property: %" PRIx8 "",

Not hugely important but there's no need in the trailing "" here and below.

Thanks,

/mjt

  reply	other threads:[~2015-02-16  9:45 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11  4:12 [Qemu-trivial] [PATCH 00/11] trivial: Remove superfluous '\n' around error_report/error_setg arei.gonglei
2015-02-11  4:12 ` [Qemu-devel] " arei.gonglei
2015-02-11  4:12 ` [Qemu-trivial] [PATCH 01/11] block: remove " arei.gonglei
2015-02-11  4:12   ` [Qemu-devel] " arei.gonglei
2015-02-11  4:12 ` [Qemu-trivial] [PATCH 02/11] a9gtimer: remove superfluous '\n' around error_setg arei.gonglei
2015-02-11  4:12   ` [Qemu-devel] " arei.gonglei
2015-02-11  4:12 ` [Qemu-trivial] [PATCH 03/11] pl330.c: " arei.gonglei
2015-02-11  4:12   ` [Qemu-devel] " arei.gonglei
2015-02-16  9:45   ` Michael Tokarev [this message]
2015-02-16  9:45     ` Michael Tokarev
2015-02-25  4:18     ` [Qemu-trivial] " Gonglei
2015-02-25  4:18       ` [Qemu-devel] " Gonglei
2015-02-11  4:12 ` [Qemu-trivial] [PATCH 04/11] numa: " arei.gonglei
2015-02-11  4:12   ` [Qemu-devel] " arei.gonglei
2015-02-11  4:12 ` [Qemu-trivial] [PATCH 05/11] Remove superfluous '\n' around error_report() arei.gonglei
2015-02-11  4:12   ` [Qemu-devel] " arei.gonglei
2015-02-11  4:12 ` [Qemu-trivial] [PATCH 06/11] vhost-scsi: " arei.gonglei
2015-02-11  4:12   ` [Qemu-devel] " arei.gonglei
2015-02-11  4:12 ` [Qemu-trivial] [PATCH 07/11] vfio: " arei.gonglei
2015-02-11  4:12   ` [Qemu-devel] " arei.gonglei
2015-02-11  4:12 ` [Qemu-trivial] [PATCH 08/11] xtensa: " arei.gonglei
2015-02-11  4:12   ` [Qemu-devel] " arei.gonglei
2015-02-11  4:12 ` [Qemu-trivial] [PATCH 09/11] tpm: " arei.gonglei
2015-02-11  4:12   ` [Qemu-devel] " arei.gonglei
2015-02-11  4:12 ` [Qemu-trivial] [PATCH 10/11] arm/digic_boards: " arei.gonglei
2015-02-11  4:12   ` [Qemu-devel] " arei.gonglei
2015-02-11  4:12 ` [Qemu-trivial] [PATCH 11/11] vhost: " arei.gonglei
2015-02-11  4:12   ` [Qemu-devel] " arei.gonglei
2015-02-11 13:41 ` [Qemu-trivial] [Qemu-devel] [PATCH 00/11] trivial: Remove superfluous '\n' around error_report/error_setg Markus Armbruster
2015-02-11 13:41   ` Markus Armbruster
2015-02-12  1:10   ` [Qemu-trivial] " Gonglei
2015-02-12  1:10     ` Gonglei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E1BC31.4000301@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=arei.gonglei@huawei.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.