From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [bug #44239] Behavior of syslinux_parse differs from SYSLINUX for initrd= option
Date: Mon, 16 Feb 2015 16:07:36 +0100 [thread overview]
Message-ID: <54E207B8.6030607@gmail.com> (raw)
In-Reply-To: <20150213203232.GG688@loar>
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
On 13.02.2015 21:32, Lunar wrote:
> Andrei Borzenkov:
>> Follow-up Comment #1, bug #44239 (project grub):
>>
>> Can't comment about behavior itself. Re. patch
>>
>> + cmdline = grub_strdup(curentry->append);
>> Error check missing.
>>
>> + grub_free(cmdline);
>> You need to delete free(cmdline) later.
>
> Both fixed.
>
>> Again, can you post updated version to grub-devel for easier review?
>
> Here it is.
>
The code at this place turned out to be not very understandable. I
simplified the code and did the change you requested.
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
prev parent reply other threads:[~2015-02-16 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150213-163645.sv98365.99674@savannah.gnu.org>
[not found] ` <20150213-191419.sv89796.29507@savannah.gnu.org>
2015-02-13 20:32 ` [bug #44239] Behavior of syslinux_parse differs from SYSLINUX for initrd= option Lunar
2015-02-16 15:07 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E207B8.6030607@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.