All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <boaz@plexistor.com>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	x86@kernel.org, linux-kernel <linux-kernel@vger.kernel.org>,
	"Roger C. Pao" <rcpao.enmotus@gmail.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-nvdimm <linux-nvdimm@lists.01.org>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [Linux-nvdimm] [PATCH 0/2] e820: Fix handling of NvDIMM chips
Date: Tue, 17 Feb 2015 10:42:26 +0200	[thread overview]
Message-ID: <54E2FEF2.8060701@plexistor.com> (raw)
In-Reply-To: <20150216220302.GF3364@wil.cx>

On 02/17/2015 12:03 AM, Matthew Wilcox wrote:
> On Mon, Feb 16, 2015 at 01:07:07PM +0200, Boaz Harrosh wrote:
>> In any way this is a problem for the new type-12 NvDIMM memory chips that
>> are circulating around. (It is estimated that there are already 100ds of
>> thousands NvDIMM chips in active use)
> 
> Hang on.  NV-DIMM chips don't know anyhing about E820 tables.  They don't
> have anything in them that says "I am type 12!".  How they are reported
> is up to the BIOS.  Just because your BIOS vendor has chosen to report
> tham as type 12 doesn't mean that any other BIOS vedor is going to have
> done the same thing.
> 
> Fortunately, the BIOS people have all got together and decided what
> they're going to do, and it's not type 12.  Unfortunately, I think
> I'm bound by various agreements to not say what they are going to do
> until they do.  But putting this temporary workaround in the kernel to
> accomodate one BIOS vendor's unreleased experimental code seems like
> entirely the wrong idea.
> 

I had a feeling I'm entering an holy war ;-).

I hope you are OK with my first patch. That an unknown type need not
be reported busy, and behave same as "reserved"?

Then if we agree about PATCH-1, which is the actual fix.
Then the 2nd patch (hence the RFC btw) is nothing more than
a name.

I have an old BIOS that knows nothing of NvDIMM, actually a few
of them they all report 12.
The fact of the matter is that all the people I've talked with,
reported that different vendor chips, all came up type-12.
Perhaps type-12 just means "Unknown to current BIOS"

What is the name you suggest "type-12" "unknown-12".
Do you understand why they all come out 12 ?

Thanks
Boaz


WARNING: multiple messages have this Message-ID (diff)
From: Boaz Harrosh <boaz@plexistor.com>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	x86@kernel.org, linux-kernel <linux-kernel@vger.kernel.org>,
	"Roger C. Pao" <rcpao.enmotus@gmail.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-nvdimm <linux-nvdimm@ml01.01.org>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [Linux-nvdimm] [PATCH 0/2] e820: Fix handling of NvDIMM chips
Date: Tue, 17 Feb 2015 10:42:26 +0200	[thread overview]
Message-ID: <54E2FEF2.8060701@plexistor.com> (raw)
In-Reply-To: <20150216220302.GF3364@wil.cx>

On 02/17/2015 12:03 AM, Matthew Wilcox wrote:
> On Mon, Feb 16, 2015 at 01:07:07PM +0200, Boaz Harrosh wrote:
>> In any way this is a problem for the new type-12 NvDIMM memory chips that
>> are circulating around. (It is estimated that there are already 100ds of
>> thousands NvDIMM chips in active use)
> 
> Hang on.  NV-DIMM chips don't know anyhing about E820 tables.  They don't
> have anything in them that says "I am type 12!".  How they are reported
> is up to the BIOS.  Just because your BIOS vendor has chosen to report
> tham as type 12 doesn't mean that any other BIOS vedor is going to have
> done the same thing.
> 
> Fortunately, the BIOS people have all got together and decided what
> they're going to do, and it's not type 12.  Unfortunately, I think
> I'm bound by various agreements to not say what they are going to do
> until they do.  But putting this temporary workaround in the kernel to
> accomodate one BIOS vendor's unreleased experimental code seems like
> entirely the wrong idea.
> 

I had a feeling I'm entering an holy war ;-).

I hope you are OK with my first patch. That an unknown type need not
be reported busy, and behave same as "reserved"?

Then if we agree about PATCH-1, which is the actual fix.
Then the 2nd patch (hence the RFC btw) is nothing more than
a name.

I have an old BIOS that knows nothing of NvDIMM, actually a few
of them they all report 12.
The fact of the matter is that all the people I've talked with,
reported that different vendor chips, all came up type-12.
Perhaps type-12 just means "Unknown to current BIOS"

What is the name you suggest "type-12" "unknown-12".
Do you understand why they all come out 12 ?

Thanks
Boaz


  reply	other threads:[~2015-02-17  8:42 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16 11:07 [PATCH 0/2] e820: Fix handling of NvDIMM chips Boaz Harrosh
2015-02-16 11:07 ` Boaz Harrosh
2015-02-16 11:13 ` [PATCH 1/2] e820: Don't let unknown DIMM type come out BUSY Boaz Harrosh
2015-02-16 11:13   ` Boaz Harrosh
2015-02-16 11:16 ` [RFC 2/2] e820: Add the NvDIMM Memory type (type-12) Boaz Harrosh
2015-02-16 11:16   ` Boaz Harrosh
2015-02-16 11:24 ` [PATCH 3/3] pmem: Allow request_mem to fail, (CONFIG_BLK_DEV_PMEM_IGNORE_REQUEST_MEM_RET) Boaz Harrosh
2015-02-16 11:24   ` Boaz Harrosh
2015-02-17 20:52   ` Ross Zwisler
2015-02-17 20:52     ` Ross Zwisler
2015-02-18  9:58     ` Boaz Harrosh
2015-02-18  9:58       ` Boaz Harrosh
2015-02-16 22:03 ` [Linux-nvdimm] [PATCH 0/2] e820: Fix handling of NvDIMM chips Matthew Wilcox
2015-02-16 22:03   ` Matthew Wilcox
2015-02-17  8:42   ` Boaz Harrosh [this message]
2015-02-17  8:42     ` Boaz Harrosh
2015-02-18 18:15     ` Dan Williams
2015-02-18 18:15       ` Dan Williams
2015-02-18 18:30       ` Ingo Molnar
2015-02-18 18:30         ` Ingo Molnar
2015-02-18 18:44         ` Dan Williams
2015-02-18 18:44           ` Dan Williams
2015-02-18 18:53           ` Ingo Molnar
2015-02-18 18:53             ` Ingo Molnar
2015-02-18 19:18             ` Dan Williams
2015-02-18 19:18               ` Dan Williams
2015-02-18 19:27               ` Ingo Molnar
2015-02-18 19:27                 ` Ingo Molnar
2015-02-18 19:35                 ` Dan Williams
2015-02-18 19:35                   ` Dan Williams
2015-02-19 10:27                   ` Boaz Harrosh
2015-02-19 10:27                     ` Boaz Harrosh
2015-02-19 10:30                     ` Ingo Molnar
2015-02-19 10:30                       ` Ingo Molnar
2015-02-19  0:47       ` Christoph Hellwig
2015-02-19  1:03         ` Dan Williams
2015-02-19 10:01           ` Ingo Molnar
2015-02-19 10:29             ` Boaz Harrosh
2015-02-19 10:31               ` Ingo Molnar
2015-02-19 10:40                 ` Boaz Harrosh
2015-02-19  9:25         ` Boaz Harrosh
2015-02-22 16:27           ` Christoph Hellwig
2015-02-22 17:05             ` Boaz Harrosh
2015-02-22 17:15               ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E2FEF2.8060701@plexistor.com \
    --to=boaz@plexistor.com \
    --cc=dan.j.williams@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=mingo@redhat.com \
    --cc=rcpao.enmotus@gmail.com \
    --cc=ross.zwisler@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=willy@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.