From: Stephen Boyd <sboyd@codeaurora.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency
Date: Tue, 17 Feb 2015 14:24:51 -0800 [thread overview]
Message-ID: <54E3BFB3.5030801@codeaurora.org> (raw)
In-Reply-To: <1424093802-5488-1-git-send-email-k.kozlowski@samsung.com>
On 02/16/15 05:36, Krzysztof Kozlowski wrote:
> During CPU shutdown the exynos_cpu_power_down() is called after
> disabling cache coherency and it uses LDREX and STREX instructions (by
> calling of_machine_is_compatible() -> kobject_get() -> kref_get()).
>
> The LDREX and STREX should not be used after disabling the cache
> coherency so just use soc_is_exynos().
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Fixes: adc548d77c22 ("ARM: EXYNOS: Use MCPM call-backs to support S2R on exynos5420")
> Cc: <stable@vger.kernel.org>
> Reported-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Looks good to me.
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency
Date: Tue, 17 Feb 2015 14:24:51 -0800 [thread overview]
Message-ID: <54E3BFB3.5030801@codeaurora.org> (raw)
In-Reply-To: <1424093802-5488-1-git-send-email-k.kozlowski@samsung.com>
On 02/16/15 05:36, Krzysztof Kozlowski wrote:
> During CPU shutdown the exynos_cpu_power_down() is called after
> disabling cache coherency and it uses LDREX and STREX instructions (by
> calling of_machine_is_compatible() -> kobject_get() -> kref_get()).
>
> The LDREX and STREX should not be used after disabling the cache
> coherency so just use soc_is_exynos().
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Fixes: adc548d77c22 ("ARM: EXYNOS: Use MCPM call-backs to support S2R on exynos5420")
> Cc: <stable@vger.kernel.org>
> Reported-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Looks good to me.
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-02-17 22:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 13:36 [PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency Krzysztof Kozlowski
2015-02-16 13:36 ` Krzysztof Kozlowski
2015-02-17 22:24 ` Stephen Boyd [this message]
2015-02-17 22:24 ` Stephen Boyd
2015-02-26 20:52 ` Kukjin Kim
2015-02-26 20:52 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E3BFB3.5030801@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.