* [PATCH v2] ath10k: Increase AST table SKID length limit
@ 2015-02-13 15:36 ` SenthilKumar Jegadeesan
0 siblings, 0 replies; 8+ messages in thread
From: SenthilKumar Jegadeesan @ 2015-02-13 15:36 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, SenthilKumar Jegadeesan
The current SKID length configuration causes firmware
to reject peer creation for not able to allocate
AST entries for peers. This issue is observed when
least significant 3 bytes are used ramdomly to create
client MAC addresses.
AST table SKID length configuration is increased to
maximum value to fix this issue.
Signed-off-by: SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/hw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
index 460771f..7f04645 100644
--- a/drivers/net/wireless/ath/ath10k/hw.h
+++ b/drivers/net/wireless/ath/ath10k/hw.h
@@ -223,7 +223,7 @@ struct ath10k_pktlog_hdr {
#define TARGET_10X_NUM_WDS_ENTRIES 32
#define TARGET_10X_DMA_BURST_SIZE 0
#define TARGET_10X_MAC_AGGR_DELIM 0
-#define TARGET_10X_AST_SKID_LIMIT 16
+#define TARGET_10X_AST_SKID_LIMIT 128
#define TARGET_10X_NUM_STATIONS 128
#define TARGET_10X_NUM_PEERS ((TARGET_10X_NUM_STATIONS) + \
(TARGET_10X_NUM_VDEVS))
--
1.9.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v2] ath10k: Increase AST table SKID length limit
@ 2015-02-13 15:36 ` SenthilKumar Jegadeesan
0 siblings, 0 replies; 8+ messages in thread
From: SenthilKumar Jegadeesan @ 2015-02-13 15:36 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, SenthilKumar Jegadeesan
The current SKID length configuration causes firmware
to reject peer creation for not able to allocate
AST entries for peers. This issue is observed when
least significant 3 bytes are used ramdomly to create
client MAC addresses.
AST table SKID length configuration is increased to
maximum value to fix this issue.
Signed-off-by: SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/hw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
index 460771f..7f04645 100644
--- a/drivers/net/wireless/ath/ath10k/hw.h
+++ b/drivers/net/wireless/ath/ath10k/hw.h
@@ -223,7 +223,7 @@ struct ath10k_pktlog_hdr {
#define TARGET_10X_NUM_WDS_ENTRIES 32
#define TARGET_10X_DMA_BURST_SIZE 0
#define TARGET_10X_MAC_AGGR_DELIM 0
-#define TARGET_10X_AST_SKID_LIMIT 16
+#define TARGET_10X_AST_SKID_LIMIT 128
#define TARGET_10X_NUM_STATIONS 128
#define TARGET_10X_NUM_PEERS ((TARGET_10X_NUM_STATIONS) + \
(TARGET_10X_NUM_VDEVS))
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2] ath10k: Increase AST table SKID length limit
2015-02-13 15:36 ` SenthilKumar Jegadeesan
@ 2015-02-18 20:23 ` Ben Greear
-1 siblings, 0 replies; 8+ messages in thread
From: Ben Greear @ 2015-02-18 20:23 UTC (permalink / raw)
To: SenthilKumar Jegadeesan; +Cc: linux-wireless, ath10k
Have you tried testing this with 30+ stations
associated and streaming data, and with other traffic on
nearby channels (say, channel 1 and 6)?
We see bad performance drop-off when we set number-of-peers above
100 (with CT firmware). My kernel will set AST skid limit to number-of-peers + number-of-vdevs.
Performance is best at 32 peers or less (so skid is about 40).
I am wondering if the root cause is firmware/hardware walking the full skid-length for pkts
from un-associated peers on same (or neighbouring) channels, or maybe unlucky hash distribution
in existing peers?
Thanks,
Ben
On 02/13/2015 07:36 AM, SenthilKumar Jegadeesan wrote:
> The current SKID length configuration causes firmware
> to reject peer creation for not able to allocate
> AST entries for peers. This issue is observed when
> least significant 3 bytes are used ramdomly to create
> client MAC addresses.
>
> AST table SKID length configuration is increased to
> maximum value to fix this issue.
>
> Signed-off-by: SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/hw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
> index 460771f..7f04645 100644
> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -223,7 +223,7 @@ struct ath10k_pktlog_hdr {
> #define TARGET_10X_NUM_WDS_ENTRIES 32
> #define TARGET_10X_DMA_BURST_SIZE 0
> #define TARGET_10X_MAC_AGGR_DELIM 0
> -#define TARGET_10X_AST_SKID_LIMIT 16
> +#define TARGET_10X_AST_SKID_LIMIT 128
> #define TARGET_10X_NUM_STATIONS 128
> #define TARGET_10X_NUM_PEERS ((TARGET_10X_NUM_STATIONS) + \
> (TARGET_10X_NUM_VDEVS))
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2] ath10k: Increase AST table SKID length limit
@ 2015-02-18 20:23 ` Ben Greear
0 siblings, 0 replies; 8+ messages in thread
From: Ben Greear @ 2015-02-18 20:23 UTC (permalink / raw)
To: SenthilKumar Jegadeesan; +Cc: ath10k, linux-wireless
Have you tried testing this with 30+ stations
associated and streaming data, and with other traffic on
nearby channels (say, channel 1 and 6)?
We see bad performance drop-off when we set number-of-peers above
100 (with CT firmware). My kernel will set AST skid limit to number-of-peers + number-of-vdevs.
Performance is best at 32 peers or less (so skid is about 40).
I am wondering if the root cause is firmware/hardware walking the full skid-length for pkts
from un-associated peers on same (or neighbouring) channels, or maybe unlucky hash distribution
in existing peers?
Thanks,
Ben
On 02/13/2015 07:36 AM, SenthilKumar Jegadeesan wrote:
> The current SKID length configuration causes firmware
> to reject peer creation for not able to allocate
> AST entries for peers. This issue is observed when
> least significant 3 bytes are used ramdomly to create
> client MAC addresses.
>
> AST table SKID length configuration is increased to
> maximum value to fix this issue.
>
> Signed-off-by: SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/hw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
> index 460771f..7f04645 100644
> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -223,7 +223,7 @@ struct ath10k_pktlog_hdr {
> #define TARGET_10X_NUM_WDS_ENTRIES 32
> #define TARGET_10X_DMA_BURST_SIZE 0
> #define TARGET_10X_MAC_AGGR_DELIM 0
> -#define TARGET_10X_AST_SKID_LIMIT 16
> +#define TARGET_10X_AST_SKID_LIMIT 128
> #define TARGET_10X_NUM_STATIONS 128
> #define TARGET_10X_NUM_PEERS ((TARGET_10X_NUM_STATIONS) + \
> (TARGET_10X_NUM_VDEVS))
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH v2] ath10k: Increase AST table SKID length limit
2015-02-18 20:23 ` Ben Greear
@ 2015-02-19 11:41 ` Salakava Jegadeesan, Senthil
-1 siblings, 0 replies; 8+ messages in thread
From: Salakava Jegadeesan, Senthil @ 2015-02-19 11:41 UTC (permalink / raw)
To: Ben Greear; +Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
This fix is specific to ath10K driver + 10.x firmware combinations. This has been tested extensively, didn't observe the mentioned issue.
Thanks,
Senthil J
-----Original Message-----
From: Ben Greear [mailto:greearb@candelatech.com]
Sent: Thursday, February 19, 2015 1:53 AM
To: Salakava Jegadeesan, Senthil
Cc: ath10k@lists.infradead.org; linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: Increase AST table SKID length limit
Have you tried testing this with 30+ stations associated and streaming data, and with other traffic on nearby channels (say, channel 1 and 6)?
We see bad performance drop-off when we set number-of-peers above
100 (with CT firmware). My kernel will set AST skid limit to number-of-peers + number-of-vdevs.
Performance is best at 32 peers or less (so skid is about 40).
I am wondering if the root cause is firmware/hardware walking the full skid-length for pkts from un-associated peers on same (or neighbouring) channels, or maybe unlucky hash distribution in existing peers?
Thanks,
Ben
On 02/13/2015 07:36 AM, SenthilKumar Jegadeesan wrote:
> The current SKID length configuration causes firmware to reject peer
> creation for not able to allocate AST entries for peers. This issue is
> observed when least significant 3 bytes are used ramdomly to create
> client MAC addresses.
>
> AST table SKID length configuration is increased to maximum value to
> fix this issue.
>
> Signed-off-by: SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/hw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/hw.h
> b/drivers/net/wireless/ath/ath10k/hw.h
> index 460771f..7f04645 100644
> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -223,7 +223,7 @@ struct ath10k_pktlog_hdr {
> #define TARGET_10X_NUM_WDS_ENTRIES 32
> #define TARGET_10X_DMA_BURST_SIZE 0
> #define TARGET_10X_MAC_AGGR_DELIM 0
> -#define TARGET_10X_AST_SKID_LIMIT 16
> +#define TARGET_10X_AST_SKID_LIMIT 128
> #define TARGET_10X_NUM_STATIONS 128
> #define TARGET_10X_NUM_PEERS ((TARGET_10X_NUM_STATIONS) + \
> (TARGET_10X_NUM_VDEVS))
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-wireless" in the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH v2] ath10k: Increase AST table SKID length limit
@ 2015-02-19 11:41 ` Salakava Jegadeesan, Senthil
0 siblings, 0 replies; 8+ messages in thread
From: Salakava Jegadeesan, Senthil @ 2015-02-19 11:41 UTC (permalink / raw)
To: Ben Greear; +Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
This fix is specific to ath10K driver + 10.x firmware combinations. This has been tested extensively, didn't observe the mentioned issue.
Thanks,
Senthil J
-----Original Message-----
From: Ben Greear [mailto:greearb@candelatech.com]
Sent: Thursday, February 19, 2015 1:53 AM
To: Salakava Jegadeesan, Senthil
Cc: ath10k@lists.infradead.org; linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] ath10k: Increase AST table SKID length limit
Have you tried testing this with 30+ stations associated and streaming data, and with other traffic on nearby channels (say, channel 1 and 6)?
We see bad performance drop-off when we set number-of-peers above
100 (with CT firmware). My kernel will set AST skid limit to number-of-peers + number-of-vdevs.
Performance is best at 32 peers or less (so skid is about 40).
I am wondering if the root cause is firmware/hardware walking the full skid-length for pkts from un-associated peers on same (or neighbouring) channels, or maybe unlucky hash distribution in existing peers?
Thanks,
Ben
On 02/13/2015 07:36 AM, SenthilKumar Jegadeesan wrote:
> The current SKID length configuration causes firmware to reject peer
> creation for not able to allocate AST entries for peers. This issue is
> observed when least significant 3 bytes are used ramdomly to create
> client MAC addresses.
>
> AST table SKID length configuration is increased to maximum value to
> fix this issue.
>
> Signed-off-by: SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/hw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/hw.h
> b/drivers/net/wireless/ath/ath10k/hw.h
> index 460771f..7f04645 100644
> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -223,7 +223,7 @@ struct ath10k_pktlog_hdr {
> #define TARGET_10X_NUM_WDS_ENTRIES 32
> #define TARGET_10X_DMA_BURST_SIZE 0
> #define TARGET_10X_MAC_AGGR_DELIM 0
> -#define TARGET_10X_AST_SKID_LIMIT 16
> +#define TARGET_10X_AST_SKID_LIMIT 128
> #define TARGET_10X_NUM_STATIONS 128
> #define TARGET_10X_NUM_PEERS ((TARGET_10X_NUM_STATIONS) + \
> (TARGET_10X_NUM_VDEVS))
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-wireless" in the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ath10k: Increase AST table SKID length limit
2015-02-13 15:36 ` SenthilKumar Jegadeesan
@ 2015-03-05 13:57 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2015-03-05 13:57 UTC (permalink / raw)
To: SenthilKumar Jegadeesan; +Cc: linux-wireless, ath10k
SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com> writes:
> The current SKID length configuration causes firmware
> to reject peer creation for not able to allocate
> AST entries for peers. This issue is observed when
> least significant 3 bytes are used ramdomly to create
> client MAC addresses.
>
> AST table SKID length configuration is increased to
> maximum value to fix this issue.
>
> Signed-off-by: SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com>
Thanks, applied.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ath10k: Increase AST table SKID length limit
@ 2015-03-05 13:57 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2015-03-05 13:57 UTC (permalink / raw)
To: SenthilKumar Jegadeesan; +Cc: ath10k, linux-wireless
SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com> writes:
> The current SKID length configuration causes firmware
> to reject peer creation for not able to allocate
> AST entries for peers. This issue is observed when
> least significant 3 bytes are used ramdomly to create
> client MAC addresses.
>
> AST table SKID length configuration is increased to
> maximum value to fix this issue.
>
> Signed-off-by: SenthilKumar Jegadeesan <sjegadee@qti.qualcomm.com>
Thanks, applied.
--
Kalle Valo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-05 13:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-13 15:36 [PATCH v2] ath10k: Increase AST table SKID length limit SenthilKumar Jegadeesan
2015-02-13 15:36 ` SenthilKumar Jegadeesan
2015-02-18 20:23 ` Ben Greear
2015-02-18 20:23 ` Ben Greear
2015-02-19 11:41 ` Salakava Jegadeesan, Senthil
2015-02-19 11:41 ` Salakava Jegadeesan, Senthil
2015-03-05 13:57 ` Kalle Valo
2015-03-05 13:57 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.