Re: [review-request] michaelw/toaster/fixes-7195-7241-7199

[Michael Wood <michael.g.wood@intel.com>]

Whoops; that teaches me for testing on a layer which doesn't have any 
machines!

-            machines_query = query.filter(
+            machines_query = machines_query.filter(

Branch is now updated. michaelw/toaster/fixes-7195-7241-7199

Thanks,

Michael


On 19/02/15 13:42, Barros Pena, Belen wrote:
> On 19/02/2015 11:18, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
>> commit 57e68b0b342c48b51f2383588351658f039f18c4
>> Author: Michael Wood <michael.g.wood@intel.com>
>> Date:   Wed Feb 18 16:02:24 2015 +0000
>>
>>      bitbake: toaster: layerdetails summary/descriptions to be searchable
>>
>>      Allow the descriptions of the machine summary and layer description
>> to
>>      be searchable in their respective tables.
>>
>>      [YOCTO #7199]
>>
>>      Signed-off-by: Michael Wood <michael.g.wood@intel.com>
> All looks good, except a problem on this one. The Description is now
> searchable in the Targets tab, but when I try to search in the Machines
> tab, I get this error
>
> Environment:
>
>
> Request Method: GET
> Request URL:
> http://127.0.0.1:8000/toastergui/layer/20/?machines_search=moto
>
> Django Version: 1.6
> Python Version: 2.7.6
> Installed Applications:
> ('django.contrib.auth',
> 'django.contrib.contenttypes',
> 'django.contrib.messages',
> 'django.contrib.sessions',
> 'django.contrib.admin',
> 'django.contrib.staticfiles',
> 'django.contrib.humanize',
> 'orm',
> 'toastermain',
> 'south',
> 'bldviewer',
> 'toastergui',
> 'bldcontrol')
> Installed Middleware:
> ('django.middleware.common.CommonMiddleware',
> 'django.contrib.sessions.middleware.SessionMiddleware',
> 'django.middleware.csrf.CsrfViewMiddleware',
> 'django.contrib.auth.middleware.AuthenticationMiddleware',
> 'django.contrib.messages.middleware.MessageMiddleware')
>
>
> Traceback:
> File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py"
> in get_response
>    114.                     response = wrapped_callback(request,
> *callback_args, **callback_kwargs)
> File "/home/yocto/poky-contrib/bitbake/lib/toaster/toastergui/views.py"
> in layerdetails
>    2633.             machines_query = query.filter(
>
> Exception Type: NameError at /toastergui/layer/20/
> Exception Value: global name 'query' is not defined
>
>