[review-request] michaelw/toaster/fixes-7195-7241-7199

[review-request] michaelw/toaster/fixes-7195-7241-7199

[Michael Wood]

poky-contrib michaelw/toaster/fixes-7195-7241-7199


commit d959fd27059302b0d159146b2032b7804d6ef9ac
Author: Michael Wood <michael.g.wood@intel.com>
Date:   Wed Feb 18 17:45:38 2015 +0000

     bitbake: toaster: layerdetails Fix pagination controls

     Bring the pagination controls into line with others in toaster by
     limiting the number of page buttons to 5

     [YOCTO #7195]

     Signed-off-by: Michael Wood <michael.g.wood@intel.com>

commit d199bd99d81d24b84fedb270f51cfa1048b84f76
Author: Michael Wood <michael.g.wood@intel.com>
Date:   Wed Feb 18 16:43:27 2015 +0000

     bitbake: toaster: layerdetails Add link to machines file

     In the machines table for a layer add a link/icon to the machine
     definition file.

     [YOCTO #7241]

     Signed-off-by: Michael Wood <michael.g.wood@intel.com>

commit 57e68b0b342c48b51f2383588351658f039f18c4
Author: Michael Wood <michael.g.wood@intel.com>
Date:   Wed Feb 18 16:02:24 2015 +0000

     bitbake: toaster: layerdetails summary/descriptions to be searchable

     Allow the descriptions of the machine summary and layer description to
     be searchable in their respective tables.

     [YOCTO #7199]

     Signed-off-by: Michael Wood <michael.g.wood@intel.com>


Thanks,

Michael

Re: [review-request] michaelw/toaster/fixes-7195-7241-7199

[Barros Pena, Belen]

On 19/02/2015 11:18, "Michael Wood" <michael.g.wood@intel.com> wrote:

>commit 57e68b0b342c48b51f2383588351658f039f18c4
>Author: Michael Wood <michael.g.wood@intel.com>
>Date:   Wed Feb 18 16:02:24 2015 +0000
>
>     bitbake: toaster: layerdetails summary/descriptions to be searchable
>
>     Allow the descriptions of the machine summary and layer description
>to
>     be searchable in their respective tables.
>
>     [YOCTO #7199]
>
>     Signed-off-by: Michael Wood <michael.g.wood@intel.com>

All looks good, except a problem on this one. The Description is now
searchable in the Targets tab, but when I try to search in the Machines
tab, I get this error

Environment:


Request Method: GET
Request URL: 
http://127.0.0.1:8000/toastergui/layer/20/?machines_search=moto

Django Version: 1.6
Python Version: 2.7.6
Installed Applications:
('django.contrib.auth',
'django.contrib.contenttypes',
'django.contrib.messages',
'django.contrib.sessions',
'django.contrib.admin',
'django.contrib.staticfiles',
'django.contrib.humanize',
'orm',
'toastermain',
'south',
'bldviewer',
'toastergui',
'bldcontrol')
Installed Middleware:
('django.middleware.common.CommonMiddleware',
'django.contrib.sessions.middleware.SessionMiddleware',
'django.middleware.csrf.CsrfViewMiddleware',
'django.contrib.auth.middleware.AuthenticationMiddleware',
'django.contrib.messages.middleware.MessageMiddleware')


Traceback:
File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py"
in get_response
  114.                     response = wrapped_callback(request,
*callback_args, **callback_kwargs)
File "/home/yocto/poky-contrib/bitbake/lib/toaster/toastergui/views.py"
in layerdetails
  2633.             machines_query = query.filter(

Exception Type: NameError at /toastergui/layer/20/
Exception Value: global name 'query' is not defined

Re: [review-request] michaelw/toaster/fixes-7195-7241-7199

[Michael Wood]

Whoops; that teaches me for testing on a layer which doesn't have any 
machines!

-            machines_query = query.filter(
+            machines_query = machines_query.filter(

Branch is now updated. michaelw/toaster/fixes-7195-7241-7199

Thanks,

Michael


On 19/02/15 13:42, Barros Pena, Belen wrote:
> On 19/02/2015 11:18, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
>> commit 57e68b0b342c48b51f2383588351658f039f18c4
>> Author: Michael Wood <michael.g.wood@intel.com>
>> Date:   Wed Feb 18 16:02:24 2015 +0000
>>
>>      bitbake: toaster: layerdetails summary/descriptions to be searchable
>>
>>      Allow the descriptions of the machine summary and layer description
>> to
>>      be searchable in their respective tables.
>>
>>      [YOCTO #7199]
>>
>>      Signed-off-by: Michael Wood <michael.g.wood@intel.com>
> All looks good, except a problem on this one. The Description is now
> searchable in the Targets tab, but when I try to search in the Machines
> tab, I get this error
>
> Environment:
>
>
> Request Method: GET
> Request URL:
> http://127.0.0.1:8000/toastergui/layer/20/?machines_search=moto
>
> Django Version: 1.6
> Python Version: 2.7.6
> Installed Applications:
> ('django.contrib.auth',
> 'django.contrib.contenttypes',
> 'django.contrib.messages',
> 'django.contrib.sessions',
> 'django.contrib.admin',
> 'django.contrib.staticfiles',
> 'django.contrib.humanize',
> 'orm',
> 'toastermain',
> 'south',
> 'bldviewer',
> 'toastergui',
> 'bldcontrol')
> Installed Middleware:
> ('django.middleware.common.CommonMiddleware',
> 'django.contrib.sessions.middleware.SessionMiddleware',
> 'django.middleware.csrf.CsrfViewMiddleware',
> 'django.contrib.auth.middleware.AuthenticationMiddleware',
> 'django.contrib.messages.middleware.MessageMiddleware')
>
>
> Traceback:
> File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py"
> in get_response
>    114.                     response = wrapped_callback(request,
> *callback_args, **callback_kwargs)
> File "/home/yocto/poky-contrib/bitbake/lib/toaster/toastergui/views.py"
> in layerdetails
>    2633.             machines_query = query.filter(
>
> Exception Type: NameError at /toastergui/layer/20/
> Exception Value: global name 'query' is not defined
>
>

Re: [review-request] michaelw/toaster/fixes-7195-7241-7199

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 2779 bytes --]

Taken for submission,

Thank you,
Alex

On Thu, Feb 19, 2015 at 1:53 PM, Michael Wood <michael.g.wood@intel.com>
wrote:

> Whoops; that teaches me for testing on a layer which doesn't have any
> machines!
>
> -            machines_query = query.filter(
> +            machines_query = machines_query.filter(
>
> Branch is now updated. michaelw/toaster/fixes-7195-7241-7199
>
> Thanks,
>
> Michael
>
>
>
> On 19/02/15 13:42, Barros Pena, Belen wrote:
>
>> On 19/02/2015 11:18, "Michael Wood" <michael.g.wood@intel.com> wrote:
>>
>>  commit 57e68b0b342c48b51f2383588351658f039f18c4
>>> Author: Michael Wood <michael.g.wood@intel.com>
>>> Date:   Wed Feb 18 16:02:24 2015 +0000
>>>
>>>      bitbake: toaster: layerdetails summary/descriptions to be searchable
>>>
>>>      Allow the descriptions of the machine summary and layer description
>>> to
>>>      be searchable in their respective tables.
>>>
>>>      [YOCTO #7199]
>>>
>>>      Signed-off-by: Michael Wood <michael.g.wood@intel.com>
>>>
>> All looks good, except a problem on this one. The Description is now
>> searchable in the Targets tab, but when I try to search in the Machines
>> tab, I get this error
>>
>> Environment:
>>
>>
>> Request Method: GET
>> Request URL:
>> http://127.0.0.1:8000/toastergui/layer/20/?machines_search=moto
>>
>> Django Version: 1.6
>> Python Version: 2.7.6
>> Installed Applications:
>> ('django.contrib.auth',
>> 'django.contrib.contenttypes',
>> 'django.contrib.messages',
>> 'django.contrib.sessions',
>> 'django.contrib.admin',
>> 'django.contrib.staticfiles',
>> 'django.contrib.humanize',
>> 'orm',
>> 'toastermain',
>> 'south',
>> 'bldviewer',
>> 'toastergui',
>> 'bldcontrol')
>> Installed Middleware:
>> ('django.middleware.common.CommonMiddleware',
>> 'django.contrib.sessions.middleware.SessionMiddleware',
>> 'django.middleware.csrf.CsrfViewMiddleware',
>> 'django.contrib.auth.middleware.AuthenticationMiddleware',
>> 'django.contrib.messages.middleware.MessageMiddleware')
>>
>>
>> Traceback:
>> File "/usr/local/lib/python2.7/dist-packages/django/core/
>> handlers/base.py"
>> in get_response
>>    114.                     response = wrapped_callback(request,
>> *callback_args, **callback_kwargs)
>> File "/home/yocto/poky-contrib/bitbake/lib/toaster/toastergui/views.py"
>> in layerdetails
>>    2633.             machines_query = query.filter(
>>
>> Exception Type: NameError at /toastergui/layer/20/
>> Exception Value: global name 'query' is not defined
>>
>>
>>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 4552 bytes --]