All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: shmobile: r8a7790: Fix HSUSB clock to hp_clk from mp_clk
Date: Thu, 19 Feb 2015 17:39:41 +0000	[thread overview]
Message-ID: <54E61FDD.3060700@cogentembedded.com> (raw)
In-Reply-To: <1424360575-6482-1-git-send-email-horms+renesas@verge.net.au>

Hello.

On 02/19/2015 06:42 PM, Simon Horman wrote:

> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

> HSUSB uses hp_clk rather than mp_clk for H/W register access.

> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> [horms: updated changelog]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

> ---
> v2 [Simon Horman]
> - Updated changelog to remove information about USB-DMAC clock which
>    did not relate to the patch. I will follow up on weather the

    s/weather/whether/.

>    USB-DMAC clock should be mp_clk as the deleted portion of the
>    changelog stated.
> ---
>   arch/arm/boot/dts/r8a7790.dtsi | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 24de994..113edf2 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1,6 +1,7 @@
>   /*
>    * Device Tree Source for the r8a7790 SoC
>    *
> + * Copyright (C) 2015 Renesas Electronics Corporation

    One-liner is hardly enough for the copyright claim. Greg KH even used to 
say that roughly a third part of a file changed was worth it, IIRC.

>    * Copyright (C) 2013-2014 Renesas Solutions Corp.
>    * Copyright (C) 2014 Cogent Embedded Inc.
>    *
> @@ -1132,7 +1133,7 @@
>   		mstp7_clks: mstp7_clks@e615014c {
>   			compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
>   			reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
> -			clocks = <&mp_clk>, <&mp_clk>, <&zs_clk>, <&zs_clk>, <&p_clk>,
> +			clocks = <&mp_clk>, <&hp_clk>, <&zs_clk>, <&zs_clk>, <&p_clk>,
>   				 <&p_clk>, <&zx_clk>, <&zx_clk>, <&zx_clk>, <&zx_clk>,
>   				 <&zx_clk>;
>   			#clock-cells = <1>;

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: shmobile: r8a7790: Fix HSUSB clock to hp_clk from mp_clk
Date: Thu, 19 Feb 2015 20:39:41 +0300	[thread overview]
Message-ID: <54E61FDD.3060700@cogentembedded.com> (raw)
In-Reply-To: <1424360575-6482-1-git-send-email-horms+renesas@verge.net.au>

Hello.

On 02/19/2015 06:42 PM, Simon Horman wrote:

> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

> HSUSB uses hp_clk rather than mp_clk for H/W register access.

> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> [horms: updated changelog]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

> ---
> v2 [Simon Horman]
> - Updated changelog to remove information about USB-DMAC clock which
>    did not relate to the patch. I will follow up on weather the

    s/weather/whether/.

>    USB-DMAC clock should be mp_clk as the deleted portion of the
>    changelog stated.
> ---
>   arch/arm/boot/dts/r8a7790.dtsi | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 24de994..113edf2 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1,6 +1,7 @@
>   /*
>    * Device Tree Source for the r8a7790 SoC
>    *
> + * Copyright (C) 2015 Renesas Electronics Corporation

    One-liner is hardly enough for the copyright claim. Greg KH even used to 
say that roughly a third part of a file changed was worth it, IIRC.

>    * Copyright (C) 2013-2014 Renesas Solutions Corp.
>    * Copyright (C) 2014 Cogent Embedded Inc.
>    *
> @@ -1132,7 +1133,7 @@
>   		mstp7_clks: mstp7_clks at e615014c {
>   			compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
>   			reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
> -			clocks = <&mp_clk>, <&mp_clk>, <&zs_clk>, <&zs_clk>, <&p_clk>,
> +			clocks = <&mp_clk>, <&hp_clk>, <&zs_clk>, <&zs_clk>, <&p_clk>,
>   				 <&p_clk>, <&zx_clk>, <&zx_clk>, <&zx_clk>, <&zx_clk>,
>   				 <&zx_clk>;
>   			#clock-cells = <1>;

WBR, Sergei

  reply	other threads:[~2015-02-19 17:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 15:42 [PATCH v2] ARM: shmobile: r8a7790: Fix HSUSB clock to hp_clk from mp_clk Simon Horman
2015-02-19 15:42 ` Simon Horman
2015-02-19 17:39 ` Sergei Shtylyov [this message]
2015-02-19 17:39   ` Sergei Shtylyov
2015-02-19 17:58   ` Simon Horman
2015-02-19 17:58     ` Simon Horman
2015-02-25 23:31 ` Simon Horman
2015-02-25 23:31   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E61FDD.3060700@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.