From: Archit Taneja <architt@codeaurora.org>
To: Stanimir Varbanov <svarbanov@mm-sol.com>,
Vinod Koul <vinod.koul@intel.com>
Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@codeaurora.org>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets
Date: Fri, 20 Feb 2015 14:06:26 +0530 [thread overview]
Message-ID: <54E6F20A.60005@codeaurora.org> (raw)
In-Reply-To: <1424364350-32239-1-git-send-email-svarbanov@mm-sol.com>
On 02/19/2015 10:15 PM, Stanimir Varbanov wrote:
> The commit fb93f520e (dmaengine: qcom_bam_dma: Generalize BAM
> register offset calculations) wrongly populated base offsets
> for event registers for bam v1.4.
>
> Signed-off-by: Stanimir Varbanov <svarbanov@mm-sol.com>
> ---
> drivers/dma/qcom_bam_dma.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c
> index debe106..95b7668 100644
> --- a/drivers/dma/qcom_bam_dma.c
> +++ b/drivers/dma/qcom_bam_dma.c
> @@ -162,9 +162,9 @@ static const struct reg_offset_data bam_v1_4_reg_info[] = {
> [BAM_P_IRQ_STTS] = { 0x1010, 0x1000, 0x00, 0x00 },
> [BAM_P_IRQ_CLR] = { 0x1014, 0x1000, 0x00, 0x00 },
> [BAM_P_IRQ_EN] = { 0x1018, 0x1000, 0x00, 0x00 },
> - [BAM_P_EVNT_DEST_ADDR] = { 0x102C, 0x00, 0x1000, 0x00 },
> - [BAM_P_EVNT_REG] = { 0x1018, 0x00, 0x1000, 0x00 },
> - [BAM_P_SW_OFSTS] = { 0x1000, 0x00, 0x1000, 0x00 },
> + [BAM_P_EVNT_DEST_ADDR] = { 0x182C, 0x00, 0x1000, 0x00 },
> + [BAM_P_EVNT_REG] = { 0x1818, 0x00, 0x1000, 0x00 },
> + [BAM_P_SW_OFSTS] = { 0x1800, 0x00, 0x1000, 0x00 },
> [BAM_P_DATA_FIFO_ADDR] = { 0x1824, 0x00, 0x1000, 0x00 },
> [BAM_P_DESC_FIFO_ADDR] = { 0x181C, 0x00, 0x1000, 0x00 },
> [BAM_P_EVNT_GEN_TRSHLD] = { 0x1828, 0x00, 0x1000, 0x00 },
>
Didn't know how this crept in. Apologies for the inconvenience!
Reviewed-by: Archit Taneja <architt@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-02-20 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 16:45 [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets Stanimir Varbanov
2015-02-20 8:36 ` Archit Taneja [this message]
2015-02-20 22:33 ` Andy Gross
2015-03-05 16:37 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E6F20A.60005@codeaurora.org \
--to=architt@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=svarbanov@mm-sol.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.