From: Michal Marek <mmarek@suse.cz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Antti Palosaari <crope@iki.fi>,
Peter Senna Tschudin <peter.senna@gmail.com>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Trent Piepho <xyzzy@speakeasy.org>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] [media] [kbuild] Add and use IS_REACHABLE macro
Date: Fri, 20 Feb 2015 11:24:18 +0100 [thread overview]
Message-ID: <54E70B52.9040708@suse.cz> (raw)
In-Reply-To: <5822078.VORY4BTfEj@wuerfel>
On 2015-02-20 10:29, Arnd Bergmann wrote:
> On Thursday 19 February 2015 16:06:18 Michal Marek wrote:
>>> We have similar problems in other areas
>>> of the kernel. In theory, we could enforce the VIDEO_TUNER driver to
>>> be modular here by adding lots of dependencies to it:
>>>
>>> config VIDEO_TUNER
>>> tristate
>>> depends on MEDIA_TUNER_TEA5761 || !MEDIA_TUNER_TEA5761
>>> depends on MEDIA_TUNER_TEA5767 || !MEDIA_TUNER_TEA5767
>>> depends on MEDIA_TUNER_MSI001 || !MEDIA_TUNER_MSI001
>>
>> Nah, that's even uglier. I suggest to merge your IS_REACHABLE patch.
>>
>
> Ok, can I take this as an ack from your side to merge the
> include/linux/kconfig.h part of the patch through the linux-media
> tree?
Yes. If you want
Acked-by: Michal Marek <mmarek@suse.cz> [kconfig]
> I thought about splitting up the patch into two, but that would
> just make merging it harder because we'd still have the dependency.
Agreed, no need to pedantically split patches just for the sake of it.
Michal
WARNING: multiple messages have this Message-ID (diff)
From: mmarek@suse.cz (Michal Marek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [media] [kbuild] Add and use IS_REACHABLE macro
Date: Fri, 20 Feb 2015 11:24:18 +0100 [thread overview]
Message-ID: <54E70B52.9040708@suse.cz> (raw)
In-Reply-To: <5822078.VORY4BTfEj@wuerfel>
On 2015-02-20 10:29, Arnd Bergmann wrote:
> On Thursday 19 February 2015 16:06:18 Michal Marek wrote:
>>> We have similar problems in other areas
>>> of the kernel. In theory, we could enforce the VIDEO_TUNER driver to
>>> be modular here by adding lots of dependencies to it:
>>>
>>> config VIDEO_TUNER
>>> tristate
>>> depends on MEDIA_TUNER_TEA5761 || !MEDIA_TUNER_TEA5761
>>> depends on MEDIA_TUNER_TEA5767 || !MEDIA_TUNER_TEA5767
>>> depends on MEDIA_TUNER_MSI001 || !MEDIA_TUNER_MSI001
>>
>> Nah, that's even uglier. I suggest to merge your IS_REACHABLE patch.
>>
>
> Ok, can I take this as an ack from your side to merge the
> include/linux/kconfig.h part of the patch through the linux-media
> tree?
Yes. If you want
Acked-by: Michal Marek <mmarek@suse.cz> [kconfig]
> I thought about splitting up the patch into two, but that would
> just make merging it harder because we'd still have the dependency.
Agreed, no need to pedantically split patches just for the sake of it.
Michal
next prev parent reply other threads:[~2015-02-20 10:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 17:12 [PATCH] [media] [kbuild] Add and use IS_REACHABLE macro Arnd Bergmann
2015-02-18 17:12 ` Arnd Bergmann
2015-02-18 17:12 ` Arnd Bergmann
2015-02-19 12:11 ` Michal Marek
2015-02-19 12:11 ` Michal Marek
2015-02-19 14:53 ` Arnd Bergmann
2015-02-19 14:53 ` Arnd Bergmann
2015-02-19 15:06 ` Michal Marek
2015-02-19 15:06 ` Michal Marek
2015-02-20 9:29 ` Arnd Bergmann
2015-02-20 9:29 ` Arnd Bergmann
2015-02-20 9:37 ` Mauro Carvalho Chehab
2015-02-20 9:37 ` Mauro Carvalho Chehab
2015-02-20 10:24 ` Michal Marek [this message]
2015-02-20 10:24 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E70B52.9040708@suse.cz \
--to=mmarek@suse.cz \
--cc=arnd@arndb.de \
--cc=crope@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=peter.senna@gmail.com \
--cc=xyzzy@speakeasy.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.