* [PATCH v4] Staging: media: vino: Replace printk() and dprintk() with dev_dbg()
@ 2015-02-19 18:04 Ksenija Stanojevic
2015-02-19 18:11 ` Ksenija Stanojevic
2015-02-20 9:15 ` [Outreachy kernel] " Arnd Bergmann
0 siblings, 2 replies; 7+ messages in thread
From: Ksenija Stanojevic @ 2015-02-19 18:04 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Ksenija Stanojevic
Making variants of existing macros is against kernel coding style.
This patch removes all definitions made by macro dprintk() and replaces
them with dev dbg().
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
v4: Merged all commits into one.
v3: Added a pointer to a device structure in dev_dbg() as the
first argument.
v2: Removed KERN_ERR and KERN_INFO from dev_dbg() argument list.
drivers/staging/media/vino/saa7191.c | 58 ++++++++++++++++--------------------
1 file changed, 26 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/media/vino/saa7191.c b/drivers/staging/media/vino/saa7191.c
index 8e96992..29e3296 100644
--- a/drivers/staging/media/vino/saa7191.c
+++ b/drivers/staging/media/vino/saa7191.c
@@ -33,13 +33,7 @@ MODULE_AUTHOR("Mikael Nousiainen <tmnousia@cc.hut.fi>");
MODULE_LICENSE("GPL");
-// #define SAA7191_DEBUG
-#ifdef SAA7191_DEBUG
-#define dprintk(x...) printk("SAA7191: " x);
-#else
-#define dprintk(x...)
-#endif
#define SAA7191_SYNC_COUNT 30
#define SAA7191_SYNC_DELAY 100 /* milliseconds */
@@ -116,7 +110,7 @@ static int saa7191_read_status(struct v4l2_subdev *sd, u8 *value)
ret = i2c_master_recv(client, value, 1);
if (ret < 0) {
- printk(KERN_ERR "SAA7191: saa7191_read_status(): read failed\n");
+ dev_dbg(sd->dev, "saa7191_read_status(): read failed\n");
return ret;
}
@@ -147,7 +141,7 @@ static int saa7191_write_block(struct v4l2_subdev *sd,
ret = i2c_master_send(client, data, length);
if (ret < 0) {
- printk(KERN_ERR "SAA7191: saa7191_write_block(): "
+ dev_dbg(sd->dev, "saa7191_write_block(): "
"write failed\n");
return ret;
}
@@ -230,9 +224,9 @@ static int saa7191_s_std(struct v4l2_subdev *sd, v4l2_std_id norm)
decoder->norm = norm;
- dprintk("ctl3: %02x stdc: %02x chcv: %02x\n", ctl3,
+ dev_dbg(sd->dev, "ctl3: %02x stdc: %02x chcv: %02x\n", ctl3,
stdc, chcv);
- dprintk("norm: %llx\n", norm);
+ dev_dbg(sd->dev, "norm: %llx\n", norm);
return 0;
}
@@ -241,21 +235,21 @@ static int saa7191_wait_for_signal(struct v4l2_subdev *sd, u8 *status)
{
int i = 0;
- dprintk("Checking for signal...\n");
+ dev_dbg(sd->dev, "Checking for signal...\n");
for (i = 0; i < SAA7191_SYNC_COUNT; i++) {
if (saa7191_read_status(sd, status))
return -EIO;
if (((*status) & SAA7191_STATUS_HLCK) == 0) {
- dprintk("Signal found\n");
+ dev_dbg(sd->dev, "Signal found\n");
return 0;
}
msleep(SAA7191_SYNC_DELAY);
}
- dprintk("No signal\n");
+ dev_dbg(sd->dev, "No signal\n");
return -EBUSY;
}
@@ -269,7 +263,7 @@ static int saa7191_querystd(struct v4l2_subdev *sd, v4l2_std_id *norm)
v4l2_std_id old_norm = decoder->norm;
int err = 0;
- dprintk("SAA7191 extended signal auto-detection...\n");
+ dev_dbg(sd->dev, "SAA7191 extended signal auto-detection...\n");
*norm &= V4L2_STD_NTSC | V4L2_STD_PAL | V4L2_STD_SECAM;
stdc &= ~SAA7191_STDC_SECS;
@@ -301,13 +295,13 @@ static int saa7191_querystd(struct v4l2_subdev *sd, v4l2_std_id *norm)
if (status & SAA7191_STATUS_FIDT) {
/* 60Hz signal -> NTSC */
- dprintk("60Hz signal: NTSC\n");
+ dev_dbg(sd->dev, "60Hz signal: NTSC\n");
*norm &= V4L2_STD_NTSC;
return 0;
}
/* 50Hz signal */
- dprintk("50Hz signal: Trying PAL...\n");
+ dev_dbg(sd->dev, "50Hz signal: Trying PAL...\n");
/* try PAL first */
err = saa7191_s_std(sd, V4L2_STD_PAL);
@@ -322,19 +316,19 @@ static int saa7191_querystd(struct v4l2_subdev *sd, v4l2_std_id *norm)
/* not 50Hz ? */
if (status & SAA7191_STATUS_FIDT) {
- dprintk("No 50Hz signal\n");
+ dev_dbg(sd->dev, "No 50Hz signal\n");
saa7191_s_std(sd, old_norm);
*norm = V4L2_STD_UNKNOWN;
return 0;
}
if (status & SAA7191_STATUS_CODE) {
- dprintk("PAL\n");
+ dev_dbg(sd->dev, "PAL\n");
*norm &= V4L2_STD_PAL;
return saa7191_s_std(sd, old_norm);
}
- dprintk("No color detected with PAL - Trying SECAM...\n");
+ dev_dbg(sd->dev, "No color detected with PAL - Trying SECAM...\n");
/* no color detected ? -> try SECAM */
err = saa7191_s_std(sd, V4L2_STD_SECAM);
@@ -349,19 +343,19 @@ static int saa7191_querystd(struct v4l2_subdev *sd, v4l2_std_id *norm)
/* not 50Hz ? */
if (status & SAA7191_STATUS_FIDT) {
- dprintk("No 50Hz signal\n");
+ dev_dbg(sd->dev, "No 50Hz signal\n");
*norm = V4L2_STD_UNKNOWN;
goto out;
}
if (status & SAA7191_STATUS_CODE) {
/* Color detected -> SECAM */
- dprintk("SECAM\n");
+ dev_dbg(sd->dev, "SECAM\n");
*norm &= V4L2_STD_SECAM;
return saa7191_s_std(sd, old_norm);
}
- dprintk("No color detected with SECAM - Going back to PAL.\n");
+ dev_dbg(sd->dev, "No color detected with SECAM - Going back to PAL.\n");
*norm = V4L2_STD_UNKNOWN;
out:
@@ -372,30 +366,30 @@ static int saa7191_autodetect_norm(struct v4l2_subdev *sd)
{
u8 status;
- dprintk("SAA7191 signal auto-detection...\n");
+ dev_dbg(sd->dev, "SAA7191 signal auto-detection...\n");
- dprintk("Reading status...\n");
+ dev_dbg(sd->dev, "Reading status...\n");
if (saa7191_read_status(sd, &status))
return -EIO;
- dprintk("Checking for signal...\n");
+ dev_dbg(sd->dev, "Checking for signal...\n");
/* no signal ? */
if (status & SAA7191_STATUS_HLCK) {
- dprintk("No signal\n");
+ dev_dbg(sd->dev, "No signal\n");
return -EBUSY;
}
- dprintk("Signal found\n");
+ dev_dbg(sd->dev, "Signal found\n");
if (status & SAA7191_STATUS_FIDT) {
/* 60hz signal -> NTSC */
- dprintk("NTSC\n");
+ dev_dbg(sd->dev, "NTSC\n");
return saa7191_s_std(sd, V4L2_STD_NTSC);
} else {
/* 50hz signal -> PAL */
- dprintk("PAL\n");
+ dev_dbg(sd->dev, "PAL\n");
return saa7191_s_std(sd, V4L2_STD_PAL);
}
}
@@ -606,18 +600,18 @@ static int saa7191_probe(struct i2c_client *client,
err = saa7191_write_block(sd, sizeof(initseq), initseq);
if (err) {
- printk(KERN_ERR "SAA7191 initialization failed\n");
+ dev_dbg(sd->dev, "SAA7191 initialization failed\n");
return err;
}
- printk(KERN_INFO "SAA7191 initialized\n");
+ dev_dbg(sd->dev, "SAA7191 initialized\n");
decoder->input = SAA7191_INPUT_COMPOSITE;
decoder->norm = V4L2_STD_PAL;
err = saa7191_autodetect_norm(sd);
if (err && (err != -EBUSY))
- printk(KERN_ERR "SAA7191: Signal auto-detection failed\n");
+ dev_dbg(sd->dev, "SAA7191: Signal auto-detection failed\n");
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v4] Staging: media: vino: Replace printk() and dprintk() with dev_dbg()
2015-02-19 18:04 [PATCH v4] Staging: media: vino: Replace printk() and dprintk() with dev_dbg() Ksenija Stanojevic
@ 2015-02-19 18:11 ` Ksenija Stanojevic
2015-02-20 9:15 ` [Outreachy kernel] " Arnd Bergmann
1 sibling, 0 replies; 7+ messages in thread
From: Ksenija Stanojevic @ 2015-02-19 18:11 UTC (permalink / raw)
To: outreachy-kernel; +Cc: ksenija.stanojevic
[-- Attachment #1.1: Type: text/plain, Size: 8588 bytes --]
i just fixed my mail but I don't know how did I post it here instead into
separate topic.
On Thursday, February 19, 2015 at 7:04:41 PM UTC+1, Ksenija Stanojevic
wrote:
>
> Making variants of existing macros is against kernel coding style.
> This patch removes all definitions made by macro dprintk() and replaces
> them with dev dbg().
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> v4: Merged all commits into one.
> v3: Added a pointer to a device structure in dev_dbg() as the
> first argument.
> v2: Removed KERN_ERR and KERN_INFO from dev_dbg() argument list.
>
> drivers/staging/media/vino/saa7191.c | 58
> ++++++++++++++++--------------------
> 1 file changed, 26 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/staging/media/vino/saa7191.c
> b/drivers/staging/media/vino/saa7191.c
> index 8e96992..29e3296 100644
> --- a/drivers/staging/media/vino/saa7191.c
> +++ b/drivers/staging/media/vino/saa7191.c
> @@ -33,13 +33,7 @@ MODULE_AUTHOR("Mikael Nousiainen <tmnousia@cc.hut.fi>");
>
> MODULE_LICENSE("GPL");
>
>
> -// #define SAA7191_DEBUG
>
> -#ifdef SAA7191_DEBUG
> -#define dprintk(x...) printk("SAA7191: " x);
> -#else
> -#define dprintk(x...)
> -#endif
>
> #define SAA7191_SYNC_COUNT 30
> #define SAA7191_SYNC_DELAY 100 /* milliseconds */
> @@ -116,7 +110,7 @@ static int saa7191_read_status(struct v4l2_subdev *sd,
> u8 *value)
>
> ret = i2c_master_recv(client, value, 1);
> if (ret < 0) {
> - printk(KERN_ERR "SAA7191: saa7191_read_status(): read
> failed\n");
> + dev_dbg(sd->dev, "saa7191_read_status(): read failed\n");
> return ret;
> }
>
> @@ -147,7 +141,7 @@ static int saa7191_write_block(struct v4l2_subdev *sd,
>
> ret = i2c_master_send(client, data, length);
> if (ret < 0) {
> - printk(KERN_ERR "SAA7191: saa7191_write_block(): "
> + dev_dbg(sd->dev, "saa7191_write_block(): "
> "write failed\n");
> return ret;
> }
> @@ -230,9 +224,9 @@ static int saa7191_s_std(struct v4l2_subdev *sd,
> v4l2_std_id norm)
>
> decoder->norm = norm;
>
> - dprintk("ctl3: %02x stdc: %02x chcv: %02x\n", ctl3,
> + dev_dbg(sd->dev, "ctl3: %02x stdc: %02x chcv: %02x\n", ctl3,
> stdc, chcv);
> - dprintk("norm: %llx\n", norm);
> + dev_dbg(sd->dev, "norm: %llx\n", norm);
>
> return 0;
> }
> @@ -241,21 +235,21 @@ static int saa7191_wait_for_signal(struct
> v4l2_subdev *sd, u8 *status)
> {
> int i = 0;
>
> - dprintk("Checking for signal...\n");
> + dev_dbg(sd->dev, "Checking for signal...\n");
>
> for (i = 0; i < SAA7191_SYNC_COUNT; i++) {
> if (saa7191_read_status(sd, status))
> return -EIO;
>
> if (((*status) & SAA7191_STATUS_HLCK) == 0) {
> - dprintk("Signal found\n");
> + dev_dbg(sd->dev, "Signal found\n");
> return 0;
> }
>
> msleep(SAA7191_SYNC_DELAY);
> }
>
> - dprintk("No signal\n");
> + dev_dbg(sd->dev, "No signal\n");
>
> return -EBUSY;
> }
> @@ -269,7 +263,7 @@ static int saa7191_querystd(struct v4l2_subdev *sd,
> v4l2_std_id *norm)
> v4l2_std_id old_norm = decoder->norm;
> int err = 0;
>
> - dprintk("SAA7191 extended signal auto-detection...\n");
> + dev_dbg(sd->dev, "SAA7191 extended signal auto-detection...\n");
>
> *norm &= V4L2_STD_NTSC | V4L2_STD_PAL | V4L2_STD_SECAM;
> stdc &= ~SAA7191_STDC_SECS;
> @@ -301,13 +295,13 @@ static int saa7191_querystd(struct v4l2_subdev *sd,
> v4l2_std_id *norm)
>
> if (status & SAA7191_STATUS_FIDT) {
> /* 60Hz signal -> NTSC */
> - dprintk("60Hz signal: NTSC\n");
> + dev_dbg(sd->dev, "60Hz signal: NTSC\n");
> *norm &= V4L2_STD_NTSC;
> return 0;
> }
>
> /* 50Hz signal */
> - dprintk("50Hz signal: Trying PAL...\n");
> + dev_dbg(sd->dev, "50Hz signal: Trying PAL...\n");
>
> /* try PAL first */
> err = saa7191_s_std(sd, V4L2_STD_PAL);
> @@ -322,19 +316,19 @@ static int saa7191_querystd(struct v4l2_subdev *sd,
> v4l2_std_id *norm)
>
> /* not 50Hz ? */
> if (status & SAA7191_STATUS_FIDT) {
> - dprintk("No 50Hz signal\n");
> + dev_dbg(sd->dev, "No 50Hz signal\n");
> saa7191_s_std(sd, old_norm);
> *norm = V4L2_STD_UNKNOWN;
> return 0;
> }
>
> if (status & SAA7191_STATUS_CODE) {
> - dprintk("PAL\n");
> + dev_dbg(sd->dev, "PAL\n");
> *norm &= V4L2_STD_PAL;
> return saa7191_s_std(sd, old_norm);
> }
>
> - dprintk("No color detected with PAL - Trying SECAM...\n");
> + dev_dbg(sd->dev, "No color detected with PAL - Trying
> SECAM...\n");
>
> /* no color detected ? -> try SECAM */
> err = saa7191_s_std(sd, V4L2_STD_SECAM);
> @@ -349,19 +343,19 @@ static int saa7191_querystd(struct v4l2_subdev *sd,
> v4l2_std_id *norm)
>
> /* not 50Hz ? */
> if (status & SAA7191_STATUS_FIDT) {
> - dprintk("No 50Hz signal\n");
> + dev_dbg(sd->dev, "No 50Hz signal\n");
> *norm = V4L2_STD_UNKNOWN;
> goto out;
> }
>
> if (status & SAA7191_STATUS_CODE) {
> /* Color detected -> SECAM */
> - dprintk("SECAM\n");
> + dev_dbg(sd->dev, "SECAM\n");
> *norm &= V4L2_STD_SECAM;
> return saa7191_s_std(sd, old_norm);
> }
>
> - dprintk("No color detected with SECAM - Going back to PAL.\n");
> + dev_dbg(sd->dev, "No color detected with SECAM - Going back to
> PAL.\n");
> *norm = V4L2_STD_UNKNOWN;
>
> out:
> @@ -372,30 +366,30 @@ static int saa7191_autodetect_norm(struct
> v4l2_subdev *sd)
> {
> u8 status;
>
> - dprintk("SAA7191 signal auto-detection...\n");
> + dev_dbg(sd->dev, "SAA7191 signal auto-detection...\n");
>
> - dprintk("Reading status...\n");
> + dev_dbg(sd->dev, "Reading status...\n");
>
> if (saa7191_read_status(sd, &status))
> return -EIO;
>
> - dprintk("Checking for signal...\n");
> + dev_dbg(sd->dev, "Checking for signal...\n");
>
> /* no signal ? */
> if (status & SAA7191_STATUS_HLCK) {
> - dprintk("No signal\n");
> + dev_dbg(sd->dev, "No signal\n");
> return -EBUSY;
> }
>
> - dprintk("Signal found\n");
> + dev_dbg(sd->dev, "Signal found\n");
>
> if (status & SAA7191_STATUS_FIDT) {
> /* 60hz signal -> NTSC */
> - dprintk("NTSC\n");
> + dev_dbg(sd->dev, "NTSC\n");
> return saa7191_s_std(sd, V4L2_STD_NTSC);
> } else {
> /* 50hz signal -> PAL */
> - dprintk("PAL\n");
> + dev_dbg(sd->dev, "PAL\n");
> return saa7191_s_std(sd, V4L2_STD_PAL);
> }
> }
> @@ -606,18 +600,18 @@ static int saa7191_probe(struct i2c_client *client,
>
> err = saa7191_write_block(sd, sizeof(initseq), initseq);
> if (err) {
> - printk(KERN_ERR "SAA7191 initialization failed\n");
> + dev_dbg(sd->dev, "SAA7191 initialization failed\n");
> return err;
> }
>
> - printk(KERN_INFO "SAA7191 initialized\n");
> + dev_dbg(sd->dev, "SAA7191 initialized\n");
>
> decoder->input = SAA7191_INPUT_COMPOSITE;
> decoder->norm = V4L2_STD_PAL;
>
> err = saa7191_autodetect_norm(sd);
> if (err && (err != -EBUSY))
> - printk(KERN_ERR "SAA7191: Signal auto-detection
> failed\n");
> + dev_dbg(sd->dev, "SAA7191: Signal auto-detection
> failed\n");
>
> return 0;
> }
> --
> 1.9.1
>
>
[-- Attachment #1.2: Type: text/html, Size: 17888 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Outreachy kernel] [PATCH v4] Staging: media: vino: Replace printk() and dprintk() with dev_dbg()
2015-02-19 18:04 [PATCH v4] Staging: media: vino: Replace printk() and dprintk() with dev_dbg() Ksenija Stanojevic
2015-02-19 18:11 ` Ksenija Stanojevic
@ 2015-02-20 9:15 ` Arnd Bergmann
2015-02-20 9:21 ` Ksenija Stanojević
1 sibling, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2015-02-20 9:15 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Ksenija Stanojevic
On Thursday 19 February 2015 19:04:28 Ksenija Stanojevic wrote:
>
> #define SAA7191_SYNC_COUNT 30
> #define SAA7191_SYNC_DELAY 100 /* milliseconds */
> @@ -116,7 +110,7 @@ static int saa7191_read_status(struct v4l2_subdev *sd, u8 *value)
>
> ret = i2c_master_recv(client, value, 1);
> if (ret < 0) {
> - printk(KERN_ERR "SAA7191: saa7191_read_status(): read failed\n");
> + dev_dbg(sd->dev, "saa7191_read_status(): read failed\n");
> return ret;
> }
>
Please make sure you use the correct printk level here: This was KERN_ERR,
so it should be converted to dev_err(), not dev_dbg().
> @@ -606,18 +600,18 @@ static int saa7191_probe(struct i2c_client *client,
>
> err = saa7191_write_block(sd, sizeof(initseq), initseq);
> if (err) {
> - printk(KERN_ERR "SAA7191 initialization failed\n");
> + dev_dbg(sd->dev, "SAA7191 initialization failed\n");
> return err;
> }
Same here and another one further down.
> - printk(KERN_INFO "SAA7191 initialized\n");
> + dev_dbg(sd->dev, "SAA7191 initialized\n");
>
> decoder->input = SAA7191_INPUT_COMPOSITE;
> decoder->norm = V4L2_STD_PAL;
>
This one should be dev_info.
The rest looks good.
One more thing: I could not find this driver in linux-next, which tree
did you base this patch on?
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Outreachy kernel] [PATCH v4] Staging: media: vino: Replace printk() and dprintk() with dev_dbg()
2015-02-20 9:15 ` [Outreachy kernel] " Arnd Bergmann
@ 2015-02-20 9:21 ` Ksenija Stanojević
2015-02-20 9:34 ` Arnd Bergmann
0 siblings, 1 reply; 7+ messages in thread
From: Ksenija Stanojević @ 2015-02-20 9:21 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]
I based it on staging-next, like in a tutorial
On Fri, Feb 20, 2015 at 10:15 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 19 February 2015 19:04:28 Ksenija Stanojevic wrote:
> >
> > #define SAA7191_SYNC_COUNT 30
> > #define SAA7191_SYNC_DELAY 100 /* milliseconds */
> > @@ -116,7 +110,7 @@ static int saa7191_read_status(struct v4l2_subdev
> *sd, u8 *value)
> >
> > ret = i2c_master_recv(client, value, 1);
> > if (ret < 0) {
> > - printk(KERN_ERR "SAA7191: saa7191_read_status(): read
> failed\n");
> > + dev_dbg(sd->dev, "saa7191_read_status(): read failed\n");
> > return ret;
> > }
> >
>
> Please make sure you use the correct printk level here: This was KERN_ERR,
> so it should be converted to dev_err(), not dev_dbg().
>
> > @@ -606,18 +600,18 @@ static int saa7191_probe(struct i2c_client *client,
> >
> > err = saa7191_write_block(sd, sizeof(initseq), initseq);
> > if (err) {
> > - printk(KERN_ERR "SAA7191 initialization failed\n");
> > + dev_dbg(sd->dev, "SAA7191 initialization failed\n");
> > return err;
> > }
>
> Same here and another one further down.
>
> > - printk(KERN_INFO "SAA7191 initialized\n");
> > + dev_dbg(sd->dev, "SAA7191 initialized\n");
> >
> > decoder->input = SAA7191_INPUT_COMPOSITE;
> > decoder->norm = V4L2_STD_PAL;
> >
>
> This one should be dev_info.
>
> The rest looks good.
>
> One more thing: I could not find this driver in linux-next, which tree
> did you base this patch on?
>
> Arnd
>
[-- Attachment #2: Type: text/html, Size: 2386 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Outreachy kernel] [PATCH v4] Staging: media: vino: Replace printk() and dprintk() with dev_dbg()
2015-02-20 9:21 ` Ksenija Stanojević
@ 2015-02-20 9:34 ` Arnd Bergmann
2015-02-20 9:39 ` Ksenija Stanojevic
0 siblings, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2015-02-20 9:34 UTC (permalink / raw)
To: Ksenija Stanojević; +Cc: outreachy-kernel, gregkh
On Friday 20 February 2015 10:21:48 Ksenija Stanojević wrote:
> I based it on staging-next, like in a tutorial
Ok, I've investigated a bit further now and found that four
staging drivers have been removed in mainline that are still
present in staging-next:
drivers/staging/line6/ (moved to sound/usb)
drivers/staging/media/parport/
drivers/staging/media/tlg2300/
drivers/staging/media/vino/
Any patches against these could in theory still make it into
Greg's tree but they would be completely pointless because they
get removed with the next mainline synchronization.
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v4] Staging: media: vino: Replace printk() and dprintk() with dev_dbg()
2015-02-20 9:34 ` Arnd Bergmann
@ 2015-02-20 9:39 ` Ksenija Stanojevic
2015-02-20 11:01 ` Preeti U Murthy
0 siblings, 1 reply; 7+ messages in thread
From: Ksenija Stanojevic @ 2015-02-20 9:39 UTC (permalink / raw)
To: outreachy-kernel; +Cc: ksenija.stanojevic, gregkh
[-- Attachment #1.1: Type: text/plain, Size: 773 bytes --]
Hm, so I should not send this patch at all?
On Friday, February 20, 2015 at 10:34:55 AM UTC+1, Arnd Bergmann wrote:
>
> On Friday 20 February 2015 10:21:48 Ksenija Stanojević wrote:
> > I based it on staging-next, like in a tutorial
>
> Ok, I've investigated a bit further now and found that four
> staging drivers have been removed in mainline that are still
> present in staging-next:
>
> drivers/staging/line6/ (moved to sound/usb)
> drivers/staging/media/parport/
> drivers/staging/media/tlg2300/
> drivers/staging/media/vino/
>
> Any patches against these could in theory still make it into
> Greg's tree but they would be completely pointless because they
> get removed with the next mainline synchronization.
>
> Arnd
>
[-- Attachment #1.2: Type: text/html, Size: 992 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [PATCH v4] Staging: media: vino: Replace printk() and dprintk() with dev_dbg()
2015-02-20 9:39 ` Ksenija Stanojevic
@ 2015-02-20 11:01 ` Preeti U Murthy
0 siblings, 0 replies; 7+ messages in thread
From: Preeti U Murthy @ 2015-02-20 11:01 UTC (permalink / raw)
To: Ksenija Stanojevic, outreachy-kernel; +Cc: gregkh
Hi Ksenija
On 02/20/2015 03:09 PM, Ksenija Stanojevic wrote:
> Hm, so I should not send this patch at all?
Yes, please avoid it as it will not make it to mainline.
Regards
Preeti U Murthy
>
> On Friday, February 20, 2015 at 10:34:55 AM UTC+1, Arnd Bergmann wrote:
>
> On Friday 20 February 2015 10:21:48 Ksenija Stanojević wrote:
> > I based it on staging-next, like in a tutorial
>
> Ok, I've investigated a bit further now and found that four
> staging drivers have been removed in mainline that are still
> present in staging-next:
>
> drivers/staging/line6/ (moved to sound/usb)
> drivers/staging/media/parport/
> drivers/staging/media/tlg2300/
> drivers/staging/media/vino/
>
> Any patches against these could in theory still make it into
> Greg's tree but they would be completely pointless because they
> get removed with the next mainline synchronization.
>
> Arnd
>
> --
> You received this message because you are subscribed to the Google
> Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to outreachy-kernel+unsubscribe@googlegroups.com
> <mailto:outreachy-kernel+unsubscribe@googlegroups.com>.
> To post to this group, send email to outreachy-kernel@googlegroups.com
> <mailto:outreachy-kernel@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/96fe9c8a-4cb6-4058-a4be-3740e3e3cf58%40googlegroups.com
> <https://groups.google.com/d/msgid/outreachy-kernel/96fe9c8a-4cb6-4058-a4be-3740e3e3cf58%40googlegroups.com?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-02-20 11:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-19 18:04 [PATCH v4] Staging: media: vino: Replace printk() and dprintk() with dev_dbg() Ksenija Stanojevic
2015-02-19 18:11 ` Ksenija Stanojevic
2015-02-20 9:15 ` [Outreachy kernel] " Arnd Bergmann
2015-02-20 9:21 ` Ksenija Stanojević
2015-02-20 9:34 ` Arnd Bergmann
2015-02-20 9:39 ` Ksenija Stanojevic
2015-02-20 11:01 ` Preeti U Murthy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.