All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Vijay Kilari <vijay.kilari@gmail.com>
Subject: Re: [RFC] [PATCH 3/3] XEN ARM PCI support
Date: Fri, 20 Feb 2015 12:12:54 +0000	[thread overview]
Message-ID: <54E724C6.1020000@linaro.org> (raw)
In-Reply-To: <54E722ED.50807@caviumnetworks.com>

On 20/02/15 12:05, Manish Jaggi wrote:
> On 20/02/15 5:23 pm, Jan Beulich wrote:
>> All of these #ifdef-s call for better abstraction. And in no case is it
>> acceptable to replace blank lines with #ifdef-s like you do.
> Good observation. I will take care for the blank lines.
> A lot of code existed in generic files specific to x86, so arm specific
> defines.

Some of us have filter to get quickly mail where we are CCed.

So please reply to all rather than only the mailing list.

Thanks,

-- 
Julien Grall

      reply	other threads:[~2015-02-20 12:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20 11:47 [RFC] [PATCH 3/3] XEN ARM PCI support Manish Jaggi
2015-02-20 11:53 ` Jan Beulich
2015-02-20 12:05   ` Manish Jaggi
2015-02-20 12:12     ` Julien Grall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E724C6.1020000@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=vijay.kilari@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.