All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Juergen Gross <jgross@suse.com>, <linux-kernel@vger.kernel.org>,
	<xen-devel@lists.xensource.com>, <konrad.wilk@oracle.com>,
	<david.vrabel@citrix.com>, <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH V2 1/3] xen: mark pvscsi frontend request consumed only after last read
Date: Fri, 20 Feb 2015 13:52:52 +0000	[thread overview]
Message-ID: <54E73C34.6080901@citrix.com> (raw)
In-Reply-To: <1424156569-13642-2-git-send-email-jgross@suse.com>

On 17/02/15 07:02, Juergen Gross wrote:
> A request in the ring buffer mustn't be read after it has been marked
> as consumed. Otherwise it might already have been reused by the
> frontend without violating the ring protocol.
> 
> To avoid inconsistencies in the backend only work on a private copy
> of the request. This will ensure a malicious guest not being able to
> bypass consistency checks of the backend by modifying an active
> request.

Applied to stable/for-linus-3.20 and tagged for stable, thanks.

David

WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Juergen Gross <jgross@suse.com>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
	konrad.wilk@oracle.com, david.vrabel@citrix.com,
	boris.ostrovsky@oracle.com
Subject: Re: [Xen-devel] [PATCH V2 1/3] xen: mark pvscsi frontend request consumed only after last read
Date: Fri, 20 Feb 2015 13:52:52 +0000	[thread overview]
Message-ID: <54E73C34.6080901@citrix.com> (raw)
In-Reply-To: <1424156569-13642-2-git-send-email-jgross@suse.com>

On 17/02/15 07:02, Juergen Gross wrote:
> A request in the ring buffer mustn't be read after it has been marked
> as consumed. Otherwise it might already have been reused by the
> frontend without violating the ring protocol.
> 
> To avoid inconsistencies in the backend only work on a private copy
> of the request. This will ensure a malicious guest not being able to
> bypass consistency checks of the backend by modifying an active
> request.

Applied to stable/for-linus-3.20 and tagged for stable, thanks.

David

  reply	other threads:[~2015-02-20 13:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-17  7:02 [PATCH V2 0/3] xen: pvscsi: avoid race, support suspend/resume Juergen Gross
2015-02-17  7:02 ` [PATCH V2 1/3] xen: mark pvscsi frontend request consumed only after last read Juergen Gross
2015-02-20 13:52   ` David Vrabel [this message]
2015-02-20 13:52     ` [Xen-devel] " David Vrabel
2015-02-17  7:02 ` [PATCH V2 2/3] xen: scsiback: add LUN of restored domain Juergen Gross
2015-02-18 17:02   ` Boris Ostrovsky
2015-02-24  6:06     ` Juergen Gross
2015-02-24 15:12       ` Boris Ostrovsky
2015-03-16 14:49   ` [Xen-devel] " David Vrabel
2015-03-16 14:49     ` David Vrabel
2015-02-17  7:02 ` [PATCH V2 3/3] xen: support suspend/resume in pvscsi frontend Juergen Gross
2015-03-16 14:50   ` [Xen-devel] " David Vrabel
2015-03-16 14:50     ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E73C34.6080901@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.