From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Jingoo Han <jg1.han@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Fabian Frederick <fabf@skynet.be>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: use msecs_to_jiffies for time conversion
Date: Fri, 20 Feb 2015 14:06:48 +0000 [thread overview]
Message-ID: <54E73F78.3050009@ti.com> (raw)
In-Reply-To: <20150220140110.GA25767@opentech.at>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On 20/02/15 16:01, Nicholas Mc Guire wrote:
>>> pr_debug("%s(): task ending\n", __func__);
>>> @@ -1460,7 +1460,7 @@ static void pxafb_disable_controller(struct pxafb_info *fbi)
>>> #ifdef CONFIG_FB_PXA_SMARTPANEL
>>> if (fbi->lccr0 & LCCR0_LCDT) {
>>> wait_for_completion_timeout(&fbi->refresh_done,
>>> - 200 * HZ / 1000);
>>> + msecs_to_jiffies(200);
>>
>> That will not compile.
> No compile warning or errors
>
> could you send me the compile error message and the toolchain you
> are using - this change should not really have any noticable impact.
I didn't compile it. It's missing a closing parenthesis.
This is one reason I'm not very fond of cleanups to drivers that the
patch sender cannot test... They may cause more problems than they help.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Jingoo Han <jg1.han@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Fabian Frederick <fabf@skynet.be>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Wolfram Sang <wsa@the-dreams.de>, <linux-fbdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] video: fbdev: use msecs_to_jiffies for time conversion
Date: Fri, 20 Feb 2015 16:06:48 +0200 [thread overview]
Message-ID: <54E73F78.3050009@ti.com> (raw)
In-Reply-To: <20150220140110.GA25767@opentech.at>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On 20/02/15 16:01, Nicholas Mc Guire wrote:
>>> pr_debug("%s(): task ending\n", __func__);
>>> @@ -1460,7 +1460,7 @@ static void pxafb_disable_controller(struct pxafb_info *fbi)
>>> #ifdef CONFIG_FB_PXA_SMARTPANEL
>>> if (fbi->lccr0 & LCCR0_LCDT) {
>>> wait_for_completion_timeout(&fbi->refresh_done,
>>> - 200 * HZ / 1000);
>>> + msecs_to_jiffies(200);
>>
>> That will not compile.
> No compile warning or errors
>
> could you send me the compile error message and the toolchain you
> are using - this change should not really have any noticable impact.
I didn't compile it. It's missing a closing parenthesis.
This is one reason I'm not very fond of cleanups to drivers that the
patch sender cannot test... They may cause more problems than they help.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-02-20 14:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 9:14 [PATCH] video: fbdev: use msecs_to_jiffies for time conversion Nicholas Mc Guire
2015-02-06 9:14 ` Nicholas Mc Guire
2015-02-20 12:24 ` Tomi Valkeinen
2015-02-20 12:24 ` Tomi Valkeinen
2015-02-20 14:01 ` Nicholas Mc Guire
2015-02-20 14:01 ` Nicholas Mc Guire
2015-02-20 14:06 ` Tomi Valkeinen [this message]
2015-02-20 14:06 ` Tomi Valkeinen
2015-02-20 14:20 ` Nicholas Mc Guire
2015-02-20 14:20 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E73F78.3050009@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=daniel.vetter@ffwll.ch \
--cc=der.herr@hofr.at \
--cc=fabf@skynet.be \
--cc=hofrat@osadl.org \
--cc=jg1.han@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.