Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Remove space beforetab

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/20/15 07:18, Ksenija Stanojević wrote:
> Thank you for your feedback. I'll try to keep that in mind next time.
> Should i make v2 out of this patch?

I think in this case it isn't necessary.

Jes


> On Fri, Feb 20, 2015 at 12:32 PM, Jes Sorensen <jes.sorensen@gmail.com>
> wrote:
> 
>>  [image: Boxbe] <https://www.boxbe.com/overview> Jes Sorensen (
>> jes.sorensen@gmail.com) added themselves to your Guest List
>> <https://www.boxbe.com/approved-list?tc_serial=20496783221&tc_rand=1493252507&utm_source=stf&utm_medium=email&utm_campaign=ANNO_TEST&utm_content=001&token=i2atJwHe4epXXgrOAoB9CRCp5nADSeAaRmjeHYkSuo%2FZyz5Dy5R9loS9DPc3JQf0&key=ZcbJ7iKYyZvdE1XUDLdCP3vOsOAhAqbogORJWFDMtAk%3D>
>> | Remove them
>> <https://www.boxbe.com/anno?action=remove&tc_serial=20496783221&tc_rand=1493252507&utm_source=stf&utm_medium=email&utm_campaign=ANNO_TEST&utm_content=001&token=i2atJwHe4epXXgrOAoB9CRCp5nADSeAaRmjeHYkSuo%2FZyz5Dy5R9loS9DPc3JQf0&key=ZcbJ7iKYyZvdE1XUDLdCP3vOsOAhAqbogORJWFDMtAk%3D>
>> | Block them
>> <https://www.boxbe.com/anno?action=add&disp=b&tc_serial=20496783221&tc_rand=1493252507&utm_source=stf&utm_medium=email&utm_campaign=ANNO_TEST&utm_content=001&token=i2atJwHe4epXXgrOAoB9CRCp5nADSeAaRmjeHYkSuo%2FZyz5Dy5R9loS9DPc3JQf0&key=ZcbJ7iKYyZvdE1XUDLdCP3vOsOAhAqbogORJWFDMtAk%3D>
>>
>> On 02/19/15 17:05, Ksenija Stanojevic wrote:
>>> This patch fixes the checkpatch.pl warning:
>>> WARNING: "please, no space before tabs"
>>>
>>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>>> ---
>>>  drivers/staging/rtl8192u/r819xU_phy.c | 8 ++++----
>>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> Again here your patch looks fine, the only thing needed to make it top
>> of the line is a more personalized commit message.
>>
>> Cheers,
>> Jes
>>
>>> diff --git a/drivers/staging/rtl8192u/r819xU_phy.c
>> b/drivers/staging/rtl8192u/r819xU_phy.c
>>> index 0589602..dbd3321 100644
>>> --- a/drivers/staging/rtl8192u/r819xU_phy.c
>>> +++ b/drivers/staging/rtl8192u/r819xU_phy.c
>>> @@ -106,10 +106,10 @@ void rtl8192_setBBreg(struct net_device *dev, u32
>> reg_addr, u32 bitmask,
>>>
>> /******************************************************************************
>>>   * function:  This function reads specific bits from BB register
>>>   * input:     net_device     *dev
>>> - *            u32            reg_addr   //target addr to be readback
>>> - *            u32            bitmask    //taget bit pos to be readback
>>> + *            u32            reg_addr   //target addr to be readback
>>> + *            u32            bitmask    //taget bit pos to be readback
>>>   * output:    none
>>> - * return:    u32            data       //the readback register value
>>> + * return:    u32            data       //the readback register value
>>>   * notice:
>>>
>>  ******************************************************************************/
>>>  u32 rtl8192_QueryBBReg(struct net_device *dev, u32 reg_addr, u32
>> bitmask)
>>> @@ -478,7 +478,7 @@ static void phy_FwRFSerialWrite(struct net_device
>> *dev,
>>>
>> /******************************************************************************
>>>   * function:  This function reads BB parameters from header file we
>> generate,
>>>   *            and do register read/write
>>> - * input:     net_device     *dev
>>> + * input:     net_device     *dev
>>>   * output:    none
>>>   * return:    none
>>>   * notice:    BB parameters may change all the time, so please make
>>>
>>
>>
>>
>