All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
	thierry.reding@gmail.com
Cc: linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4
Date: Fri, 20 Feb 2015 17:26:34 +0100	[thread overview]
Message-ID: <54E7603A.5010309@atmel.com> (raw)
In-Reply-To: <20150220170613.424edbb5@bbrezillon>

Le 20/02/2015 17:06, Boris Brezillon a écrit :
> Hi Nicolas,
> 
> On Fri, 20 Feb 2015 16:58:18 +0100
> Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> 
>> sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3
>> that is forbidding the use of div1 prescaler.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> The "atmel,sama5d4-hlcdc" compatible string is not yet documented in
> the atmel-hlcdc MFD driver binding, but this shouldn't hurt, so

Yes, I'll document it when I'm submitting your patches that add the
compatibility strings to the drivers/mfd/atmel-hlcdc.c. (with
atmel,at91sam9x5-hlcdc as well).

> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Thanks, bye.

>> ---
>>  drivers/pwm/pwm-atmel-hlcdc.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
>> index 522f7075bb1a..fa5feaba25a5 100644
>> --- a/drivers/pwm/pwm-atmel-hlcdc.c
>> +++ b/drivers/pwm/pwm-atmel-hlcdc.c
>> @@ -225,6 +225,10 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = {
>>  		.compatible = "atmel,sama5d3-hlcdc",
>>  		.data = &atmel_hlcdc_pwm_sama5d3_errata,
>>  	},
>> +	{
>> +		.compatible = "atmel,sama5d4-hlcdc",
>> +		.data = &atmel_hlcdc_pwm_sama5d3_errata,
>> +	},
>>  	{ /* sentinel */ },
>>  };
>>  
> 
> 
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4
Date: Fri, 20 Feb 2015 17:26:34 +0100	[thread overview]
Message-ID: <54E7603A.5010309@atmel.com> (raw)
In-Reply-To: <20150220170613.424edbb5@bbrezillon>

Le 20/02/2015 17:06, Boris Brezillon a ?crit :
> Hi Nicolas,
> 
> On Fri, 20 Feb 2015 16:58:18 +0100
> Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> 
>> sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3
>> that is forbidding the use of div1 prescaler.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> The "atmel,sama5d4-hlcdc" compatible string is not yet documented in
> the atmel-hlcdc MFD driver binding, but this shouldn't hurt, so

Yes, I'll document it when I'm submitting your patches that add the
compatibility strings to the drivers/mfd/atmel-hlcdc.c. (with
atmel,at91sam9x5-hlcdc as well).

> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Thanks, bye.

>> ---
>>  drivers/pwm/pwm-atmel-hlcdc.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
>> index 522f7075bb1a..fa5feaba25a5 100644
>> --- a/drivers/pwm/pwm-atmel-hlcdc.c
>> +++ b/drivers/pwm/pwm-atmel-hlcdc.c
>> @@ -225,6 +225,10 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = {
>>  		.compatible = "atmel,sama5d3-hlcdc",
>>  		.data = &atmel_hlcdc_pwm_sama5d3_errata,
>>  	},
>> +	{
>> +		.compatible = "atmel,sama5d4-hlcdc",
>> +		.data = &atmel_hlcdc_pwm_sama5d3_errata,
>> +	},
>>  	{ /* sentinel */ },
>>  };
>>  
> 
> 
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
	<thierry.reding@gmail.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-pwm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4
Date: Fri, 20 Feb 2015 17:26:34 +0100	[thread overview]
Message-ID: <54E7603A.5010309@atmel.com> (raw)
In-Reply-To: <20150220170613.424edbb5@bbrezillon>

Le 20/02/2015 17:06, Boris Brezillon a écrit :
> Hi Nicolas,
> 
> On Fri, 20 Feb 2015 16:58:18 +0100
> Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> 
>> sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3
>> that is forbidding the use of div1 prescaler.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> The "atmel,sama5d4-hlcdc" compatible string is not yet documented in
> the atmel-hlcdc MFD driver binding, but this shouldn't hurt, so

Yes, I'll document it when I'm submitting your patches that add the
compatibility strings to the drivers/mfd/atmel-hlcdc.c. (with
atmel,at91sam9x5-hlcdc as well).

> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Thanks, bye.

>> ---
>>  drivers/pwm/pwm-atmel-hlcdc.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
>> index 522f7075bb1a..fa5feaba25a5 100644
>> --- a/drivers/pwm/pwm-atmel-hlcdc.c
>> +++ b/drivers/pwm/pwm-atmel-hlcdc.c
>> @@ -225,6 +225,10 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = {
>>  		.compatible = "atmel,sama5d3-hlcdc",
>>  		.data = &atmel_hlcdc_pwm_sama5d3_errata,
>>  	},
>> +	{
>> +		.compatible = "atmel,sama5d4-hlcdc",
>> +		.data = &atmel_hlcdc_pwm_sama5d3_errata,
>> +	},
>>  	{ /* sentinel */ },
>>  };
>>  
> 
> 
> 


-- 
Nicolas Ferre

  reply	other threads:[~2015-02-20 16:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20 15:58 [PATCH] pwm: atmel-hlcdc: add errata handling for sama5d4 Nicolas Ferre
2015-02-20 15:58 ` Nicolas Ferre
2015-02-20 15:58 ` Nicolas Ferre
2015-02-20 16:06 ` Boris Brezillon
2015-02-20 16:06   ` Boris Brezillon
2015-02-20 16:06   ` Boris Brezillon
2015-02-20 16:26   ` Nicolas Ferre [this message]
2015-02-20 16:26     ` Nicolas Ferre
2015-02-20 16:26     ` Nicolas Ferre
2015-03-11 11:00     ` Thierry Reding
2015-03-11 11:00       ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E7603A.5010309@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.