From: Jan Kiszka <jan.kiszka@siemens.com>
To: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>,
Xenomai <xenomai@xenomai.org>
Subject: [Xenomai] ipipe: issues with ARM exception handling
Date: Fri, 20 Feb 2015 19:03:14 +0100 [thread overview]
Message-ID: <54E776E2.2030501@siemens.com> (raw)
Hi Gilles,
analyzing a lockdep warning on 3.16 with I-pipe enabled, I dug deeper
into the hard and virtual interrupt state management during exception
handling on ARM. I think there are several issues:
- ipipe_fault_entry should not fiddle with the root irq state if run
over head, only when invoked over root.
- ipipe_fault_exit must not change the root state unless we entered over
head and are about to leave over root - see x86. The current code may
keep root incorrectly stalled after an exception, though this will
probably be fixed up again in practice quickly.
- do_sect_fault is only called by do_DataAbort and do_PrefetchAbort,
in both cases already wrapped in ipipe_fault_entry/exit, thus it
shouldn't invoke them once again.
Room for optimization:
- ipipe_fault_entry is always called with hard IRQs off from
do_page_fault and do_translation_fault. I suspect this applies to the
remaining callers (do_DataAbort and do_PrefetchAbort ) as well. Thus
the hard IRQ state is actually known at compile time, right?
I can hack up patches, but I'd like to confirm first that I'm not
missing anything subtle or ARM-specific here.
Jan
next reply other threads:[~2015-02-20 18:03 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 18:03 Jan Kiszka [this message]
2015-02-20 18:13 ` [Xenomai] ipipe: issues with ARM exception handling Gilles Chanteperdrix
2015-02-20 18:17 ` Jan Kiszka
2015-02-20 18:19 ` Jan Kiszka
2015-02-20 19:44 ` Philippe Gerum
2015-02-20 19:47 ` Philippe Gerum
2015-02-20 19:52 ` Philippe Gerum
2015-02-23 16:06 ` Jan Kiszka
2015-02-23 16:32 ` Philippe Gerum
2015-02-23 16:37 ` Gilles Chanteperdrix
2015-02-23 16:50 ` Jan Kiszka
2015-02-23 16:52 ` Gilles Chanteperdrix
2015-02-23 17:02 ` Jan Kiszka
2015-02-23 17:14 ` Gilles Chanteperdrix
2015-02-23 17:38 ` Jan Kiszka
2015-02-23 17:49 ` Jan Kiszka
2015-02-23 17:52 ` Jan Kiszka
2015-02-23 18:30 ` Jan Kiszka
2015-02-24 16:23 ` Jan Kiszka
2015-02-24 16:45 ` Gilles Chanteperdrix
2015-02-24 16:46 ` Jan Kiszka
2015-02-24 16:50 ` Gilles Chanteperdrix
2015-02-23 16:55 ` Gilles Chanteperdrix
2015-02-23 17:01 ` Philippe Gerum
2015-02-23 17:12 ` Gilles Chanteperdrix
2015-02-23 17:21 ` Gilles Chanteperdrix
2015-02-23 17:43 ` Jan Kiszka
2015-02-23 17:51 ` Gilles Chanteperdrix
2015-02-23 17:54 ` Jan Kiszka
2015-02-23 18:04 ` Gilles Chanteperdrix
2015-02-23 18:11 ` Gilles Chanteperdrix
2015-02-23 18:16 ` Jan Kiszka
2015-02-23 18:32 ` Jan Kiszka
2015-02-23 18:34 ` Gilles Chanteperdrix
2015-02-23 19:14 ` Jan Kiszka
2015-02-23 19:18 ` Gilles Chanteperdrix
2015-02-23 18:33 ` Gilles Chanteperdrix
2015-02-23 19:13 ` Gilles Chanteperdrix
2015-02-23 20:25 ` Philippe Gerum
2015-02-23 20:27 ` Gilles Chanteperdrix
2015-02-23 20:33 ` Philippe Gerum
2015-02-23 20:38 ` Gilles Chanteperdrix
2015-02-23 20:49 ` Philippe Gerum
2015-02-23 20:54 ` Gilles Chanteperdrix
2015-02-23 20:43 ` Philippe Gerum
2015-02-23 20:46 ` Gilles Chanteperdrix
2015-02-23 17:02 ` Gilles Chanteperdrix
2015-02-20 18:38 ` Gilles Chanteperdrix
2015-02-20 18:51 ` Jan Kiszka
2015-02-20 18:53 ` Gilles Chanteperdrix
2015-02-20 18:57 ` Jan Kiszka
2015-02-20 18:59 ` Gilles Chanteperdrix
2015-02-20 19:04 ` Jan Kiszka
2015-02-21 9:13 ` Philippe Gerum
2015-02-23 15:59 ` Jan Kiszka
2015-02-23 16:29 ` Philippe Gerum
2015-02-23 16:58 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E776E2.2030501@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=gilles.chanteperdrix@xenomai.org \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.