Re: [Outreachy kernel] [PATCH] staging: rtl8712: Add blank line

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/20/15 13:58, Gamze POLAT wrote:
> WARNING: "Missing a blank line after declarations"
> That was found by running checkpatch.
> 
> Signed-off-by: Gamze POLAT <gamzepolat94@gmail.com>
> ---
>  drivers/staging/rtl8712/drv_types.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index e62543d..a775f8d 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -129,6 +129,7 @@ struct dvobj_priv {
>  	struct _adapter *padapter;
>  	u32 nr_endpoint;
>  	u8   ishighspeed;
> +
>  	uint (*inirp_init)(struct _adapter *adapter);
>  	uint (*inirp_deinit)(struct _adapter *adapter);
>  	struct usb_device *pusbdev;
> @@ -166,6 +167,7 @@ struct _adapter {
>  	 pid_t evtThread;
>  	struct task_struct *xmitThread;
>  	pid_t recvThread;
> +
>  	uint (*dvobj_init)(struct _adapter *adapter);
>  	void (*dvobj_deinit)(struct _adapter *adapter);
>  	struct net_device *pnetdev;
> 

This patch is actually wrong - I think checkpatch is confused here by
the declaration of function pointers, treating them like functions.

I do spot a whitespace issue that needs fixing in your patch, but the
blank lines added shouldn't be added.

Cheers,
Jes