* [PATCH] staging: rtl8712: Add blank line
@ 2015-02-20 18:58 Gamze POLAT
2015-02-20 19:37 ` [Outreachy kernel] " Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Gamze POLAT @ 2015-02-20 18:58 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Gamze POLAT
WARNING: "Missing a blank line after declarations"
That was found by running checkpatch.
Signed-off-by: Gamze POLAT <gamzepolat94@gmail.com>
---
drivers/staging/rtl8712/drv_types.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
index e62543d..a775f8d 100644
--- a/drivers/staging/rtl8712/drv_types.h
+++ b/drivers/staging/rtl8712/drv_types.h
@@ -129,6 +129,7 @@ struct dvobj_priv {
struct _adapter *padapter;
u32 nr_endpoint;
u8 ishighspeed;
+
uint (*inirp_init)(struct _adapter *adapter);
uint (*inirp_deinit)(struct _adapter *adapter);
struct usb_device *pusbdev;
@@ -166,6 +167,7 @@ struct _adapter {
pid_t evtThread;
struct task_struct *xmitThread;
pid_t recvThread;
+
uint (*dvobj_init)(struct _adapter *adapter);
void (*dvobj_deinit)(struct _adapter *adapter);
struct net_device *pnetdev;
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: rtl8712: Add blank line
2015-02-20 18:58 [PATCH] staging: rtl8712: Add blank line Gamze POLAT
@ 2015-02-20 19:37 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2015-02-20 19:37 UTC (permalink / raw)
To: Gamze POLAT, outreachy-kernel
On 02/20/15 13:58, Gamze POLAT wrote:
> WARNING: "Missing a blank line after declarations"
> That was found by running checkpatch.
>
> Signed-off-by: Gamze POLAT <gamzepolat94@gmail.com>
> ---
> drivers/staging/rtl8712/drv_types.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index e62543d..a775f8d 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -129,6 +129,7 @@ struct dvobj_priv {
> struct _adapter *padapter;
> u32 nr_endpoint;
> u8 ishighspeed;
> +
> uint (*inirp_init)(struct _adapter *adapter);
> uint (*inirp_deinit)(struct _adapter *adapter);
> struct usb_device *pusbdev;
> @@ -166,6 +167,7 @@ struct _adapter {
> pid_t evtThread;
> struct task_struct *xmitThread;
> pid_t recvThread;
> +
> uint (*dvobj_init)(struct _adapter *adapter);
> void (*dvobj_deinit)(struct _adapter *adapter);
> struct net_device *pnetdev;
>
This patch is actually wrong - I think checkpatch is confused here by
the declaration of function pointers, treating them like functions.
I do spot a whitespace issue that needs fixing in your patch, but the
blank lines added shouldn't be added.
Cheers,
Jes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-20 19:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-20 18:58 [PATCH] staging: rtl8712: Add blank line Gamze POLAT
2015-02-20 19:37 ` [Outreachy kernel] " Jes Sorensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.