From: Jes Sorensen <jes.sorensen@gmail.com>
To: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: Replace <asm/errno.h> with <linux/errno.h>
Date: Fri, 20 Feb 2015 14:39:16 -0500 [thread overview]
Message-ID: <54E78D64.9030201@gmail.com> (raw)
In-Reply-To: <1424461072-6219-1-git-send-email-ksenija.stanojevic@gmail.com>
On 02/20/15 14:37, Ksenija Stanojevic wrote:
> This patch fixes the following checkpatch.pl warning:
> Use #include <linux/errno.h> instead of <asm/errno.h>
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index 80dfa07..1fb6d85 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -16,7 +16,7 @@
> #include <linux/init.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> -#include <asm/errno.h>
> +#include <linux/errno.h>
>
> #include "ieee80211.h"
>
>
Patch is correct, but you should write a commit message instead of just
pasting in the checkpatch message.
Simply saying - "asm/errno.h should not be included directly" would suffice.
Cheers,
Jes
prev parent reply other threads:[~2015-02-20 19:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 19:37 [PATCH] Staging: rtl8192u: ieee80211: Replace <asm/errno.h> with <linux/errno.h> Ksenija Stanojevic
2015-02-20 19:39 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E78D64.9030201@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=ksenija.stanojevic@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.