All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: rtl8192u: ieee80211: Replace <asm/errno.h> with <linux/errno.h>
@ 2015-02-20 19:37 Ksenija Stanojevic
  2015-02-20 19:39 ` [Outreachy kernel] " Jes Sorensen
  0 siblings, 1 reply; 2+ messages in thread
From: Ksenija Stanojevic @ 2015-02-20 19:37 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Ksenija Stanojevic

This patch fixes the following checkpatch.pl warning:
Use #include <linux/errno.h> instead of <asm/errno.h>

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index 80dfa07..1fb6d85 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
@@ -16,7 +16,7 @@
 #include <linux/init.h>
 #include <linux/slab.h>
 #include <linux/string.h>
-#include <asm/errno.h>
+#include <linux/errno.h>
 
 #include "ieee80211.h"
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: Replace <asm/errno.h> with <linux/errno.h>
  2015-02-20 19:37 [PATCH] Staging: rtl8192u: ieee80211: Replace <asm/errno.h> with <linux/errno.h> Ksenija Stanojevic
@ 2015-02-20 19:39 ` Jes Sorensen
  0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2015-02-20 19:39 UTC (permalink / raw)
  To: Ksenija Stanojevic, outreachy-kernel

On 02/20/15 14:37, Ksenija Stanojevic wrote:
> This patch fixes the following checkpatch.pl warning:
> Use #include <linux/errno.h> instead of <asm/errno.h>
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index 80dfa07..1fb6d85 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -16,7 +16,7 @@
>  #include <linux/init.h>
>  #include <linux/slab.h>
>  #include <linux/string.h>
> -#include <asm/errno.h>
> +#include <linux/errno.h>
>  
>  #include "ieee80211.h"
>  
> 

Patch is correct, but you should write a commit message instead of just
pasting in the checkpatch message.

Simply saying - "asm/errno.h should not be included directly" would suffice.

Cheers,
Jes



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-20 19:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-20 19:37 [PATCH] Staging: rtl8192u: ieee80211: Replace <asm/errno.h> with <linux/errno.h> Ksenija Stanojevic
2015-02-20 19:39 ` [Outreachy kernel] " Jes Sorensen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.