Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Replace header files

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/20/15 16:26, Ksenija Stanojevic wrote:
> Files <asm/string.h> and <asm/errno.h> should not be included directly.
> This patch fixes the following checkpatch.pl warnings:
> Use #include <linux/errno.h> instead of <asm/errno.h>
> Use #include <linux/string.h> instead of <asm/string.h>
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This looks fine - next time, maybe add a blank line in the description
between "Files .....  and the line where you reference the checkpatch
warnings.

Cheers,
Jes

> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index 5533221..1fb6d85 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -15,8 +15,8 @@
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/slab.h>
> -#include <asm/string.h>
> -#include <asm/errno.h>
> +#include <linux/string.h>
> +#include <linux/errno.h>
>  
>  #include "ieee80211.h"
>  
>