* [PATCH] Staging: rtl8192u: Replace header files
@ 2015-02-20 21:26 Ksenija Stanojevic
2015-02-20 21:30 ` [Outreachy kernel] " Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Ksenija Stanojevic @ 2015-02-20 21:26 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Ksenija Stanojevic
Files <asm/string.h> and <asm/errno.h> should not be included directly.
This patch fixes the following checkpatch.pl warnings:
Use #include <linux/errno.h> instead of <asm/errno.h>
Use #include <linux/string.h> instead of <asm/string.h>
Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index 5533221..1fb6d85 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
@@ -15,8 +15,8 @@
#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
-#include <asm/string.h>
-#include <asm/errno.h>
+#include <linux/string.h>
+#include <linux/errno.h>
#include "ieee80211.h"
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Replace header files
2015-02-20 21:26 [PATCH] Staging: rtl8192u: Replace header files Ksenija Stanojevic
@ 2015-02-20 21:30 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2015-02-20 21:30 UTC (permalink / raw)
To: Ksenija Stanojevic, outreachy-kernel
On 02/20/15 16:26, Ksenija Stanojevic wrote:
> Files <asm/string.h> and <asm/errno.h> should not be included directly.
> This patch fixes the following checkpatch.pl warnings:
> Use #include <linux/errno.h> instead of <asm/errno.h>
> Use #include <linux/string.h> instead of <asm/string.h>
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This looks fine - next time, maybe add a blank line in the description
between "Files ..... and the line where you reference the checkpatch
warnings.
Cheers,
Jes
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index 5533221..1fb6d85 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -15,8 +15,8 @@
> #include <linux/module.h>
> #include <linux/init.h>
> #include <linux/slab.h>
> -#include <asm/string.h>
> -#include <asm/errno.h>
> +#include <linux/string.h>
> +#include <linux/errno.h>
>
> #include "ieee80211.h"
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-20 21:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-20 21:26 [PATCH] Staging: rtl8192u: Replace header files Ksenija Stanojevic
2015-02-20 21:30 ` [Outreachy kernel] " Jes Sorensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.