From: Chris Metcalf <cmetcalf@ezchip.com>
To: Chen Gang S <gang.chen@sunrus.com.cn>,
Peter Maydell <peter.maydell@linaro.org>,
Riku Voipio <riku.voipio@iki.fi>,
"rth@twiddle.net" <rth@twiddle.net>,
"walt@tilera.com" <walt@tilera.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 6/6 v3] linux-user/syscall.c: Switch all macros which are not defined in tilegx
Date: Fri, 20 Feb 2015 22:55:51 -0500 [thread overview]
Message-ID: <54E801C7.7000803@ezchip.com> (raw)
In-Reply-To: <54E67AAE.9060507@sunrus.com.cn>
On 2/19/2015 7:07 PM, Chen Gang S wrote:
> +#ifdef TARGET_NR_chown /* not on tilegx */
I would omit all these comments. The same will be true for arm64, microblaze, or any other kernel architecture submitted after the tile architecture went in.
--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
next prev parent reply other threads:[~2015-02-21 7:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 0:01 [Qemu-devel] [PATCH 0/6 v3] tilegx: Can load elf64 tilegx binary successfully for linux-user Chen Gang S
2015-02-20 0:02 ` [Qemu-devel] [PATCH 1/6 v3] target-tilegx: Firstly add to qemu with minimized features Chen Gang S
2015-02-20 0:04 ` [Qemu-devel] [PATCH 2/6 v3] linux-user: tilegx: Firstly add architecture related features Chen Gang S
2015-02-20 0:05 ` [Qemu-devel] [PATCH 3/6 v3] linux-user: tilegx: Add target features support within qemu Chen Gang S
2015-02-20 0:05 ` [Qemu-devel] [PATCH 4/6 v3] linux-user: Support tilegx architecture in syscall Chen Gang S
2015-02-20 0:06 ` [Qemu-devel] [PATCH 5/6 v3] linux-user: Support tilegx architecture in linux-user Chen Gang S
2015-02-20 0:07 ` [Qemu-devel] [PATCH 6/6 v3] linux-user/syscall.c: Switch all macros which are not defined in tilegx Chen Gang S
2015-02-21 3:55 ` Chris Metcalf [this message]
2015-02-21 7:18 ` Chen Gang S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E801C7.7000803@ezchip.com \
--to=cmetcalf@ezchip.com \
--cc=gang.chen@sunrus.com.cn \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=walt@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.