diff for duplicates of <54EA12DC.1000403@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index 9c6daf1..c4089f0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,32 +1,46 @@ -T24gMDIvMjIvMjAxNSAwMzo1MCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gSGVsbG8sCj4KPiBj -dXJyZW50bHkgaThrIGRyaXZlciBmb3IgREVMTERJQUcgU01NIG9wZXJhdGlvbnMgKGNoYXJnZXIs -Cj4gYmF0dGVyeSwgaG90a2V5cywgdGVtcGVyYXR1cmUgYW5kIGZhbiBjb250cm9sKSBzdXBwb3J0 -cyB0d28KPiBpbnRlcmZhY2VzOgo+Cj4gMSkgb2xkIC9wcm9jL2k4ayBjaGFyIGRldmljZQo+IDIp -IG5ldyBod21vbiBpbnRlcmZhY2UKPgo+IERyaXZlciBub3cgbGl2ZXMgaW4gY2hhciBzdWJzeXN0 -ZW0sIGJ1dCBub3dhZGF5cyBJIHRoaW5rIGxvdCBvZgo+IHBlb3BsZSBhcmUgaW50ZXJlc3RlZCBv -bmx5IGluIGh3bW9uIGludGVyZmFjZSB3aGljaCBwcm92aWRlcwo+IHRlbXBlcmF0dXJlICYgZmFu -IGNvbnRyb2wuIFBvd2VyIG1hbmFnZW1lbnQgYW5kIGhvdGtleXMgc3VwcG9ydAo+ICh3aGljaCBp -cyBtaXNzaW5nIGluIDIpIGJ1dCBwcm92aWRlZCBieSAxKSkgaXMgYWxyZWFkeSBoYW5kbGVkIGJ5 -Cj4gQUNQSSBvciBpbnB1dCBzdWJzeXN0ZW0gZm9yIG5ldyBsYXB0b3BzLgo+Cj4gQWxzbyBuYW1l -ICJpOGsiIGlzIHJlYWxseSBub24gaW50dWl0aXZlIHdoYXQgaXQgbWVhbnMgYW5kCj4gc3VwcG9y -dHMuLi4gKEkgd2FzIHRvbGQgaXQgaXMgYWJicmV2aWF0aW9uIGZvciBJbnNwaXJpb24gODAwMAo+ -IG1vZGVsIHdoaWNoIHdhcyBwcm9iYWJseSBmaXJzdCBkZWxsIG1vZGVsIHN1cHBvcnRlZCBieSB0 -aGF0Cj4gREVMTERJQUcgaW50ZXJmYWNlKS4gTm93IGRyaXZlciBpcyB1c2VkIG9uIFZvc3Rybywg -TGF0aXR1ZGUgYW5kCj4gYWxzbyBQcmVjaXNpb24gYW5kIFhQUyBtb2RlbHMuIEkgdGhpbmsgYXQg -bGVhc3QgImRlbGwiIHNob3VsZCBiZQo+IHBhcnQgb2YgZHJpdmVyIG5hbWUgYW5kIGNvbmZpZyBv -cHRpb24uCj4KPiBTbyBJIGhhdmUgaWRlYSBmb3Igc29tZSBjaGFuZ2VzOgo+Cj4gMSkgTW92ZSBk -cml2ZXIgZnJvbSBjaGFyIHN1YnN5c3RlbSB0byBod21vbgo+CkkgYW0gb2sgd2l0aCB0aGlzIG9u -ZS4KCj4gMikgUmVuYW1lIGRyaXZlciBmcm9tIGk4ayB0byBzb21ldGhpbmcgbGlrZSBkZWxsZGlh -ZyBvciBkZWxsc21tCj4KTWlnaHQgYmUgcHJvYmxlbWF0aWMsIGFzIGl0IHdvdWxkIGJyZWFrIGV4 -aXN0aW5nIGNvbmZpZ3VyYXRpb25zCnVubGVzcyB5b3Uga2VlcCB0aGUgQ09ORklHX0k4SyBidXQg -cmVuYW1lIHRoZSBkcml2ZXIuIERyaXZlciBuYW1lcwphcmUgbmV2ZXIgcGVyZmVjdCwgc28gSSB3 -b3VsZCBqdXN0IGxlYXZlIGl0IGFzIGlzLgoKPiAzKSBBZGQgbmV3IENPTkZJR18gb3B0aW9uIHRv -IGVuYWJsZS9kaXNhYmxlIC9wcm9jL2k4ayBkZXZpY2UgYW5kCj4gY29tcGlsZSBvbmx5IGh3bW9u -IGludGVyZmFjZSBzdXBwb3J0CgpNYWtlcyBzZW5zZS4gSSB3b3VsZCBzdWdnZXN0IHRvIG1ha2Ug -aHdtb24gc3VwcHBvcnQgdGhlIGRlZmF1bHQKYW5kIG1hbmRhdG9yeSBpZiB0aGUgZHJpdmVyIGlz -IGVuYWJsZWQgYW5kIGFkZCBhIG5ldyBDT05GSUdfSThLX1BST0NJRgpvciBzaW1pbGFyIHdoaWNo -IHNob3VsZCBiZSBlbmFibGVkIGJ5IGRlZmF1bHQuCgpBcmUgeW91IGludGVyZXN0ZWQgaW4gYWRk -aW5nIHlvdXJzZWxmIGFzIG1haW50YWluZXIgZm9yIHRoaXMgZHJpdmVyID8KClRoYW5rcywKR3Vl -bnRlcgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxt -LXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xp -c3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw= +On 02/22/2015 03:50 AM, Pali Rohár wrote: +> Hello, +> +> currently i8k driver for DELLDIAG SMM operations (charger, +> battery, hotkeys, temperature and fan control) supports two +> interfaces: +> +> 1) old /proc/i8k char device +> 2) new hwmon interface +> +> Driver now lives in char subsystem, but nowadays I think lot of +> people are interested only in hwmon interface which provides +> temperature & fan control. Power management and hotkeys support +> (which is missing in 2) but provided by 1)) is already handled by +> ACPI or input subsystem for new laptops. +> +> Also name "i8k" is really non intuitive what it means and +> supports... (I was told it is abbreviation for Inspirion 8000 +> model which was probably first dell model supported by that +> DELLDIAG interface). Now driver is used on Vostro, Latitude and +> also Precision and XPS models. I think at least "dell" should be +> part of driver name and config option. +> +> So I have idea for some changes: +> +> 1) Move driver from char subsystem to hwmon +> +I am ok with this one. + +> 2) Rename driver from i8k to something like delldiag or dellsmm +> +Might be problematic, as it would break existing configurations +unless you keep the CONFIG_I8K but rename the driver. Driver names +are never perfect, so I would just leave it as is. + +> 3) Add new CONFIG_ option to enable/disable /proc/i8k device and +> compile only hwmon interface support + +Makes sense. I would suggest to make hwmon suppport the default +and mandatory if the driver is enabled and add a new CONFIG_I8K_PROCIF +or similar which should be enabled by default. + +Are you interested in adding yourself as maintainer for this driver ? + +Thanks, +Guenter diff --git a/a/content_digest b/N1/content_digest index 260787a..e66a80d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0201502221250.49466@pali\0" "From\0Guenter Roeck <linux@roeck-us.net>\0" - "Subject\0Re: [lm-sensors] i8k: move driver from char to hwmon\0" - "Date\0Sun, 22 Feb 2015 17:33:16 +0000\0" + "Subject\0Re: i8k: move driver from char to hwmon\0" + "Date\0Sun, 22 Feb 2015 09:33:16 -0800\0" "To\0Pali Roh\303\241r <pali.rohar@gmail.com>" Arnd Bergmann <arnd@arndb.de> Greg Kroah-Hartman <gregkh@linuxfoundation.org> @@ -14,37 +14,51 @@ " lm-sensors@lm-sensors.org\0" "\00:1\0" "b\0" - "T24gMDIvMjIvMjAxNSAwMzo1MCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gSGVsbG8sCj4KPiBj\n" - "dXJyZW50bHkgaThrIGRyaXZlciBmb3IgREVMTERJQUcgU01NIG9wZXJhdGlvbnMgKGNoYXJnZXIs\n" - "Cj4gYmF0dGVyeSwgaG90a2V5cywgdGVtcGVyYXR1cmUgYW5kIGZhbiBjb250cm9sKSBzdXBwb3J0\n" - "cyB0d28KPiBpbnRlcmZhY2VzOgo+Cj4gMSkgb2xkIC9wcm9jL2k4ayBjaGFyIGRldmljZQo+IDIp\n" - "IG5ldyBod21vbiBpbnRlcmZhY2UKPgo+IERyaXZlciBub3cgbGl2ZXMgaW4gY2hhciBzdWJzeXN0\n" - "ZW0sIGJ1dCBub3dhZGF5cyBJIHRoaW5rIGxvdCBvZgo+IHBlb3BsZSBhcmUgaW50ZXJlc3RlZCBv\n" - "bmx5IGluIGh3bW9uIGludGVyZmFjZSB3aGljaCBwcm92aWRlcwo+IHRlbXBlcmF0dXJlICYgZmFu\n" - "IGNvbnRyb2wuIFBvd2VyIG1hbmFnZW1lbnQgYW5kIGhvdGtleXMgc3VwcG9ydAo+ICh3aGljaCBp\n" - "cyBtaXNzaW5nIGluIDIpIGJ1dCBwcm92aWRlZCBieSAxKSkgaXMgYWxyZWFkeSBoYW5kbGVkIGJ5\n" - "Cj4gQUNQSSBvciBpbnB1dCBzdWJzeXN0ZW0gZm9yIG5ldyBsYXB0b3BzLgo+Cj4gQWxzbyBuYW1l\n" - "ICJpOGsiIGlzIHJlYWxseSBub24gaW50dWl0aXZlIHdoYXQgaXQgbWVhbnMgYW5kCj4gc3VwcG9y\n" - "dHMuLi4gKEkgd2FzIHRvbGQgaXQgaXMgYWJicmV2aWF0aW9uIGZvciBJbnNwaXJpb24gODAwMAo+\n" - "IG1vZGVsIHdoaWNoIHdhcyBwcm9iYWJseSBmaXJzdCBkZWxsIG1vZGVsIHN1cHBvcnRlZCBieSB0\n" - "aGF0Cj4gREVMTERJQUcgaW50ZXJmYWNlKS4gTm93IGRyaXZlciBpcyB1c2VkIG9uIFZvc3Rybywg\n" - "TGF0aXR1ZGUgYW5kCj4gYWxzbyBQcmVjaXNpb24gYW5kIFhQUyBtb2RlbHMuIEkgdGhpbmsgYXQg\n" - "bGVhc3QgImRlbGwiIHNob3VsZCBiZQo+IHBhcnQgb2YgZHJpdmVyIG5hbWUgYW5kIGNvbmZpZyBv\n" - "cHRpb24uCj4KPiBTbyBJIGhhdmUgaWRlYSBmb3Igc29tZSBjaGFuZ2VzOgo+Cj4gMSkgTW92ZSBk\n" - "cml2ZXIgZnJvbSBjaGFyIHN1YnN5c3RlbSB0byBod21vbgo+CkkgYW0gb2sgd2l0aCB0aGlzIG9u\n" - "ZS4KCj4gMikgUmVuYW1lIGRyaXZlciBmcm9tIGk4ayB0byBzb21ldGhpbmcgbGlrZSBkZWxsZGlh\n" - "ZyBvciBkZWxsc21tCj4KTWlnaHQgYmUgcHJvYmxlbWF0aWMsIGFzIGl0IHdvdWxkIGJyZWFrIGV4\n" - "aXN0aW5nIGNvbmZpZ3VyYXRpb25zCnVubGVzcyB5b3Uga2VlcCB0aGUgQ09ORklHX0k4SyBidXQg\n" - "cmVuYW1lIHRoZSBkcml2ZXIuIERyaXZlciBuYW1lcwphcmUgbmV2ZXIgcGVyZmVjdCwgc28gSSB3\n" - "b3VsZCBqdXN0IGxlYXZlIGl0IGFzIGlzLgoKPiAzKSBBZGQgbmV3IENPTkZJR18gb3B0aW9uIHRv\n" - "IGVuYWJsZS9kaXNhYmxlIC9wcm9jL2k4ayBkZXZpY2UgYW5kCj4gY29tcGlsZSBvbmx5IGh3bW9u\n" - "IGludGVyZmFjZSBzdXBwb3J0CgpNYWtlcyBzZW5zZS4gSSB3b3VsZCBzdWdnZXN0IHRvIG1ha2Ug\n" - "aHdtb24gc3VwcHBvcnQgdGhlIGRlZmF1bHQKYW5kIG1hbmRhdG9yeSBpZiB0aGUgZHJpdmVyIGlz\n" - "IGVuYWJsZWQgYW5kIGFkZCBhIG5ldyBDT05GSUdfSThLX1BST0NJRgpvciBzaW1pbGFyIHdoaWNo\n" - "IHNob3VsZCBiZSBlbmFibGVkIGJ5IGRlZmF1bHQuCgpBcmUgeW91IGludGVyZXN0ZWQgaW4gYWRk\n" - "aW5nIHlvdXJzZWxmIGFzIG1haW50YWluZXIgZm9yIHRoaXMgZHJpdmVyID8KClRoYW5rcywKR3Vl\n" - "bnRlcgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxt\n" - "LXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xp\n" - c3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw= + "On 02/22/2015 03:50 AM, Pali Roh\303\241r wrote:\n" + "> Hello,\n" + ">\n" + "> currently i8k driver for DELLDIAG SMM operations (charger,\n" + "> battery, hotkeys, temperature and fan control) supports two\n" + "> interfaces:\n" + ">\n" + "> 1) old /proc/i8k char device\n" + "> 2) new hwmon interface\n" + ">\n" + "> Driver now lives in char subsystem, but nowadays I think lot of\n" + "> people are interested only in hwmon interface which provides\n" + "> temperature & fan control. Power management and hotkeys support\n" + "> (which is missing in 2) but provided by 1)) is already handled by\n" + "> ACPI or input subsystem for new laptops.\n" + ">\n" + "> Also name \"i8k\" is really non intuitive what it means and\n" + "> supports... (I was told it is abbreviation for Inspirion 8000\n" + "> model which was probably first dell model supported by that\n" + "> DELLDIAG interface). Now driver is used on Vostro, Latitude and\n" + "> also Precision and XPS models. I think at least \"dell\" should be\n" + "> part of driver name and config option.\n" + ">\n" + "> So I have idea for some changes:\n" + ">\n" + "> 1) Move driver from char subsystem to hwmon\n" + ">\n" + "I am ok with this one.\n" + "\n" + "> 2) Rename driver from i8k to something like delldiag or dellsmm\n" + ">\n" + "Might be problematic, as it would break existing configurations\n" + "unless you keep the CONFIG_I8K but rename the driver. Driver names\n" + "are never perfect, so I would just leave it as is.\n" + "\n" + "> 3) Add new CONFIG_ option to enable/disable /proc/i8k device and\n" + "> compile only hwmon interface support\n" + "\n" + "Makes sense. I would suggest to make hwmon suppport the default\n" + "and mandatory if the driver is enabled and add a new CONFIG_I8K_PROCIF\n" + "or similar which should be enabled by default.\n" + "\n" + "Are you interested in adding yourself as maintainer for this driver ?\n" + "\n" + "Thanks,\n" + Guenter -b67e407b075f9b0f289e691c5f21f5cb1c73159b2ed8cedfaae1e053e583621a +cd5e4d97275d6bea8c4b12cea8e5930be5f271438a69f9f8842fdf831da7bc7a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.