From: Guenter Roeck <linux@roeck-us.net>
To: "Pali Rohár" <pali.rohar@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Steven Honeyman" <stevenhoneyman@gmail.com>,
"Jean Delvare" <jdelvare@suse.de>,
Valdis.Kletnieks@vt.edu,
"Jochen Eisinger" <jochen@penguin-breeder.org>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] i8k: move driver from char to hwmon
Date: Sun, 22 Feb 2015 17:33:16 +0000 [thread overview]
Message-ID: <54EA12DC.1000403@roeck-us.net> (raw)
In-Reply-To: <201502221250.49466@pali>
T24gMDIvMjIvMjAxNSAwMzo1MCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gSGVsbG8sCj4KPiBj
dXJyZW50bHkgaThrIGRyaXZlciBmb3IgREVMTERJQUcgU01NIG9wZXJhdGlvbnMgKGNoYXJnZXIs
Cj4gYmF0dGVyeSwgaG90a2V5cywgdGVtcGVyYXR1cmUgYW5kIGZhbiBjb250cm9sKSBzdXBwb3J0
cyB0d28KPiBpbnRlcmZhY2VzOgo+Cj4gMSkgb2xkIC9wcm9jL2k4ayBjaGFyIGRldmljZQo+IDIp
IG5ldyBod21vbiBpbnRlcmZhY2UKPgo+IERyaXZlciBub3cgbGl2ZXMgaW4gY2hhciBzdWJzeXN0
ZW0sIGJ1dCBub3dhZGF5cyBJIHRoaW5rIGxvdCBvZgo+IHBlb3BsZSBhcmUgaW50ZXJlc3RlZCBv
bmx5IGluIGh3bW9uIGludGVyZmFjZSB3aGljaCBwcm92aWRlcwo+IHRlbXBlcmF0dXJlICYgZmFu
IGNvbnRyb2wuIFBvd2VyIG1hbmFnZW1lbnQgYW5kIGhvdGtleXMgc3VwcG9ydAo+ICh3aGljaCBp
cyBtaXNzaW5nIGluIDIpIGJ1dCBwcm92aWRlZCBieSAxKSkgaXMgYWxyZWFkeSBoYW5kbGVkIGJ5
Cj4gQUNQSSBvciBpbnB1dCBzdWJzeXN0ZW0gZm9yIG5ldyBsYXB0b3BzLgo+Cj4gQWxzbyBuYW1l
ICJpOGsiIGlzIHJlYWxseSBub24gaW50dWl0aXZlIHdoYXQgaXQgbWVhbnMgYW5kCj4gc3VwcG9y
dHMuLi4gKEkgd2FzIHRvbGQgaXQgaXMgYWJicmV2aWF0aW9uIGZvciBJbnNwaXJpb24gODAwMAo+
IG1vZGVsIHdoaWNoIHdhcyBwcm9iYWJseSBmaXJzdCBkZWxsIG1vZGVsIHN1cHBvcnRlZCBieSB0
aGF0Cj4gREVMTERJQUcgaW50ZXJmYWNlKS4gTm93IGRyaXZlciBpcyB1c2VkIG9uIFZvc3Rybywg
TGF0aXR1ZGUgYW5kCj4gYWxzbyBQcmVjaXNpb24gYW5kIFhQUyBtb2RlbHMuIEkgdGhpbmsgYXQg
bGVhc3QgImRlbGwiIHNob3VsZCBiZQo+IHBhcnQgb2YgZHJpdmVyIG5hbWUgYW5kIGNvbmZpZyBv
cHRpb24uCj4KPiBTbyBJIGhhdmUgaWRlYSBmb3Igc29tZSBjaGFuZ2VzOgo+Cj4gMSkgTW92ZSBk
cml2ZXIgZnJvbSBjaGFyIHN1YnN5c3RlbSB0byBod21vbgo+CkkgYW0gb2sgd2l0aCB0aGlzIG9u
ZS4KCj4gMikgUmVuYW1lIGRyaXZlciBmcm9tIGk4ayB0byBzb21ldGhpbmcgbGlrZSBkZWxsZGlh
ZyBvciBkZWxsc21tCj4KTWlnaHQgYmUgcHJvYmxlbWF0aWMsIGFzIGl0IHdvdWxkIGJyZWFrIGV4
aXN0aW5nIGNvbmZpZ3VyYXRpb25zCnVubGVzcyB5b3Uga2VlcCB0aGUgQ09ORklHX0k4SyBidXQg
cmVuYW1lIHRoZSBkcml2ZXIuIERyaXZlciBuYW1lcwphcmUgbmV2ZXIgcGVyZmVjdCwgc28gSSB3
b3VsZCBqdXN0IGxlYXZlIGl0IGFzIGlzLgoKPiAzKSBBZGQgbmV3IENPTkZJR18gb3B0aW9uIHRv
IGVuYWJsZS9kaXNhYmxlIC9wcm9jL2k4ayBkZXZpY2UgYW5kCj4gY29tcGlsZSBvbmx5IGh3bW9u
IGludGVyZmFjZSBzdXBwb3J0CgpNYWtlcyBzZW5zZS4gSSB3b3VsZCBzdWdnZXN0IHRvIG1ha2Ug
aHdtb24gc3VwcHBvcnQgdGhlIGRlZmF1bHQKYW5kIG1hbmRhdG9yeSBpZiB0aGUgZHJpdmVyIGlz
IGVuYWJsZWQgYW5kIGFkZCBhIG5ldyBDT05GSUdfSThLX1BST0NJRgpvciBzaW1pbGFyIHdoaWNo
IHNob3VsZCBiZSBlbmFibGVkIGJ5IGRlZmF1bHQuCgpBcmUgeW91IGludGVyZXN0ZWQgaW4gYWRk
aW5nIHlvdXJzZWxmIGFzIG1haW50YWluZXIgZm9yIHRoaXMgZHJpdmVyID8KClRoYW5rcywKR3Vl
bnRlcgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxt
LXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xp
c3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw=
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: "Pali Rohár" <pali.rohar@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Steven Honeyman" <stevenhoneyman@gmail.com>,
"Jean Delvare" <jdelvare@suse.de>,
Valdis.Kletnieks@vt.edu,
"Jochen Eisinger" <jochen@penguin-breeder.org>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: i8k: move driver from char to hwmon
Date: Sun, 22 Feb 2015 09:33:16 -0800 [thread overview]
Message-ID: <54EA12DC.1000403@roeck-us.net> (raw)
In-Reply-To: <201502221250.49466@pali>
On 02/22/2015 03:50 AM, Pali Rohár wrote:
> Hello,
>
> currently i8k driver for DELLDIAG SMM operations (charger,
> battery, hotkeys, temperature and fan control) supports two
> interfaces:
>
> 1) old /proc/i8k char device
> 2) new hwmon interface
>
> Driver now lives in char subsystem, but nowadays I think lot of
> people are interested only in hwmon interface which provides
> temperature & fan control. Power management and hotkeys support
> (which is missing in 2) but provided by 1)) is already handled by
> ACPI or input subsystem for new laptops.
>
> Also name "i8k" is really non intuitive what it means and
> supports... (I was told it is abbreviation for Inspirion 8000
> model which was probably first dell model supported by that
> DELLDIAG interface). Now driver is used on Vostro, Latitude and
> also Precision and XPS models. I think at least "dell" should be
> part of driver name and config option.
>
> So I have idea for some changes:
>
> 1) Move driver from char subsystem to hwmon
>
I am ok with this one.
> 2) Rename driver from i8k to something like delldiag or dellsmm
>
Might be problematic, as it would break existing configurations
unless you keep the CONFIG_I8K but rename the driver. Driver names
are never perfect, so I would just leave it as is.
> 3) Add new CONFIG_ option to enable/disable /proc/i8k device and
> compile only hwmon interface support
Makes sense. I would suggest to make hwmon suppport the default
and mandatory if the driver is enabled and add a new CONFIG_I8K_PROCIF
or similar which should be enabled by default.
Are you interested in adding yourself as maintainer for this driver ?
Thanks,
Guenter
next prev parent reply other threads:[~2015-02-22 17:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 11:50 [lm-sensors] i8k: move driver from char to hwmon Pali Rohár
2015-02-22 11:50 ` Pali Rohár
2015-02-22 17:33 ` Guenter Roeck [this message]
2015-02-22 17:33 ` Guenter Roeck
2015-02-22 17:44 ` [lm-sensors] " Pali Rohár
2015-02-22 17:44 ` Pali Rohár
2015-02-22 17:55 ` [lm-sensors] " Guenter Roeck
2015-02-22 17:55 ` Guenter Roeck
2015-02-22 18:11 ` [lm-sensors] " Guenter Roeck
2015-02-22 18:11 ` Guenter Roeck
2015-02-22 22:07 ` [lm-sensors] " Jean Delvare
2015-02-22 22:07 ` Jean Delvare
2015-02-22 23:31 ` [lm-sensors] " Guenter Roeck
2015-02-22 23:31 ` Guenter Roeck
2015-04-22 8:23 ` [lm-sensors] " Jean Delvare
2015-04-22 8:23 ` Jean Delvare
2015-04-22 8:42 ` [lm-sensors] " Pali Rohár
2015-04-22 8:42 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EA12DC.1000403@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Valdis.Kletnieks@vt.edu \
--cc=arnd@arndb.de \
--cc=gabriele.mzt@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=jochen@penguin-breeder.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=pali.rohar@gmail.com \
--cc=stevenhoneyman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.