From: Guenter Roeck <linux@roeck-us.net>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steven Honeyman <stevenhoneyman@gmail.com>,
Jean Delvare <jdelvare@suse.de>,
Valdis.Kletnieks@vt.edu,
Jochen Eisinger <jochen@penguin-breeder.org>,
Gabriele Mazzotta <gabriele.mzt@gmail.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] i8k: move driver from char to hwmon
Date: Sun, 22 Feb 2015 18:11:16 +0000 [thread overview]
Message-ID: <54EA1BC4.9080606@roeck-us.net> (raw)
In-Reply-To: <201502221844.54371@pali>
T24gMDIvMjIvMjAxNSAwOTo0NCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gT24gU3VuZGF5IDIy
IEZlYnJ1YXJ5IDIwMTUgMTg6MzM6MTYgR3VlbnRlciBSb2VjayB3cm90ZToKPj4KPj4+IDIpIFJl
bmFtZSBkcml2ZXIgZnJvbSBpOGsgdG8gc29tZXRoaW5nIGxpa2UgZGVsbGRpYWcgb3IKPj4+IGRl
bGxzbW0KPj4KPj4gTWlnaHQgYmUgcHJvYmxlbWF0aWMsIGFzIGl0IHdvdWxkIGJyZWFrIGV4aXN0
aW5nCj4+IGNvbmZpZ3VyYXRpb25zIHVubGVzcyB5b3Uga2VlcCB0aGUgQ09ORklHX0k4SyBidXQg
cmVuYW1lIHRoZQo+PiBkcml2ZXIuIERyaXZlciBuYW1lcyBhcmUgbmV2ZXIgcGVyZmVjdCwgc28g
SSB3b3VsZCBqdXN0IGxlYXZlCj4+IGl0IGFzIGlzLgo+Pgo+Pj4gMykgQWRkIG5ldyBDT05GSUdf
IG9wdGlvbiB0byBlbmFibGUvZGlzYWJsZSAvcHJvYy9pOGsgZGV2aWNlCj4+PiBhbmQgY29tcGls
ZSBvbmx5IGh3bW9uIGludGVyZmFjZSBzdXBwb3J0Cj4+Cj4+IE1ha2VzIHNlbnNlLiBJIHdvdWxk
IHN1Z2dlc3QgdG8gbWFrZSBod21vbiBzdXBwcG9ydCB0aGUKPj4gZGVmYXVsdCBhbmQgbWFuZGF0
b3J5IGlmIHRoZSBkcml2ZXIgaXMgZW5hYmxlZCBhbmQgYWRkIGEgbmV3Cj4+IENPTkZJR19JOEtf
UFJPQ0lGIG9yIHNpbWlsYXIgd2hpY2ggc2hvdWxkIGJlIGVuYWJsZWQgYnkKPj4gZGVmYXVsdC4K
Pj4KPgo+IFdoYXQgYWJvdXQgQ09ORklHX0RFTExESUFHIChvciBERUxMU01NIG9yIENPTkZJR19T
RU5TT1JTXyopIGZvcgo+IG1hbmRhdG9yeSBjb3JlICYgaHdtb24gY29kZSBhbmQgKGtlZXAgZXhp
c3RpbmcpIENPTkZJR19JOEsgZm9yCj4gL3Byb2MvaThrPwo+CgpPbmUgb3B0aW9uIG1pZ2h0IGJl
IHRvIGxlYXZlIENPTkZJR19JOEsgbW9yZSBvciBsZXNzIGFsb25lCihpdCBpcyBpbiBhcmNoL3g4
Ni9LY29uZmlnIGFueXdheSwgd2hpY2ggaXMgb2RkIGJ5IGl0c2VsZiksCmJ1dCBhZGQgc29tZXRo
aW5nIGxpa2UKCXNlbGVjdCBTRU5TT1JTX0RFTEwKCXNlbGVjdCBJOEtfUFJPQwp0byBpdC4gVGhl
biBhZGQgbmV3IGNvbmZpZyBvcHRpb25zIFNFTlNPUlNfREVMTCBhbmQKSThLX1BST0MgdG8gZHJp
dmVycy9od21vbi9LY29uZmlnLgoKSSB3b3VsZCBzdGlsbCBsZWF2ZSB0aGUgZHJpdmVyIG5hbWUg
YWxvbmUsIHRob3VnaDsgdGhlIHByb2JsZW0KaXMgdGhhdCAibW9kcHJvYmUgaThrIiBpcyBtZW50
aW9uZWQgaW4gcHJldHR5IG11Y2ggYWxsIHJlZmVyZW5jZXMKdG8gdGhlIGRyaXZlci4KCldlIGNv
dWxkIHRyeSB0byBtYWtlIGl0IHR3byBzZXBhcmF0ZSBkcml2ZXJzLCBvbmUgZm9yIHRoZSBod21v
bgppbnRlcmZhY2UgYW5kIG9uZSBmb3IgdGhlIHByb2MgaW50ZXJmYWNlICh3aGljaCB3b3VsZCBk
ZXBlbmQgb24KdGhlIGh3bW9uIGRyaXZlciksIGJ1dCBJIGFtIG5vdCBzdXJlIGlmIHRoYXQgaXMg
d29ydGggaXQgb3IgZXZlbgpmZWFzaWJsZS4gSXQgd291bGQgc2F2ZSB1cyBhIGJ1bmNoIG9mIGlm
ZGVmcyBpbiB0aGUgY29kZSwgdGhvdWdoLApzbyBpdCBtaWdodCBiZSB3b3J0aCBsb29raW5nIGlu
dG8uIEluIHRoYXQgY2FzZSB5b3Ugd291bGQgaGF2ZSBhCmRlbGwgaHdtb24gZHJpdmVyIGFuZCBh
IGRlbGwgaThrIGRyaXZlciAod2hpY2ggd291bGQgb25seSBleGlzdCBpZgpJOEtfUFJPQyBpcyBj
b25maWd1cmVkKS4KCkd1ZW50ZXIKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fXwpsbS1zZW5zb3JzIG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNv
cnMub3JnCmh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNl
bnNvcnM
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steven Honeyman <stevenhoneyman@gmail.com>,
Jean Delvare <jdelvare@suse.de>,
Valdis.Kletnieks@vt.edu,
Jochen Eisinger <jochen@penguin-breeder.org>,
Gabriele Mazzotta <gabriele.mzt@gmail.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: i8k: move driver from char to hwmon
Date: Sun, 22 Feb 2015 10:11:16 -0800 [thread overview]
Message-ID: <54EA1BC4.9080606@roeck-us.net> (raw)
In-Reply-To: <201502221844.54371@pali>
On 02/22/2015 09:44 AM, Pali Rohár wrote:
> On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote:
>>
>>> 2) Rename driver from i8k to something like delldiag or
>>> dellsmm
>>
>> Might be problematic, as it would break existing
>> configurations unless you keep the CONFIG_I8K but rename the
>> driver. Driver names are never perfect, so I would just leave
>> it as is.
>>
>>> 3) Add new CONFIG_ option to enable/disable /proc/i8k device
>>> and compile only hwmon interface support
>>
>> Makes sense. I would suggest to make hwmon suppport the
>> default and mandatory if the driver is enabled and add a new
>> CONFIG_I8K_PROCIF or similar which should be enabled by
>> default.
>>
>
> What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for
> mandatory core & hwmon code and (keep existing) CONFIG_I8K for
> /proc/i8k?
>
One option might be to leave CONFIG_I8K more or less alone
(it is in arch/x86/Kconfig anyway, which is odd by itself),
but add something like
select SENSORS_DELL
select I8K_PROC
to it. Then add new config options SENSORS_DELL and
I8K_PROC to drivers/hwmon/Kconfig.
I would still leave the driver name alone, though; the problem
is that "modprobe i8k" is mentioned in pretty much all references
to the driver.
We could try to make it two separate drivers, one for the hwmon
interface and one for the proc interface (which would depend on
the hwmon driver), but I am not sure if that is worth it or even
feasible. It would save us a bunch of ifdefs in the code, though,
so it might be worth looking into. In that case you would have a
dell hwmon driver and a dell i8k driver (which would only exist if
I8K_PROC is configured).
Guenter
next prev parent reply other threads:[~2015-02-22 18:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 11:50 [lm-sensors] i8k: move driver from char to hwmon Pali Rohár
2015-02-22 11:50 ` Pali Rohár
2015-02-22 17:33 ` [lm-sensors] " Guenter Roeck
2015-02-22 17:33 ` Guenter Roeck
2015-02-22 17:44 ` [lm-sensors] " Pali Rohár
2015-02-22 17:44 ` Pali Rohár
2015-02-22 17:55 ` [lm-sensors] " Guenter Roeck
2015-02-22 17:55 ` Guenter Roeck
2015-02-22 18:11 ` Guenter Roeck [this message]
2015-02-22 18:11 ` Guenter Roeck
2015-02-22 22:07 ` [lm-sensors] " Jean Delvare
2015-02-22 22:07 ` Jean Delvare
2015-02-22 23:31 ` [lm-sensors] " Guenter Roeck
2015-02-22 23:31 ` Guenter Roeck
2015-04-22 8:23 ` [lm-sensors] " Jean Delvare
2015-04-22 8:23 ` Jean Delvare
2015-04-22 8:42 ` [lm-sensors] " Pali Rohár
2015-04-22 8:42 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EA1BC4.9080606@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Valdis.Kletnieks@vt.edu \
--cc=arnd@arndb.de \
--cc=gabriele.mzt@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=jochen@penguin-breeder.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=pali.rohar@gmail.com \
--cc=stevenhoneyman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.