diff for duplicates of <54EA1BC4.9080606@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index 5210cb7..4043843 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,33 +1,46 @@ -T24gMDIvMjIvMjAxNSAwOTo0NCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gT24gU3VuZGF5IDIy -IEZlYnJ1YXJ5IDIwMTUgMTg6MzM6MTYgR3VlbnRlciBSb2VjayB3cm90ZToKPj4KPj4+IDIpIFJl -bmFtZSBkcml2ZXIgZnJvbSBpOGsgdG8gc29tZXRoaW5nIGxpa2UgZGVsbGRpYWcgb3IKPj4+IGRl -bGxzbW0KPj4KPj4gTWlnaHQgYmUgcHJvYmxlbWF0aWMsIGFzIGl0IHdvdWxkIGJyZWFrIGV4aXN0 -aW5nCj4+IGNvbmZpZ3VyYXRpb25zIHVubGVzcyB5b3Uga2VlcCB0aGUgQ09ORklHX0k4SyBidXQg -cmVuYW1lIHRoZQo+PiBkcml2ZXIuIERyaXZlciBuYW1lcyBhcmUgbmV2ZXIgcGVyZmVjdCwgc28g -SSB3b3VsZCBqdXN0IGxlYXZlCj4+IGl0IGFzIGlzLgo+Pgo+Pj4gMykgQWRkIG5ldyBDT05GSUdf -IG9wdGlvbiB0byBlbmFibGUvZGlzYWJsZSAvcHJvYy9pOGsgZGV2aWNlCj4+PiBhbmQgY29tcGls -ZSBvbmx5IGh3bW9uIGludGVyZmFjZSBzdXBwb3J0Cj4+Cj4+IE1ha2VzIHNlbnNlLiBJIHdvdWxk -IHN1Z2dlc3QgdG8gbWFrZSBod21vbiBzdXBwcG9ydCB0aGUKPj4gZGVmYXVsdCBhbmQgbWFuZGF0 -b3J5IGlmIHRoZSBkcml2ZXIgaXMgZW5hYmxlZCBhbmQgYWRkIGEgbmV3Cj4+IENPTkZJR19JOEtf -UFJPQ0lGIG9yIHNpbWlsYXIgd2hpY2ggc2hvdWxkIGJlIGVuYWJsZWQgYnkKPj4gZGVmYXVsdC4K -Pj4KPgo+IFdoYXQgYWJvdXQgQ09ORklHX0RFTExESUFHIChvciBERUxMU01NIG9yIENPTkZJR19T -RU5TT1JTXyopIGZvcgo+IG1hbmRhdG9yeSBjb3JlICYgaHdtb24gY29kZSBhbmQgKGtlZXAgZXhp -c3RpbmcpIENPTkZJR19JOEsgZm9yCj4gL3Byb2MvaThrPwo+CgpPbmUgb3B0aW9uIG1pZ2h0IGJl -IHRvIGxlYXZlIENPTkZJR19JOEsgbW9yZSBvciBsZXNzIGFsb25lCihpdCBpcyBpbiBhcmNoL3g4 -Ni9LY29uZmlnIGFueXdheSwgd2hpY2ggaXMgb2RkIGJ5IGl0c2VsZiksCmJ1dCBhZGQgc29tZXRo -aW5nIGxpa2UKCXNlbGVjdCBTRU5TT1JTX0RFTEwKCXNlbGVjdCBJOEtfUFJPQwp0byBpdC4gVGhl -biBhZGQgbmV3IGNvbmZpZyBvcHRpb25zIFNFTlNPUlNfREVMTCBhbmQKSThLX1BST0MgdG8gZHJp -dmVycy9od21vbi9LY29uZmlnLgoKSSB3b3VsZCBzdGlsbCBsZWF2ZSB0aGUgZHJpdmVyIG5hbWUg -YWxvbmUsIHRob3VnaDsgdGhlIHByb2JsZW0KaXMgdGhhdCAibW9kcHJvYmUgaThrIiBpcyBtZW50 -aW9uZWQgaW4gcHJldHR5IG11Y2ggYWxsIHJlZmVyZW5jZXMKdG8gdGhlIGRyaXZlci4KCldlIGNv -dWxkIHRyeSB0byBtYWtlIGl0IHR3byBzZXBhcmF0ZSBkcml2ZXJzLCBvbmUgZm9yIHRoZSBod21v -bgppbnRlcmZhY2UgYW5kIG9uZSBmb3IgdGhlIHByb2MgaW50ZXJmYWNlICh3aGljaCB3b3VsZCBk -ZXBlbmQgb24KdGhlIGh3bW9uIGRyaXZlciksIGJ1dCBJIGFtIG5vdCBzdXJlIGlmIHRoYXQgaXMg -d29ydGggaXQgb3IgZXZlbgpmZWFzaWJsZS4gSXQgd291bGQgc2F2ZSB1cyBhIGJ1bmNoIG9mIGlm -ZGVmcyBpbiB0aGUgY29kZSwgdGhvdWdoLApzbyBpdCBtaWdodCBiZSB3b3J0aCBsb29raW5nIGlu -dG8uIEluIHRoYXQgY2FzZSB5b3Ugd291bGQgaGF2ZSBhCmRlbGwgaHdtb24gZHJpdmVyIGFuZCBh -IGRlbGwgaThrIGRyaXZlciAod2hpY2ggd291bGQgb25seSBleGlzdCBpZgpJOEtfUFJPQyBpcyBj -b25maWd1cmVkKS4KCkd1ZW50ZXIKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f -X19fX19fX19fX19fXwpsbS1zZW5zb3JzIG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNv -cnMub3JnCmh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNl -bnNvcnM +On 02/22/2015 09:44 AM, Pali Rohár wrote: +> On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote: +>> +>>> 2) Rename driver from i8k to something like delldiag or +>>> dellsmm +>> +>> Might be problematic, as it would break existing +>> configurations unless you keep the CONFIG_I8K but rename the +>> driver. Driver names are never perfect, so I would just leave +>> it as is. +>> +>>> 3) Add new CONFIG_ option to enable/disable /proc/i8k device +>>> and compile only hwmon interface support +>> +>> Makes sense. I would suggest to make hwmon suppport the +>> default and mandatory if the driver is enabled and add a new +>> CONFIG_I8K_PROCIF or similar which should be enabled by +>> default. +>> +> +> What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for +> mandatory core & hwmon code and (keep existing) CONFIG_I8K for +> /proc/i8k? +> + +One option might be to leave CONFIG_I8K more or less alone +(it is in arch/x86/Kconfig anyway, which is odd by itself), +but add something like + select SENSORS_DELL + select I8K_PROC +to it. Then add new config options SENSORS_DELL and +I8K_PROC to drivers/hwmon/Kconfig. + +I would still leave the driver name alone, though; the problem +is that "modprobe i8k" is mentioned in pretty much all references +to the driver. + +We could try to make it two separate drivers, one for the hwmon +interface and one for the proc interface (which would depend on +the hwmon driver), but I am not sure if that is worth it or even +feasible. It would save us a bunch of ifdefs in the code, though, +so it might be worth looking into. In that case you would have a +dell hwmon driver and a dell i8k driver (which would only exist if +I8K_PROC is configured). + +Guenter diff --git a/a/content_digest b/N1/content_digest index 3c5bdd8..50e2992 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,8 @@ "ref\054EA12DC.1000403@roeck-us.net\0" "ref\0201502221844.54371@pali\0" "From\0Guenter Roeck <linux@roeck-us.net>\0" - "Subject\0Re: [lm-sensors] i8k: move driver from char to hwmon\0" - "Date\0Sun, 22 Feb 2015 18:11:16 +0000\0" + "Subject\0Re: i8k: move driver from char to hwmon\0" + "Date\0Sun, 22 Feb 2015 10:11:16 -0800\0" "To\0Pali Roh\303\241r <pali.rohar@gmail.com>\0" "Cc\0Arnd Bergmann <arnd@arndb.de>" Greg Kroah-Hartman <gregkh@linuxfoundation.org> @@ -16,38 +16,51 @@ " lm-sensors@lm-sensors.org\0" "\00:1\0" "b\0" - "T24gMDIvMjIvMjAxNSAwOTo0NCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gT24gU3VuZGF5IDIy\n" - "IEZlYnJ1YXJ5IDIwMTUgMTg6MzM6MTYgR3VlbnRlciBSb2VjayB3cm90ZToKPj4KPj4+IDIpIFJl\n" - "bmFtZSBkcml2ZXIgZnJvbSBpOGsgdG8gc29tZXRoaW5nIGxpa2UgZGVsbGRpYWcgb3IKPj4+IGRl\n" - "bGxzbW0KPj4KPj4gTWlnaHQgYmUgcHJvYmxlbWF0aWMsIGFzIGl0IHdvdWxkIGJyZWFrIGV4aXN0\n" - "aW5nCj4+IGNvbmZpZ3VyYXRpb25zIHVubGVzcyB5b3Uga2VlcCB0aGUgQ09ORklHX0k4SyBidXQg\n" - "cmVuYW1lIHRoZQo+PiBkcml2ZXIuIERyaXZlciBuYW1lcyBhcmUgbmV2ZXIgcGVyZmVjdCwgc28g\n" - "SSB3b3VsZCBqdXN0IGxlYXZlCj4+IGl0IGFzIGlzLgo+Pgo+Pj4gMykgQWRkIG5ldyBDT05GSUdf\n" - "IG9wdGlvbiB0byBlbmFibGUvZGlzYWJsZSAvcHJvYy9pOGsgZGV2aWNlCj4+PiBhbmQgY29tcGls\n" - "ZSBvbmx5IGh3bW9uIGludGVyZmFjZSBzdXBwb3J0Cj4+Cj4+IE1ha2VzIHNlbnNlLiBJIHdvdWxk\n" - "IHN1Z2dlc3QgdG8gbWFrZSBod21vbiBzdXBwcG9ydCB0aGUKPj4gZGVmYXVsdCBhbmQgbWFuZGF0\n" - "b3J5IGlmIHRoZSBkcml2ZXIgaXMgZW5hYmxlZCBhbmQgYWRkIGEgbmV3Cj4+IENPTkZJR19JOEtf\n" - "UFJPQ0lGIG9yIHNpbWlsYXIgd2hpY2ggc2hvdWxkIGJlIGVuYWJsZWQgYnkKPj4gZGVmYXVsdC4K\n" - "Pj4KPgo+IFdoYXQgYWJvdXQgQ09ORklHX0RFTExESUFHIChvciBERUxMU01NIG9yIENPTkZJR19T\n" - "RU5TT1JTXyopIGZvcgo+IG1hbmRhdG9yeSBjb3JlICYgaHdtb24gY29kZSBhbmQgKGtlZXAgZXhp\n" - "c3RpbmcpIENPTkZJR19JOEsgZm9yCj4gL3Byb2MvaThrPwo+CgpPbmUgb3B0aW9uIG1pZ2h0IGJl\n" - "IHRvIGxlYXZlIENPTkZJR19JOEsgbW9yZSBvciBsZXNzIGFsb25lCihpdCBpcyBpbiBhcmNoL3g4\n" - "Ni9LY29uZmlnIGFueXdheSwgd2hpY2ggaXMgb2RkIGJ5IGl0c2VsZiksCmJ1dCBhZGQgc29tZXRo\n" - "aW5nIGxpa2UKCXNlbGVjdCBTRU5TT1JTX0RFTEwKCXNlbGVjdCBJOEtfUFJPQwp0byBpdC4gVGhl\n" - "biBhZGQgbmV3IGNvbmZpZyBvcHRpb25zIFNFTlNPUlNfREVMTCBhbmQKSThLX1BST0MgdG8gZHJp\n" - "dmVycy9od21vbi9LY29uZmlnLgoKSSB3b3VsZCBzdGlsbCBsZWF2ZSB0aGUgZHJpdmVyIG5hbWUg\n" - "YWxvbmUsIHRob3VnaDsgdGhlIHByb2JsZW0KaXMgdGhhdCAibW9kcHJvYmUgaThrIiBpcyBtZW50\n" - "aW9uZWQgaW4gcHJldHR5IG11Y2ggYWxsIHJlZmVyZW5jZXMKdG8gdGhlIGRyaXZlci4KCldlIGNv\n" - "dWxkIHRyeSB0byBtYWtlIGl0IHR3byBzZXBhcmF0ZSBkcml2ZXJzLCBvbmUgZm9yIHRoZSBod21v\n" - "bgppbnRlcmZhY2UgYW5kIG9uZSBmb3IgdGhlIHByb2MgaW50ZXJmYWNlICh3aGljaCB3b3VsZCBk\n" - "ZXBlbmQgb24KdGhlIGh3bW9uIGRyaXZlciksIGJ1dCBJIGFtIG5vdCBzdXJlIGlmIHRoYXQgaXMg\n" - "d29ydGggaXQgb3IgZXZlbgpmZWFzaWJsZS4gSXQgd291bGQgc2F2ZSB1cyBhIGJ1bmNoIG9mIGlm\n" - "ZGVmcyBpbiB0aGUgY29kZSwgdGhvdWdoLApzbyBpdCBtaWdodCBiZSB3b3J0aCBsb29raW5nIGlu\n" - "dG8uIEluIHRoYXQgY2FzZSB5b3Ugd291bGQgaGF2ZSBhCmRlbGwgaHdtb24gZHJpdmVyIGFuZCBh\n" - "IGRlbGwgaThrIGRyaXZlciAod2hpY2ggd291bGQgb25seSBleGlzdCBpZgpJOEtfUFJPQyBpcyBj\n" - "b25maWd1cmVkKS4KCkd1ZW50ZXIKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f\n" - "X19fX19fX19fX19fXwpsbS1zZW5zb3JzIG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNv\n" - "cnMub3JnCmh0dHA6Ly9saXN0cy5sbS1zZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNl\n" - bnNvcnM + "On 02/22/2015 09:44 AM, Pali Roh\303\241r wrote:\n" + "> On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote:\n" + ">>\n" + ">>> 2) Rename driver from i8k to something like delldiag or\n" + ">>> dellsmm\n" + ">>\n" + ">> Might be problematic, as it would break existing\n" + ">> configurations unless you keep the CONFIG_I8K but rename the\n" + ">> driver. Driver names are never perfect, so I would just leave\n" + ">> it as is.\n" + ">>\n" + ">>> 3) Add new CONFIG_ option to enable/disable /proc/i8k device\n" + ">>> and compile only hwmon interface support\n" + ">>\n" + ">> Makes sense. I would suggest to make hwmon suppport the\n" + ">> default and mandatory if the driver is enabled and add a new\n" + ">> CONFIG_I8K_PROCIF or similar which should be enabled by\n" + ">> default.\n" + ">>\n" + ">\n" + "> What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for\n" + "> mandatory core & hwmon code and (keep existing) CONFIG_I8K for\n" + "> /proc/i8k?\n" + ">\n" + "\n" + "One option might be to leave CONFIG_I8K more or less alone\n" + "(it is in arch/x86/Kconfig anyway, which is odd by itself),\n" + "but add something like\n" + "\tselect SENSORS_DELL\n" + "\tselect I8K_PROC\n" + "to it. Then add new config options SENSORS_DELL and\n" + "I8K_PROC to drivers/hwmon/Kconfig.\n" + "\n" + "I would still leave the driver name alone, though; the problem\n" + "is that \"modprobe i8k\" is mentioned in pretty much all references\n" + "to the driver.\n" + "\n" + "We could try to make it two separate drivers, one for the hwmon\n" + "interface and one for the proc interface (which would depend on\n" + "the hwmon driver), but I am not sure if that is worth it or even\n" + "feasible. It would save us a bunch of ifdefs in the code, though,\n" + "so it might be worth looking into. In that case you would have a\n" + "dell hwmon driver and a dell i8k driver (which would only exist if\n" + "I8K_PROC is configured).\n" + "\n" + Guenter -71eab935a5fb0e2d60974d29a62b891396db12c78c72f85661c390e8d392fec4 +7bac834c9fc48c12a1739e5d3f88a88bf0c8886850dc65dabf3a7f52d02870cd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.