From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: "Tushar Behera" <trblinux@gmail.com>,
"Andreas Färber" <afaerber@suse.de>,
"Sangbeom Kim" <sbkim73@samsung.com>,
alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org
Cc: devicetree@vger.kernel.org, Doug Anderson <dianders@chromium.org>,
Vincent Palatin <vpalatin@chromium.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Takashi Iwai <tiwai@suse.de>, Xiubo Li <Li.Xiubo@freescale.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Tushar Behera <tushar.behera@linaro.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: max98088: Add master clock handling
Date: Mon, 23 Feb 2015 09:29:19 +0100 [thread overview]
Message-ID: <54EAE4DF.3040607@collabora.co.uk> (raw)
In-Reply-To: <54E6A9AB.4070401@gmail.com>
Hello,
On 02/20/2015 04:27 AM, Tushar Behera wrote:
> On 02/20/2015 12:48 AM, Andreas Färber wrote:
>> If master clock is provided through device tree, then update
>> the master clock frequency during set_sysclk.
>>
>> Cc: Tushar Behera <tushar.behera@linaro.org>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>> sound/soc/codecs/max98088.c | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>
> Looks good.
>
> Acked-by: Tushar Behera <trblinux@gmail.com>
>
Looks good to me as well.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] ASoC: max98088: Add master clock handling
Date: Mon, 23 Feb 2015 09:29:19 +0100 [thread overview]
Message-ID: <54EAE4DF.3040607@collabora.co.uk> (raw)
In-Reply-To: <54E6A9AB.4070401@gmail.com>
Hello,
On 02/20/2015 04:27 AM, Tushar Behera wrote:
> On 02/20/2015 12:48 AM, Andreas F?rber wrote:
>> If master clock is provided through device tree, then update
>> the master clock frequency during set_sysclk.
>>
>> Cc: Tushar Behera <tushar.behera@linaro.org>
>> Signed-off-by: Andreas F?rber <afaerber@suse.de>
>> ---
>> sound/soc/codecs/max98088.c | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>
> Looks good.
>
> Acked-by: Tushar Behera <trblinux@gmail.com>
>
Looks good to me as well.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
next prev parent reply other threads:[~2015-02-23 8:29 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 18:25 [PATCH 0/6] ASoC: samsung: Spring sound support Andreas Färber
2015-02-18 18:25 ` Andreas Färber
2015-02-18 18:25 ` Andreas Färber
2015-02-18 18:25 ` [PATCH 1/6] ASoC: max98088: Document DT bindings Andreas Färber
2015-02-18 18:25 ` Andreas Färber
2015-02-19 13:55 ` Javier Martinez Canillas
2015-02-19 13:55 ` Javier Martinez Canillas
2015-02-19 14:13 ` Andreas Färber
2015-02-19 14:13 ` Andreas Färber
2015-02-19 17:48 ` Doug Anderson
2015-02-19 17:48 ` Doug Anderson
2015-02-19 18:40 ` Andreas Färber
2015-02-19 18:40 ` Andreas Färber
2015-02-19 18:54 ` Andreas Färber
2015-02-19 18:54 ` Andreas Färber
2015-02-19 20:48 ` Javier Martinez Canillas
2015-02-19 20:48 ` Javier Martinez Canillas
2015-02-20 0:36 ` Andreas Färber
2015-02-20 0:36 ` Andreas Färber
2015-02-20 12:12 ` Sylwester Nawrocki
2015-02-20 12:12 ` Sylwester Nawrocki
2015-02-23 16:46 ` Javier Martinez Canillas
2015-02-23 16:46 ` Javier Martinez Canillas
2015-02-18 18:25 ` [PATCH 2/6] ASoC: max98088: Add " Andreas Färber
2015-02-18 18:25 ` Andreas Färber
2015-02-18 19:08 ` Sergei Shtylyov
2015-02-18 19:08 ` Sergei Shtylyov
2015-02-18 19:17 ` Andreas Färber
2015-02-18 19:17 ` Andreas Färber
2015-02-19 19:18 ` [PATCH] ASoC: max98088: Add master clock handling Andreas Färber
2015-02-19 19:18 ` Andreas Färber
2015-02-20 3:27 ` [alsa-devel] " Tushar Behera
2015-02-20 3:27 ` Tushar Behera
2015-02-23 8:29 ` Javier Martinez Canillas [this message]
2015-02-23 8:29 ` Javier Martinez Canillas
[not found] ` <54EAE4DF.3040607-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-02-23 12:23 ` Andreas Färber
2015-02-23 12:23 ` Andreas Färber
2015-02-23 12:23 ` Andreas Färber
2015-02-18 18:25 ` [PATCH 3/6] ARM: dts: Add max98089 to exynos5250-spring Andreas Färber
2015-02-18 18:25 ` Andreas Färber
2015-02-18 18:25 ` Andreas Färber
2015-02-18 18:25 ` [PATCH 4/6] ASoC: samsung: Document binding for max98089 based Snow driver Andreas Färber
2015-02-18 18:25 ` Andreas Färber
[not found] ` <1424283959-16289-5-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2015-02-19 3:49 ` [alsa-devel] " Tushar Behera
2015-02-19 3:49 ` Tushar Behera
2015-02-19 3:49 ` Tushar Behera
2015-02-18 18:25 ` [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089 Andreas Färber
2015-02-18 18:25 ` Andreas Färber
2015-02-18 18:25 ` Andreas Färber
2015-02-19 9:44 ` Mark Brown
2015-02-19 9:44 ` Mark Brown
2015-02-19 9:44 ` Mark Brown
2015-02-19 12:33 ` Andreas Färber
2015-02-19 12:33 ` Andreas Färber
[not found] ` <20150219094425.GB3198-bheZrs9scGb3/WHNxyQH9YN0K6Il/+VY@public.gmane.org>
2015-02-19 17:44 ` Doug Anderson
2015-02-19 17:44 ` Doug Anderson
2015-02-19 17:44 ` Doug Anderson
2015-02-19 17:56 ` Andreas Färber
2015-02-19 17:56 ` Andreas Färber
[not found] ` <54E623C9.7070001-l3A5Bk7waGM@public.gmane.org>
2015-02-19 19:01 ` Doug Anderson
2015-02-19 19:01 ` Doug Anderson
2015-02-19 19:01 ` Doug Anderson
2015-02-21 2:40 ` Mark Brown
2015-02-21 2:40 ` Mark Brown
2015-02-18 18:25 ` [PATCH 6/6] ARM: dts: Add sound support to exynos5250-spring Andreas Färber
2015-02-18 18:25 ` Andreas Färber
2015-02-18 18:25 ` Andreas Färber
2015-02-19 14:05 ` Javier Martinez Canillas
2015-02-19 14:05 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EAE4DF.3040607@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=Li.Xiubo@freescale.com \
--cc=afaerber@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.de \
--cc=tomasz.figa@gmail.com \
--cc=trblinux@gmail.com \
--cc=tushar.behera@linaro.org \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.