Re: [PATCH v2 04/15] tests/exynos: disable the G2D userptr/blend test

[Emil Velikov <emil.l.velikov@gmail.com>]

On 16/02/15 13:46, Tobias Jakobi wrote:
> v2: Move the commit description into the patch itself.
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>  tests/exynos/exynos_fimg2d_test.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c
> index aa140e5..55d2970 100644
> --- a/tests/exynos/exynos_fimg2d_test.c
> +++ b/tests/exynos/exynos_fimg2d_test.c
> @@ -788,11 +788,19 @@ int main(int argc, char **argv)
>  
>  	getchar();
>  
> +  /* The blend test uses the userptr functionality of exynos-drm, which     *
> +   * is currently not safe to use. If the kernel hasn't been build with     *
> +   * exynos-iommu support, then the blend test is going to produce (kernel) *
> +   * memory corruption, eventually leading to a system crash.               *
> +   *                                                                        *
> +   * Disable the test for now, until the kernel code has been sanitized.    */
> +#if 0
I cannot see a part of libdrm that uses this commenting format. Perhaps
use the more common:

/*
 * Some comment
 */

Cheers,
Emil