All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
	linux-samsung-soc@vger.kernel.org
Cc: emil.l.velikov@gmail.com, dri-devel@lists.freedesktop.org,
	robclark@freedesktop.org, m.szyprowski@samsung.com
Subject: Re: [v2] libdrm: improvements to userspace exynos component
Date: Mon, 23 Feb 2015 11:28:25 +0000	[thread overview]
Message-ID: <54EB0ED9.7000406@gmail.com> (raw)
In-Reply-To: <1424094405-6314-1-git-send-email-tjakobi@math.uni-bielefeld.de>

On 16/02/15 13:46, Tobias Jakobi wrote:
> Hello,
> 
> here are some miscellaneous improvements (small features, bugfixes, spelling fixes, etc.) for the exynos component of libdrm. The general idea is to let userspace use the G2D engine functionality more 
> efficiently.
> 
> If someone is interested in an application that actually makes use of this, the RetroArch frontend has a custom video backend:
> https://github.com/libretro/RetroArch/blob/master/gfx/drivers/exynos_gfx.c
> 
> 
> Please review and let me know what I can improve.
> 
> v2:
> - Mention value of G2D scaling normalization factor (02/15).
> - Moved patch (04/15) description from commit message to source itself, like suggested by Joonyoung Shim.
> 
Hi Tobias,

Imho these are some nice cleanups. I believe that the Samsung/Exynos
people need to comment on the device specific ones, but I've checked
2-4, 6, 8, 10, 13-15 and they are quite ok (baring a trivial comment)

Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

Thanks
Emil

P.S. Please don't recent the entire series, unless needed.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2015-02-23 11:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16 13:46 [v2] libdrm: improvements to userspace exynos component Tobias Jakobi
2015-02-16 13:46 ` [PATCH v2 01/15] tests/exynos: fimg2d: add a checkerboard test Tobias Jakobi
2015-02-16 13:46 ` [PATCH v2 02/15] exynos: replace G2D_DOUBLE_TO_FIXED macro with function Tobias Jakobi
2015-02-16 13:46 ` [PATCH v2 03/15] tests/exynos: fix typos and change wording Tobias Jakobi
2015-02-16 13:46 ` [PATCH v2 04/15] tests/exynos: disable the G2D userptr/blend test Tobias Jakobi
2015-02-23 11:21   ` Emil Velikov
2015-02-16 13:46 ` [PATCH v2 05/15] exynos: add g2d_scale_and_blend Tobias Jakobi
2015-02-16 13:46 ` [PATCH v2 06/15] tests/exynos: introduce wait_for_user_input Tobias Jakobi
2015-02-23 11:22   ` Emil Velikov
2015-02-23 11:28     ` Daniel Vetter
2015-02-16 13:46 ` [PATCH v2 07/15] exynos: honor the repeat mode in g2d_copy_with_scale Tobias Jakobi
2015-02-16 13:46 ` [PATCH v2 08/15] exynos: introduce g2d_add_base_addr helper function Tobias Jakobi
2015-02-23 11:22   ` Emil Velikov
2015-02-16 13:46 ` [PATCH v2 09/15] exynos: use structure initialization instead of memset Tobias Jakobi
2015-02-16 13:46 ` [PATCH v2 10/15] tests/exynos: improve error handling Tobias Jakobi
2015-02-16 13:46 ` [PATCH v2 11/15] exynos: add exynos prefix to fimg2d header Tobias Jakobi
2015-02-16 13:46 ` [PATCH v2 12/15] exynos: add fimg2d header to common includes Tobias Jakobi
2015-02-23 11:19   ` Emil Velikov
2015-02-16 13:46 ` [PATCH v2 13/15] exynos: fimg2d: fix comment for G2D_COEFF_MODE_GB_COLOR Tobias Jakobi
2015-02-23 11:28 ` Emil Velikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EB0ED9.7000406@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robclark@freedesktop.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.