From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Tony K Nadackal <tony.kn@samsung.com>, linux-samsung-soc@vger.kernel.org
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mchehab@osg.samsung.com,
j.anaszewski@samsung.com, kgene@kernel.org, k.debski@samsung.com,
bhushan.r@samsung.com
Subject: Re: [PATCH] [media] s5p-jpeg: Fix crash in jpeg isr due to multiple interrupts.
Date: Mon, 23 Feb 2015 16:26:06 +0100 [thread overview]
Message-ID: <54EB468E.2050505@samsung.com> (raw)
In-Reply-To: <1418797512-30226-1-git-send-email-tony.kn@samsung.com>
On 17/12/14 07:25, Tony K Nadackal wrote:
> In case of corrupt images, multiple interrupts may occur
> due to different error scenarios.
>
> Since we are removing the src and dest buffers in the first
> interrupt itself, crash occurs in the second error interrupts.
>
> Disable the global interrupt before we start processing
> the interrupt avoid the crash.
>
> Disable System interrupt in isr to avoid the crash below.
Rather than disabling all interrupts, is there no way to check
the interrupt reason from some status register and decide
whether we return the buffers or just ignore the interrupt ?
--
Thanks,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [media] s5p-jpeg: Fix crash in jpeg isr due to multiple interrupts.
Date: Mon, 23 Feb 2015 16:26:06 +0100 [thread overview]
Message-ID: <54EB468E.2050505@samsung.com> (raw)
In-Reply-To: <1418797512-30226-1-git-send-email-tony.kn@samsung.com>
On 17/12/14 07:25, Tony K Nadackal wrote:
> In case of corrupt images, multiple interrupts may occur
> due to different error scenarios.
>
> Since we are removing the src and dest buffers in the first
> interrupt itself, crash occurs in the second error interrupts.
>
> Disable the global interrupt before we start processing
> the interrupt avoid the crash.
>
> Disable System interrupt in isr to avoid the crash below.
Rather than disabling all interrupts, is there no way to check
the interrupt reason from some status register and decide
whether we return the buffers or just ignore the interrupt ?
--
Thanks,
Sylwester
next prev parent reply other threads:[~2015-02-23 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 6:25 [PATCH] [media] s5p-jpeg: Fix crash in jpeg isr due to multiple interrupts Tony K Nadackal
2014-12-17 6:25 ` Tony K Nadackal
2015-01-05 5:12 ` Tony K Nadackal
2015-01-05 5:12 ` Tony K Nadackal
2015-02-23 15:26 ` Sylwester Nawrocki [this message]
2015-02-23 15:26 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EB468E.2050505@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=bhushan.r@samsung.com \
--cc=j.anaszewski@samsung.com \
--cc=k.debski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=tony.kn@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.