* [PATCH] Staging: rtl8723au: core: Add spaces around that '='
@ 2015-02-23 16:08 Hatice ERTÜRK
2015-02-23 19:22 ` [Outreachy kernel] " Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Hatice ERTÜRK @ 2015-02-23 16:08 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Hatice ERTURK
This Error found with checkpatch.pl
ERROR: spaces required around that '='
Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
---
drivers/staging/rtl8723au/core/rtw_xmit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
index 2c9fe07..bece9b3 100644
--- a/drivers/staging/rtl8723au/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
@@ -645,7 +645,7 @@ static int xmitframe_addmic(struct rtw_adapter *padapter,
struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
int curfragnum, length;
u8 *pframe, *payload, mic[8];
- u8 priority[4]= {0x0, 0x0, 0x0, 0x0};
+ u8 priority[4] = {0x0, 0x0, 0x0, 0x0};
u8 hw_hdr_offset = 0;
int bmcst = is_multicast_ether_addr(pattrib->ra);
@@ -672,7 +672,7 @@ static int xmitframe_addmic(struct rtw_adapter *padapter,
if (pattrib->encrypt == WLAN_CIPHER_SUITE_TKIP) {
/* encode mic code */
if (stainfo) {
- u8 null_key[16]={0x0, 0x0, 0x0, 0x0,
+ u8 null_key[16] = {0x0, 0x0, 0x0, 0x0,
0x0, 0x0, 0x0, 0x0,
0x0, 0x0, 0x0, 0x0,
0x0, 0x0, 0x0, 0x0};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: core: Add spaces around that '='
2015-02-23 16:08 [PATCH] Staging: rtl8723au: core: Add spaces around that '=' Hatice ERTÜRK
@ 2015-02-23 19:22 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2015-02-23 19:22 UTC (permalink / raw)
To: Hatice ERTÜRK, outreachy-kernel
On 02/23/15 11:08, Hatice ERTÜRK wrote:
> This Error found with checkpatch.pl
>
> ERROR: spaces required around that '='
>
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
> drivers/staging/rtl8723au/core/rtw_xmit.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
> index 2c9fe07..bece9b3 100644
> --- a/drivers/staging/rtl8723au/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
> @@ -645,7 +645,7 @@ static int xmitframe_addmic(struct rtw_adapter *padapter,
> struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
> int curfragnum, length;
> u8 *pframe, *payload, mic[8];
> - u8 priority[4]= {0x0, 0x0, 0x0, 0x0};
> + u8 priority[4] = {0x0, 0x0, 0x0, 0x0};
> u8 hw_hdr_offset = 0;
> int bmcst = is_multicast_ether_addr(pattrib->ra);
>
> @@ -672,7 +672,7 @@ static int xmitframe_addmic(struct rtw_adapter *padapter,
> if (pattrib->encrypt == WLAN_CIPHER_SUITE_TKIP) {
> /* encode mic code */
> if (stainfo) {
> - u8 null_key[16]={0x0, 0x0, 0x0, 0x0,
> + u8 null_key[16] = {0x0, 0x0, 0x0, 0x0,
> 0x0, 0x0, 0x0, 0x0,
> 0x0, 0x0, 0x0, 0x0,
> 0x0, 0x0, 0x0, 0x0};
>
In the second portion, you should look at aligning the follow-on lines,
however an even better solution would be to memset() null_key.
Please also try and put a personalized commit message rather than just
the checkpatch words.
Cheers,
Jes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-23 19:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-23 16:08 [PATCH] Staging: rtl8723au: core: Add spaces around that '=' Hatice ERTÜRK
2015-02-23 19:22 ` [Outreachy kernel] " Jes Sorensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.