From: Jes Sorensen <jes.sorensen@gmail.com>
To: Navya Sri Nizamkari <navyasri.tech@gmail.com>,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v3 2/4] staging: rtl8192u: Clean-up comment line style
Date: Mon, 23 Feb 2015 14:46:56 -0500 [thread overview]
Message-ID: <54EB83B0.3090505@gmail.com> (raw)
In-Reply-To: <0103912c5f48fa319b9503c985a2fd28952e2b90.1424683660.git.navyasri.tech@gmail.com>
On 02/23/15 04:51, Navya Sri Nizamkari wrote:
> Convert style of comment from C99 to C89 to fix the
> following checkpatch.pl error:
>
> ERROR: "Do not use C99 // comments"
>
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
> Changes in v3:
> -None in this file of the patchset
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index eb89321..bcb2479 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -11,7 +11,7 @@
> *
> */
>
> -//#include <linux/config.h>
> +/* #include <linux/config.h> */
> #include <linux/module.h>
> #include <linux/init.h>
> #include <linux/slab.h>
>
This is dead code, rather than changing the comment style, you should
remove the line completely.
Cheers,
Jes
next prev parent reply other threads:[~2015-02-23 19:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 9:43 [PATCH v3 0/4] staging: rtl8192u: Fix warnings in ieee80211_crypt.c Navya Sri Nizamkari
2015-02-23 9:49 ` [PATCH v3 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_debug Navya Sri Nizamkari
2015-02-23 9:51 ` [PATCH v3 2/4] staging: rtl8192u: Clean-up comment line style Navya Sri Nizamkari
2015-02-23 19:46 ` Jes Sorensen [this message]
2015-02-26 7:26 ` [Outreachy kernel] " Navya Sri Nizamkari
2015-02-23 9:53 ` [PATCH v3 3/4] staging: rtl8192u: Replace asm header files with linux ones Navya Sri Nizamkari
2015-02-23 19:47 ` [Outreachy kernel] " Jes Sorensen
2015-02-23 9:54 ` [PATCH v3 4/4] staging: rtl8192u: Fix quoted string split across lines Navya Sri Nizamkari
2015-02-23 19:49 ` [Outreachy kernel] " Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EB83B0.3090505@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=navyasri.tech@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.