Re: [Outreachy kernel] [PATCH v3 4/4] staging: rtl8192u: Fix quoted string split across lines.

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/23/15 04:54, Navya Sri Nizamkari wrote:
> This patch fixes the checkpatch.pl warning:
> 
> WARNING: quoted string split across lines
> 
> Signed-off-by: Navya Sri Nizamkari <navyasri.tech@gmail.com>
> ---
> Changes in v3:
>     -None in this patch.
>     
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index 0aed175..c81193b 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -66,8 +66,8 @@ void ieee80211_crypt_deinit_handler(unsigned long data)
>  	spin_lock_irqsave(&ieee->lock, flags);
>  	ieee80211_crypt_deinit_entries(ieee, 0);
>  	if (!list_empty(&ieee->crypt_deinit_list)) {
> -		netdev_dbg(ieee->dev, "entries remaining in delayed crypt "
> -		       "deletion list\n");
> +		netdev_dbg(ieee->dev,
> +		   "entries remaining in delayed crypt deletion list\n");

The principle of your changes is good, but you need to get the
indentation right. If you put an argument to a function on the next
line, it needs to line up with the first argument of the function.

	netdev_dbg(foo,
		   very_long_argument_that_should_not_break_lines);

This is the same in all the cases below as well.

Jes


>  		ieee->crypt_deinit_timer.expires = jiffies + HZ;
>  		add_timer(&ieee->crypt_deinit_timer);
>  	}
> @@ -146,8 +146,8 @@ int ieee80211_unregister_crypto_ops(struct ieee80211_crypto_ops *ops)
>  	spin_unlock_irqrestore(&hcrypt->lock, flags);
>  
>  	if (del_alg) {
> -		pr_debug("ieee80211_crypt: unregistered algorithm "
> -		       "'%s'\n", ops->name);
> +		pr_debug("ieee80211_crypt: unregistered algorithm '%s'\n",
> +		     ops->name);
>  		kfree(del_alg);
>  	}
>  
> @@ -232,8 +232,8 @@ void __exit ieee80211_crypto_deinit(void)
>  		struct ieee80211_crypto_alg *alg =
>  			(struct ieee80211_crypto_alg *) ptr;
>  		list_del(ptr);
> -		pr_debug("ieee80211_crypt: unregistered algorithm "
> -		       "'%s' (deinit)\n", alg->ops->name);
> +		pr_debug("ieee80211_crypt: unregistered algorithm '%s' (deinit)\n",
> +		     alg->ops->name);
>  		kfree(alg);
>  	}
>  
>