From: John Snow <jsnow@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: "qemu-trivial >> QEMU Trivial" <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qerror.h: Swap definitions that were not in alphabetical order
Date: Mon, 23 Feb 2015 14:56:06 -0500 [thread overview]
Message-ID: <54EB85D6.1020509@redhat.com> (raw)
In-Reply-To: <1424458395-31906-1-git-send-email-berto@igalia.com>
On 02/20/2015 01:53 PM, Alberto Garcia wrote:
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> include/qapi/qmp/qerror.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
> index 986260f..57a62d4 100644
> --- a/include/qapi/qmp/qerror.h
> +++ b/include/qapi/qmp/qerror.h
> @@ -37,12 +37,12 @@ void qerror_report_err(Error *err);
> #define QERR_BASE_NOT_FOUND \
> ERROR_CLASS_GENERIC_ERROR, "Base '%s' not found"
>
> -#define QERR_BLOCK_JOB_NOT_READY \
> - ERROR_CLASS_GENERIC_ERROR, "The active block job for device '%s' cannot be completed"
> -
> #define QERR_BLOCK_FORMAT_FEATURE_NOT_SUPPORTED \
> ERROR_CLASS_GENERIC_ERROR, "Block format '%s' used by device '%s' does not support feature '%s'"
>
> +#define QERR_BLOCK_JOB_NOT_READY \
> + ERROR_CLASS_GENERIC_ERROR, "The active block job for device '%s' cannot be completed"
> +
> #define QERR_BUS_NO_HOTPLUG \
> ERROR_CLASS_GENERIC_ERROR, "Bus '%s' does not support hotplugging"
>
>
Cc: qemu-trivial@nongnu.org
Reviewed-by: John Snow <jsnow@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: John Snow <jsnow@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: "qemu-trivial >> QEMU Trivial" <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] qerror.h: Swap definitions that were not in alphabetical order
Date: Mon, 23 Feb 2015 14:56:06 -0500 [thread overview]
Message-ID: <54EB85D6.1020509@redhat.com> (raw)
In-Reply-To: <1424458395-31906-1-git-send-email-berto@igalia.com>
On 02/20/2015 01:53 PM, Alberto Garcia wrote:
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> include/qapi/qmp/qerror.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
> index 986260f..57a62d4 100644
> --- a/include/qapi/qmp/qerror.h
> +++ b/include/qapi/qmp/qerror.h
> @@ -37,12 +37,12 @@ void qerror_report_err(Error *err);
> #define QERR_BASE_NOT_FOUND \
> ERROR_CLASS_GENERIC_ERROR, "Base '%s' not found"
>
> -#define QERR_BLOCK_JOB_NOT_READY \
> - ERROR_CLASS_GENERIC_ERROR, "The active block job for device '%s' cannot be completed"
> -
> #define QERR_BLOCK_FORMAT_FEATURE_NOT_SUPPORTED \
> ERROR_CLASS_GENERIC_ERROR, "Block format '%s' used by device '%s' does not support feature '%s'"
>
> +#define QERR_BLOCK_JOB_NOT_READY \
> + ERROR_CLASS_GENERIC_ERROR, "The active block job for device '%s' cannot be completed"
> +
> #define QERR_BUS_NO_HOTPLUG \
> ERROR_CLASS_GENERIC_ERROR, "Bus '%s' does not support hotplugging"
>
>
Cc: qemu-trivial@nongnu.org
Reviewed-by: John Snow <jsnow@redhat.com>
next prev parent reply other threads:[~2015-02-23 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 18:53 [Qemu-devel] [PATCH] qerror.h: Swap definitions that were not in alphabetical order Alberto Garcia
2015-02-23 19:56 ` John Snow [this message]
2015-02-23 19:56 ` John Snow
-- strict thread matches above, loose matches on Subject: below --
2015-02-20 12:58 [Qemu-trivial] " Alberto Garcia
2015-02-28 9:04 ` Michael Tokarev
2015-03-02 9:39 ` [Qemu-trivial] [Qemu-devel] " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EB85D6.1020509@redhat.com \
--to=jsnow@redhat.com \
--cc=berto@igalia.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.