Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: core: Delete space

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/23/15 12:28, Hatice ERTÜRK wrote:
> This Error found with checkpatch.pl
> 
> ERROR: else should follow close brace '}'
> 
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_xmit.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Patch is good, but the commit message isn't correct. You are not
deleting space, but placing else on the same line as the closing bracket.

Cheers,
Jes


> diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
> index bece9b3..8124d9e 100644
> --- a/drivers/staging/rtl8723au/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
> @@ -914,8 +914,7 @@ static int rtw_make_wlanhdr(struct rtw_adapter *padapter, u8 *hdr,
>  
>  			if (psta->qos_option)
>  				qos_option = true;
> -		}
> -		else {
> +		} else {
>  			RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("fw_state:%x is not allowed to xmit frame\n", get_fwstate(pmlmepriv)));
>  			res = _FAIL;
>  			goto exit;
>