* [PATCH] Staging: rtl8723au: core: Delete space
@ 2015-02-23 17:28 Hatice ERTÜRK
2015-02-23 20:17 ` [Outreachy kernel] " Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Hatice ERTÜRK @ 2015-02-23 17:28 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Hatice ERTURK
This Error found with checkpatch.pl
ERROR: else should follow close brace '}'
Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
---
drivers/staging/rtl8723au/core/rtw_xmit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
index bece9b3..8124d9e 100644
--- a/drivers/staging/rtl8723au/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
@@ -914,8 +914,7 @@ static int rtw_make_wlanhdr(struct rtw_adapter *padapter, u8 *hdr,
if (psta->qos_option)
qos_option = true;
- }
- else {
+ } else {
RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("fw_state:%x is not allowed to xmit frame\n", get_fwstate(pmlmepriv)));
res = _FAIL;
goto exit;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: core: Delete space
2015-02-23 17:28 [PATCH] Staging: rtl8723au: core: Delete space Hatice ERTÜRK
@ 2015-02-23 20:17 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2015-02-23 20:17 UTC (permalink / raw)
To: Hatice ERTÜRK, outreachy-kernel
On 02/23/15 12:28, Hatice ERTÜRK wrote:
> This Error found with checkpatch.pl
>
> ERROR: else should follow close brace '}'
>
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
> drivers/staging/rtl8723au/core/rtw_xmit.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Patch is good, but the commit message isn't correct. You are not
deleting space, but placing else on the same line as the closing bracket.
Cheers,
Jes
> diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c
> index bece9b3..8124d9e 100644
> --- a/drivers/staging/rtl8723au/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723au/core/rtw_xmit.c
> @@ -914,8 +914,7 @@ static int rtw_make_wlanhdr(struct rtw_adapter *padapter, u8 *hdr,
>
> if (psta->qos_option)
> qos_option = true;
> - }
> - else {
> + } else {
> RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("fw_state:%x is not allowed to xmit frame\n", get_fwstate(pmlmepriv)));
> res = _FAIL;
> goto exit;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-23 20:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-23 17:28 [PATCH] Staging: rtl8723au: core: Delete space Hatice ERTÜRK
2015-02-23 20:17 ` [Outreachy kernel] " Jes Sorensen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.