From: Eric Blake <eblake@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qmp-commands.hx: Fix several typos
Date: Mon, 23 Feb 2015 14:26:28 -0700 [thread overview]
Message-ID: <54EB9B04.1070901@redhat.com> (raw)
In-Reply-To: <1424723236-24368-1-git-send-email-berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On 02/23/2015 01:27 PM, Alberto Garcia wrote:
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> qmp-commands.hx | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> @@ -2922,7 +2922,7 @@ Channels are described by a json-object, each one contain the following:
> - "channel-id": channel id. Usually "0", might be different needed when
> multiple channels of the same type exist, such as multiple
> display channels in a multihead setup (json-int)
> -- "tls": whevener the channel is encrypted (json-bool)
> +- "tls": whenever the channel is encrypted (json-bool)
Might be nicer as 'whether' rather than 'whenever'.
But as your version is strictly better than an obvious typo,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qmp-commands.hx: Fix several typos
Date: Mon, 23 Feb 2015 14:26:28 -0700 [thread overview]
Message-ID: <54EB9B04.1070901@redhat.com> (raw)
In-Reply-To: <1424723236-24368-1-git-send-email-berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On 02/23/2015 01:27 PM, Alberto Garcia wrote:
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> qmp-commands.hx | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> @@ -2922,7 +2922,7 @@ Channels are described by a json-object, each one contain the following:
> - "channel-id": channel id. Usually "0", might be different needed when
> multiple channels of the same type exist, such as multiple
> display channels in a multihead setup (json-int)
> -- "tls": whevener the channel is encrypted (json-bool)
> +- "tls": whenever the channel is encrypted (json-bool)
Might be nicer as 'whether' rather than 'whenever'.
But as your version is strictly better than an obvious typo,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-02-23 21:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 20:27 [Qemu-trivial] [PATCH] qmp-commands.hx: Fix several typos Alberto Garcia
2015-02-23 20:27 ` [Qemu-devel] " Alberto Garcia
2015-02-23 21:26 ` Eric Blake [this message]
2015-02-23 21:26 ` Eric Blake
2015-02-24 7:01 ` [Qemu-trivial] " Alberto Garcia
2015-02-24 7:01 ` Alberto Garcia
2015-02-24 16:34 ` [Qemu-trivial] " Eric Blake
2015-02-24 16:34 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EB9B04.1070901@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.