All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <jes.sorensen@gmail.com>
To: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
	 outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add blank line after declarations
Date: Mon, 23 Feb 2015 18:23:24 -0500	[thread overview]
Message-ID: <54EBB66C.3020104@gmail.com> (raw)
In-Reply-To: <1424730764-21137-1-git-send-email-aysemelikeyurtoglu@gmail.com>

On 02/23/15 17:32, Melike Yurtoglu wrote:
> WARNING: "Missing a blank line after declarations"
> That was found by running checkpatch
> 
> Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
> index 3c651d5..2c23aa9 100644
> --- a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
> +++ b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
> @@ -538,6 +538,7 @@ int ODM_RAInfo_Init(struct odm_dm_struct *dm_odm, u8 macid)
>  	struct odm_ra_info *pRaInfo = &dm_odm->RAInfo[macid];
>  	u8 WirelessMode = 0xFF; /* invalid value */
>  	u8 max_rate_idx = 0x13; /* MCS7 */
> +
>  	if (dm_odm->pWirelessMode != NULL)
>  		WirelessMode = *(dm_odm->pWirelessMode);
>  
> 

Patch looks fine - I as always prefer focusing on a slightly more
personal commit message, and less so on the checkpatch warning, but I
think this one is fine. I don't think you need to re-post this patch.

Jes



  reply	other threads:[~2015-02-23 23:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 22:32 [PATCH] Staging: rtl8188eu: Add blank line after declarations Melike Yurtoglu
2015-02-23 23:23 ` Jes Sorensen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-02-23 15:16 Dilek Uzulmez
2015-02-23 17:21 ` [Outreachy kernel] " Julia Lawall
2015-02-23 14:49 Dilek Uzulmez
2015-02-23 19:26 ` [Outreachy kernel] " Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EBB66C.3020104@gmail.com \
    --to=jes.sorensen@gmail.com \
    --cc=aysemelikeyurtoglu@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.