Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add blank line after declarations

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/23/15 09:49, Dilek Uzulmez wrote:
> This patch fixes these warning messages found by checkpatch.pl:
> WARNING: Missing a blank line after declarations.
> 
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 ++
>  1 file changed, 2 insertions(+)

The patch is good, however a more personalized commit message is
preferred. Something like:

"
Insert blank line between declarations and actual code.

This was found using checkpatch.pl
"

Cheers,
Jes


> diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> index df463a2..20e12d0 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> @@ -550,6 +550,7 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter)
>  inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
>  {
>  	struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
> +
>  	pwrpriv->ips_deny_time = jiffies + msecs_to_jiffies(ms);
>  }
>  
> @@ -573,6 +574,7 @@ int _rtw_pwr_wakeup(struct adapter *padapter, u32 ips_deffer_ms, const char *cal
>  
>  {
>  	u32 start = jiffies;
> +
>  	if (pwrpriv->ps_processing) {
>  		DBG_88E("%s wait ps_processing...\n", __func__);
>  		while (pwrpriv->ps_processing && rtw_get_passing_time_ms(start) <= 3000)
>