[PATCH] Staging: rtl8188eu: Add blank line after declarations

[PATCH] Staging: rtl8188eu: Add blank line after declarations

[Dilek Uzulmez]

This patch fixes these warning messages found by checkpatch.pl:
WARNING: Missing a blank line after declarations.

Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
index df463a2..20e12d0 100644
--- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
@@ -550,6 +550,7 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter)
 inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
 {
 	struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
+
 	pwrpriv->ips_deny_time = jiffies + msecs_to_jiffies(ms);
 }
 
@@ -573,6 +574,7 @@ int _rtw_pwr_wakeup(struct adapter *padapter, u32 ips_deffer_ms, const char *cal
 
 {
 	u32 start = jiffies;
+
 	if (pwrpriv->ps_processing) {
 		DBG_88E("%s wait ps_processing...\n", __func__);
 		while (pwrpriv->ps_processing && rtw_get_passing_time_ms(start) <= 3000)
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add blank line after declarations

[Julia Lawall]

On Mon, 23 Feb 2015, Dilek Uzulmez wrote:

> This patch fixes these warning messages found by checkpatch.pl:
> WARNING: Missing a blank line after declarations.
>
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/usb_halinit.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> index 14650e9..62e1be3 100644
> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> @@ -104,6 +104,7 @@ static u32 rtl8188eu_InitPowerOn(struct adapter *adapt)
>  	u16 value16;
>  	/*  HW Power on sequence */
>  	struct hal_data_8188e	*haldata	= GET_HAL_DATA(adapt);
> +
>  	if (haldata->bMacPwrCtrlOn)
>  		return _SUCCESS;
>
> @@ -234,6 +235,7 @@ static void _InitNormalChipOneOutEpPriority(struct adapter *Adapter)
>  	struct hal_data_8188e	*haldata	= GET_HAL_DATA(Adapter);
>

Perhaps one could remove this blank line?

>  	u16 value = 0;
> +
>  	switch (haldata->OutEpQueueSel) {
>  	case TX_SELE_HQ:
>  		value = QUEUE_HIGH;
> @@ -352,6 +354,7 @@ static void _InitTransferPageSize(struct adapter *Adapter)
>  	/*  Tx page size is always 128. */
>

And this one?

julia

>  	u8 value8;
> +
>  	value8 = _PSRX(PBP_128) | _PSTX(PBP_128);
>  	usb_write8(Adapter, REG_PBP, value8);
>  }
> @@ -1417,6 +1420,7 @@ static void SetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val)
>  		if (*((u8 *)val)) { /* under sitesurvey */
>  			/* config RCR to receive different BSSID & not to receive data frame */
>  			u32 v = usb_read32(Adapter, REG_RCR);
> +
>  			v &= ~(RCR_CBSSID_BCN);
>  			usb_write32(Adapter, REG_RCR, v);
>  			/* reject all data frame */
> @@ -1445,6 +1449,7 @@ static void SetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val)
>  			} else {
>  				if (Adapter->in_cta_test) {
>  					u32 v = usb_read32(Adapter, REG_RCR);
> +
>  					v &= ~(RCR_CBSSID_DATA | RCR_CBSSID_BCN);/*  RCR_ADF */
>  					usb_write32(Adapter, REG_RCR, v);
>  				} else {
> @@ -1589,6 +1594,7 @@ static void SetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val)
>  		{
>  			u32 cmd;
>  			u32 *cam_val = (u32 *)val;
> +
>  			usb_write32(Adapter, WCAMI, cam_val[0]);
>
>  			cmd = CAM_POLLINIG | CAM_WRITE | cam_val[1];
> @@ -1692,6 +1698,7 @@ static void SetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val)
>  	case HW_VAR_RXDMA_AGG_PG_TH:
>  		{
>  			u8 threshold = *((u8 *)val);
> +
>  			if (threshold == 0)
>  				threshold = haldata->UsbRxAggPageCount;
>  			usb_write8(Adapter, REG_RXDMA_AGG_PG_TH, threshold);
> @@ -1713,6 +1720,7 @@ static void SetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val)
>  	case HW_VAR_H2C_FW_JOINBSSRPT:
>  		{
>  			u8 mstatus = (*(u8 *)val);
> +
>  			rtl8188e_set_FwJoinBssReport_cmd(Adapter, mstatus);
>  		}
>  		break;
> @@ -1735,6 +1743,7 @@ static void SetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val)
>  	case HW_VAR_RPT_TIMER_SETTING:
>  		{
>  			u16 min_rpt_time = (*(u16 *)val);
> +
>  			ODM_RA_Set_TxRPT_Time(podmpriv, min_rpt_time);
>  		}
>  		break;
> @@ -1791,6 +1800,7 @@ static void SetHwReg8188EU(struct adapter *Adapter, u8 variable, u8 *val)
>  	case HW_VAR_TX_RPT_MAX_MACID:
>  		{
>  			u8 maxMacid = *val;
> +
>  			DBG_88E("### MacID(%d),Set Max Tx RPT MID(%d)\n", maxMacid, maxMacid+1);
>  			usb_write8(Adapter, REG_TX_RPT_CTRL+1, maxMacid+1);
>  		}
> @@ -1884,6 +1894,7 @@ GetHalDefVar8188EUsb(
>  			struct mlme_priv *pmlmepriv = &Adapter->mlmepriv;
>  			struct sta_priv *pstapriv = &Adapter->stapriv;
>  			struct sta_info *psta;
> +
>  			psta = rtw_get_stainfo(pstapriv, pmlmepriv->cur_network.network.MacAddress);
>  			if (psta)
>  				*((int *)pValue) = psta->rssi_stat.UndecoratedSmoothedPWDB;
> @@ -1931,6 +1942,7 @@ GetHalDefVar8188EUsb(
>  	case HW_DEF_RA_INFO_DUMP:
>  		{
>  			u8 entry_id = *((u8 *)pValue);
> +
>  			if (check_fwstate(&Adapter->mlmepriv, _FW_LINKED)) {
>  				DBG_88E("============ RA status check ===================\n");
>  				DBG_88E("Mac_id:%d , RateID = %d, RAUseRate = 0x%08x, RateSGI = %d, DecisionRate = 0x%02x ,PTStage = %d\n",
> @@ -1946,6 +1958,7 @@ GetHalDefVar8188EUsb(
>  	case HW_DEF_ODM_DBG_FLAG:
>  		{
>  			struct odm_dm_struct *dm_ocm = &(haldata->odmpriv);
> +
>  			pr_info("dm_ocm->DebugComponents = 0x%llx\n", dm_ocm->DebugComponents);
>  		}
>  		break;
> @@ -2011,6 +2024,7 @@ static u8 SetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eV
>  		{
>  			u8 bRSSIDump = *((u8 *)pValue);
>  			struct odm_dm_struct *dm_ocm = &(haldata->odmpriv);
> +
>  			if (bRSSIDump)
>  				dm_ocm->DebugComponents	=	ODM_COMP_DIG|ODM_COMP_FA_CNT;
>  			else
> @@ -2021,6 +2035,7 @@ static u8 SetHalDefVar8188EUsb(struct adapter *Adapter, enum hal_def_variable eV
>  		{
>  			u64	DebugComponents = *((u64 *)pValue);
>  			struct odm_dm_struct *dm_ocm = &(haldata->odmpriv);
> +
>  			dm_ocm->DebugComponents = DebugComponents;
>  		}
>  		break;
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424704560-7115-1-git-send-email-dilekuzulmez%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add blank line after declarations

[Jes Sorensen]

On 02/23/15 09:49, Dilek Uzulmez wrote:
> This patch fixes these warning messages found by checkpatch.pl:
> WARNING: Missing a blank line after declarations.
> 
> Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 ++
>  1 file changed, 2 insertions(+)

The patch is good, however a more personalized commit message is
preferred. Something like:

"
Insert blank line between declarations and actual code.

This was found using checkpatch.pl
"

Cheers,
Jes


> diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> index df463a2..20e12d0 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> @@ -550,6 +550,7 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter)
>  inline void rtw_set_ips_deny(struct adapter *padapter, u32 ms)
>  {
>  	struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
> +
>  	pwrpriv->ips_deny_time = jiffies + msecs_to_jiffies(ms);
>  }
>  
> @@ -573,6 +574,7 @@ int _rtw_pwr_wakeup(struct adapter *padapter, u32 ips_deffer_ms, const char *cal
>  
>  {
>  	u32 start = jiffies;
> +
>  	if (pwrpriv->ps_processing) {
>  		DBG_88E("%s wait ps_processing...\n", __func__);
>  		while (pwrpriv->ps_processing && rtw_get_passing_time_ms(start) <= 3000)
> 

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add blank line after declarations

[Jes Sorensen]

On 02/23/15 17:32, Melike Yurtoglu wrote:
> WARNING: "Missing a blank line after declarations"
> That was found by running checkpatch
> 
> Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
> index 3c651d5..2c23aa9 100644
> --- a/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
> +++ b/drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c
> @@ -538,6 +538,7 @@ int ODM_RAInfo_Init(struct odm_dm_struct *dm_odm, u8 macid)
>  	struct odm_ra_info *pRaInfo = &dm_odm->RAInfo[macid];
>  	u8 WirelessMode = 0xFF; /* invalid value */
>  	u8 max_rate_idx = 0x13; /* MCS7 */
> +
>  	if (dm_odm->pWirelessMode != NULL)
>  		WirelessMode = *(dm_odm->pWirelessMode);
>  
> 

Patch looks fine - I as always prefer focusing on a slightly more
personal commit message, and less so on the checkpatch warning, but I
think this one is fine. I don't think you need to re-post this patch.

Jes