From: Peter Lieven <pl@kamp.de>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, carnold@suse.com, jcody@redhat.com,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/5] block/vpc: optimize vpc_co_get_block_status
Date: Tue, 24 Feb 2015 07:41:36 +0100 [thread overview]
Message-ID: <54EC1D20.5030600@kamp.de> (raw)
In-Reply-To: <54EB6C99.9000600@redhat.com>
Am 23.02.2015 um 19:08 schrieb Max Reitz:
> On 2015-02-23 at 09:27, Peter Lieven wrote:
>> *pnum can't be greater than s->block_size / BDRV_SECTOR_SIZE for allocated
>> sectors since there is always a bitmap in between.
>>
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> ---
>> block/vpc.c | 15 ++++++---------
>> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> I would like a comment about this in or above the "if (allocated)" in the do-while loop, but in any case:
Will add in v2.
Peter
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2015-02-24 6:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 14:27 [Qemu-devel] [PATCH 0/5] block/vpc optimizations Peter Lieven
2015-02-23 14:27 ` [Qemu-devel] [PATCH 1/5] block/vpc: optimize vpc_co_get_block_status Peter Lieven
2015-02-23 18:08 ` Max Reitz
2015-02-24 6:41 ` Peter Lieven [this message]
2015-02-23 14:27 ` [Qemu-devel] [PATCH 2/5] block/vpc: simplify vpc_read Peter Lieven
2015-02-23 18:29 ` Max Reitz
2015-02-24 6:44 ` Peter Lieven
2015-02-24 14:09 ` Max Reitz
2015-02-23 14:27 ` [Qemu-devel] [PATCH 3/5] vpc: Ignore geometry for large images Peter Lieven
2015-02-23 18:34 ` Max Reitz
2015-02-24 6:45 ` Peter Lieven
2015-02-24 14:12 ` Max Reitz
2015-02-23 14:27 ` [Qemu-devel] [PATCH 4/5] block/vpc: make calculate_geometry spec conform Peter Lieven
2015-02-23 18:59 ` Max Reitz
2015-02-24 6:49 ` Peter Lieven
2015-02-24 14:14 ` Max Reitz
2015-02-23 14:27 ` [Qemu-devel] [PATCH 5/5] block/vpc: rename footer->size -> footer->current_size Peter Lieven
2015-02-23 19:04 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EC1D20.5030600@kamp.de \
--to=pl@kamp.de \
--cc=carnold@suse.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.